* [PATCH] Input: wacom - Advertise BTN_TOOL_PEN and BTN_STYLUS for PenPartner
@ 2011-08-26 21:31 Jason Gerecke
2011-08-26 21:48 ` Ping Cheng
0 siblings, 1 reply; 3+ messages in thread
From: Jason Gerecke @ 2011-08-26 21:31 UTC (permalink / raw)
To: linux-input; +Cc: pinglinux, dmitry.torokhov, Jason Gerecke
The Wacom PenPartner should advertise its stylus tip and button
in addition to the eraser tool. These are both physically
present on the hardware, and emitted from 'wacom_penpartner_irq'.
Signed-off-by: Jason Gerecke <killertofu@gmail.com>
---
drivers/input/tablet/wacom_wac.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
index c1c2f7b..87b0e0d 100644
--- a/drivers/input/tablet/wacom_wac.c
+++ b/drivers/input/tablet/wacom_wac.c
@@ -1191,13 +1191,13 @@ void wacom_setup_input_capabilities(struct input_dev *input_dev,
case PL:
case PTU:
case DTU:
- __set_bit(BTN_TOOL_PEN, input_dev->keybit);
- __set_bit(BTN_STYLUS, input_dev->keybit);
__set_bit(BTN_STYLUS2, input_dev->keybit);
/* fall through */
case PENPARTNER:
+ __set_bit(BTN_TOOL_PEN, input_dev->keybit);
__set_bit(BTN_TOOL_RUBBER, input_dev->keybit);
+ __set_bit(BTN_STYLUS, input_dev->keybit);
break;
case BAMBOO_PT:
--
1.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: wacom - Advertise BTN_TOOL_PEN and BTN_STYLUS for PenPartner
2011-08-26 21:31 [PATCH] Input: wacom - Advertise BTN_TOOL_PEN and BTN_STYLUS for PenPartner Jason Gerecke
@ 2011-08-26 21:48 ` Ping Cheng
2011-08-27 6:30 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Ping Cheng @ 2011-08-26 21:48 UTC (permalink / raw)
To: Jason Gerecke; +Cc: linux-input, dmitry.torokhov
On Fri, Aug 26, 2011 at 2:31 PM, Jason Gerecke <killertofu@gmail.com> wrote:
> The Wacom PenPartner should advertise its stylus tip and button
> in addition to the eraser tool. These are both physically
> present on the hardware, and emitted from 'wacom_penpartner_irq'.
>
> Signed-off-by: Jason Gerecke <killertofu@gmail.com>
Reviewed-by: Ping Cheng <pingc@wacom.com>
Ping
> ---
> drivers/input/tablet/wacom_wac.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
> index c1c2f7b..87b0e0d 100644
> --- a/drivers/input/tablet/wacom_wac.c
> +++ b/drivers/input/tablet/wacom_wac.c
> @@ -1191,13 +1191,13 @@ void wacom_setup_input_capabilities(struct input_dev *input_dev,
> case PL:
> case PTU:
> case DTU:
> - __set_bit(BTN_TOOL_PEN, input_dev->keybit);
> - __set_bit(BTN_STYLUS, input_dev->keybit);
> __set_bit(BTN_STYLUS2, input_dev->keybit);
> /* fall through */
>
> case PENPARTNER:
> + __set_bit(BTN_TOOL_PEN, input_dev->keybit);
> __set_bit(BTN_TOOL_RUBBER, input_dev->keybit);
> + __set_bit(BTN_STYLUS, input_dev->keybit);
> break;
>
> case BAMBOO_PT:
> --
> 1.7.6
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: wacom - Advertise BTN_TOOL_PEN and BTN_STYLUS for PenPartner
2011-08-26 21:48 ` Ping Cheng
@ 2011-08-27 6:30 ` Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2011-08-27 6:30 UTC (permalink / raw)
To: Ping Cheng; +Cc: Jason Gerecke, linux-input
On Fri, Aug 26, 2011 at 02:48:43PM -0700, Ping Cheng wrote:
> On Fri, Aug 26, 2011 at 2:31 PM, Jason Gerecke <killertofu@gmail.com> wrote:
> > The Wacom PenPartner should advertise its stylus tip and button
> > in addition to the eraser tool. These are both physically
> > present on the hardware, and emitted from 'wacom_penpartner_irq'.
> >
> > Signed-off-by: Jason Gerecke <killertofu@gmail.com>
>
> Reviewed-by: Ping Cheng <pingc@wacom.com>
Applied, thanks Jason.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-27 6:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-26 21:31 [PATCH] Input: wacom - Advertise BTN_TOOL_PEN and BTN_STYLUS for PenPartner Jason Gerecke
2011-08-26 21:48 ` Ping Cheng
2011-08-27 6:30 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox