* [PATCH] Input: tegra-kbc: Fix: Allocate pdata before using it
@ 2012-03-27 5:54 Viresh Kumar
2012-03-27 6:47 ` Dmitry Torokhov
0 siblings, 1 reply; 4+ messages in thread
From: Viresh Kumar @ 2012-03-27 5:54 UTC (permalink / raw)
To: dmitry.torokhov, swarren; +Cc: olof, linux-input, srasal, Viresh Kumar
Following commit broke DT support for tegra-kbc by removing pdata allocation
completely.
commit 023cea0ecfa2df034096c3f4afa796a0b2d1188a
Author: Shridhar Rasal <srasal@nvidia.com>
Date: Fri Feb 3 00:27:30 2012 -0800
Input: tegra-kbc - allow skipping setting up some of GPIO pins
This patch restores it.
Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
---
drivers/input/keyboard/tegra-kbc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
index 96ee31e..5827fbe 100644
--- a/drivers/input/keyboard/tegra-kbc.c
+++ b/drivers/input/keyboard/tegra-kbc.c
@@ -630,6 +630,7 @@ tegra_kbc_dt_parse_pdata(struct platform_device *pdev)
if (!np)
return NULL;
+ pdata = kzalloc(sizeof(*pdata), GFP_KERNEL);
if (!pdata)
return NULL;
--
1.7.10.rc2.10.gb47606
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Input: tegra-kbc: Fix: Allocate pdata before using it
2012-03-27 5:54 [PATCH] Input: tegra-kbc: Fix: Allocate pdata before using it Viresh Kumar
@ 2012-03-27 6:47 ` Dmitry Torokhov
2012-03-27 6:48 ` Viresh Kumar
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Torokhov @ 2012-03-27 6:47 UTC (permalink / raw)
To: Viresh Kumar; +Cc: swarren, olof, linux-input, srasal
On Tue, Mar 27, 2012 at 11:24:49AM +0530, Viresh Kumar wrote:
> Following commit broke DT support for tegra-kbc by removing pdata allocation
> completely.
Must be my fat fingers, sorry about this.
>
> commit 023cea0ecfa2df034096c3f4afa796a0b2d1188a
> Author: Shridhar Rasal <srasal@nvidia.com>
> Date: Fri Feb 3 00:27:30 2012 -0800
>
> Input: tegra-kbc - allow skipping setting up some of GPIO pins
>
> This patch restores it.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
> ---
> drivers/input/keyboard/tegra-kbc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
> index 96ee31e..5827fbe 100644
> --- a/drivers/input/keyboard/tegra-kbc.c
> +++ b/drivers/input/keyboard/tegra-kbc.c
> @@ -630,6 +630,7 @@ tegra_kbc_dt_parse_pdata(struct platform_device *pdev)
> if (!np)
> return NULL;
>
> + pdata = kzalloc(sizeof(*pdata), GFP_KERNEL);
> if (!pdata)
> return NULL;
>
> --
> 1.7.10.rc2.10.gb47606
>
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Input: tegra-kbc: Fix: Allocate pdata before using it
2012-03-27 6:47 ` Dmitry Torokhov
@ 2012-03-27 6:48 ` Viresh Kumar
2012-03-27 6:55 ` Dmitry Torokhov
0 siblings, 1 reply; 4+ messages in thread
From: Viresh Kumar @ 2012-03-27 6:48 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: swarren@nvidia.com, olof@lixom.net, linux-input@vger.kernel.org,
srasal@nvidia.com
On 3/27/2012 12:17 PM, Dmitry Torokhov wrote:
> On Tue, Mar 27, 2012 at 11:24:49AM +0530, Viresh Kumar wrote:
>> > Following commit broke DT support for tegra-kbc by removing pdata allocation
>> > completely.
> Must be my fat fingers, sorry about this.
No, it was Shridhar's. :)
--
viresh
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Input: tegra-kbc: Fix: Allocate pdata before using it
2012-03-27 6:48 ` Viresh Kumar
@ 2012-03-27 6:55 ` Dmitry Torokhov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2012-03-27 6:55 UTC (permalink / raw)
To: Viresh Kumar
Cc: swarren@nvidia.com, olof@lixom.net, linux-input@vger.kernel.org,
srasal@nvidia.com
On Tue, Mar 27, 2012 at 12:18:32PM +0530, Viresh Kumar wrote:
> On 3/27/2012 12:17 PM, Dmitry Torokhov wrote:
> > On Tue, Mar 27, 2012 at 11:24:49AM +0530, Viresh Kumar wrote:
> >> > Following commit broke DT support for tegra-kbc by removing pdata allocation
> >> > completely.
> > Must be my fat fingers, sorry about this.
>
> No, it was Shridhar's. :)
Nope, they were really mine :) I reworked Shridhar's patch and
accidentally deleted memory allocation.
I'll queue your patch ASAP.
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-03-27 6:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-27 5:54 [PATCH] Input: tegra-kbc: Fix: Allocate pdata before using it Viresh Kumar
2012-03-27 6:47 ` Dmitry Torokhov
2012-03-27 6:48 ` Viresh Kumar
2012-03-27 6:55 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox