* [PATCH] drivers: input: mouse: Remove useless casting in cypress_ps2.c
@ 2013-10-16 16:05 Geyslan G. Bem
2013-10-16 18:41 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Geyslan G. Bem @ 2013-10-16 16:05 UTC (permalink / raw)
To: dmitry.torokhov
Cc: dudl, kamal, mario_limonciello, git, linux-input, linux-kernel,
kernel-br, Geyslan G. Bem
Casting (void *) value returned by kzalloc is useless
as mentioned in Documentation/CodingStyle, Chap 14.
Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
---
drivers/input/mouse/cypress_ps2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/mouse/cypress_ps2.c b/drivers/input/mouse/cypress_ps2.c
index f51765f..ef651cc 100644
--- a/drivers/input/mouse/cypress_ps2.c
+++ b/drivers/input/mouse/cypress_ps2.c
@@ -679,7 +679,7 @@ int cypress_init(struct psmouse *psmouse)
{
struct cytp_data *cytp;
- cytp = (struct cytp_data *)kzalloc(sizeof(struct cytp_data), GFP_KERNEL);
+ cytp = kzalloc(sizeof(struct cytp_data), GFP_KERNEL);
psmouse->private = (void *)cytp;
if (cytp == NULL)
return -ENOMEM;
--
1.8.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: input: mouse: Remove useless casting in cypress_ps2.c
2013-10-16 16:05 [PATCH] drivers: input: mouse: Remove useless casting in cypress_ps2.c Geyslan G. Bem
@ 2013-10-16 18:41 ` Dmitry Torokhov
2013-10-16 18:48 ` Geyslan Gregório Bem
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2013-10-16 18:41 UTC (permalink / raw)
To: Geyslan G. Bem
Cc: dudl, kamal, mario_limonciello, git, linux-input, linux-kernel,
kernel-br
Hi Geyslan,
On Wed, Oct 16, 2013 at 01:05:12PM -0300, Geyslan G. Bem wrote:
> Casting (void *) value returned by kzalloc is useless
> as mentioned in Documentation/CodingStyle, Chap 14.
>
> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
> ---
> drivers/input/mouse/cypress_ps2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/cypress_ps2.c b/drivers/input/mouse/cypress_ps2.c
> index f51765f..ef651cc 100644
> --- a/drivers/input/mouse/cypress_ps2.c
> +++ b/drivers/input/mouse/cypress_ps2.c
> @@ -679,7 +679,7 @@ int cypress_init(struct psmouse *psmouse)
> {
> struct cytp_data *cytp;
>
> - cytp = (struct cytp_data *)kzalloc(sizeof(struct cytp_data), GFP_KERNEL);
> + cytp = kzalloc(sizeof(struct cytp_data), GFP_KERNEL);
I already have a patch for this from Jingoo Han in my queue.
> psmouse->private = (void *)cytp;
But this cast is also not needed, so if you could send me a patch for it
I'd appreciate that.
> if (cytp == NULL)
> return -ENOMEM;
> --
> 1.8.4
>
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: input: mouse: Remove useless casting in cypress_ps2.c
2013-10-16 18:41 ` Dmitry Torokhov
@ 2013-10-16 18:48 ` Geyslan Gregório Bem
0 siblings, 0 replies; 3+ messages in thread
From: Geyslan Gregório Bem @ 2013-10-16 18:48 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: dudl, kamal, mario_limonciello, git, linux-input, LKML, kernel-br
2013/10/16 Dmitry Torokhov <dmitry.torokhov@gmail.com>:
> Hi Geyslan,
>
> On Wed, Oct 16, 2013 at 01:05:12PM -0300, Geyslan G. Bem wrote:
>> Casting (void *) value returned by kzalloc is useless
>> as mentioned in Documentation/CodingStyle, Chap 14.
>>
>> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
>> ---
>> drivers/input/mouse/cypress_ps2.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/input/mouse/cypress_ps2.c b/drivers/input/mouse/cypress_ps2.c
>> index f51765f..ef651cc 100644
>> --- a/drivers/input/mouse/cypress_ps2.c
>> +++ b/drivers/input/mouse/cypress_ps2.c
>> @@ -679,7 +679,7 @@ int cypress_init(struct psmouse *psmouse)
>> {
>> struct cytp_data *cytp;
>>
>> - cytp = (struct cytp_data *)kzalloc(sizeof(struct cytp_data), GFP_KERNEL);
>> + cytp = kzalloc(sizeof(struct cytp_data), GFP_KERNEL);
>
> I already have a patch for this from Jingoo Han in my queue.
No problem.
>
>> psmouse->private = (void *)cytp;
>
> But this cast is also not needed, so if you could send me a patch for it
> I'd appreciate that.
Sure, I can.
>
>> if (cytp == NULL)
>> return -ENOMEM;
>> --
>> 1.8.4
>>
>
> Thanks.
>
> --
> Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-16 18:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-16 16:05 [PATCH] drivers: input: mouse: Remove useless casting in cypress_ps2.c Geyslan G. Bem
2013-10-16 18:41 ` Dmitry Torokhov
2013-10-16 18:48 ` Geyslan Gregório Bem
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox