From: Jonathan Corbet <corbet@lwn.net>
To: Daniel Dressler <danieru.dressler@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Tommi Rantala <tt.rantala@gmail.com>,
Ted Mielczarek <ted@mielczarek.org>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Frank Razenberg <frank@zzattack.org>,
Benjamin Valentin <benpicco@zedat.fu-berlin.de>,
Petr Sebor <petr@scssoft.com>,
Thomaz de Oliveira dos Reis <thor27@gmail.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
linux-input@vger.kernel.org
Subject: Re: [PATCH 1/1] Input: xpad - update docs to reflect current state
Date: Fri, 7 Nov 2014 13:48:54 -0500 [thread overview]
Message-ID: <20141107134854.56305dbb@lwn.net> (raw)
In-Reply-To: <1415004836-22871-1-git-send-email-danieru.dressler@gmail.com>
On Mon, 3 Nov 2014 17:53:06 +0900
Daniel Dressler <danieru.dressler@gmail.com> wrote:
> The last time this documentation was accurate was
> just over 8 years ago. In this time we've added
> support for two new generations of Xbox console
> controllers and dozens of third-party controllers.
>
> This patch unifies terminology and makes it explicit
> which model of controller a sentence refers to.
So this seems like a useful update, and I was looking at pulling it into
the docs tree. But this hunk:
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index 2ed7905..7e2e047 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -40,8 +40,8 @@
> *
> * TODO:
> * - fine tune axes (especially trigger axes)
> - * - fix "analog" buttons (reported as digital now)
> - * - get rumble working
> + * - add original xbox rumble pack support
> + * - add xbox one rumble support
> * - need USB IDs for other dance pads
> *
> * History:
Seems like a different change that shouldn't be mixed up with the doc
update. Send me a version without that change and, in the absence
of complaints, I'll apply it.
Thanks,
jon
next prev parent reply other threads:[~2014-11-07 18:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 8:53 [PATCH 1/1] Input: xpad - update docs to reflect current state Daniel Dressler
2014-11-07 18:48 ` Jonathan Corbet [this message]
2014-11-10 8:06 ` Daniel Dressler
2014-11-10 11:47 ` Thomaz de Oliveira dos Reis
2014-11-10 12:15 ` Daniel Dressler
2014-11-10 12:27 ` Thomaz de Oliveira dos Reis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141107134854.56305dbb@lwn.net \
--to=corbet@lwn.net \
--cc=benpicco@zedat.fu-berlin.de \
--cc=danieru.dressler@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=frank@zzattack.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=petr@scssoft.com \
--cc=ted@mielczarek.org \
--cc=thor27@gmail.com \
--cc=tt.rantala@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox