From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Qipeng Zha <qipeng.zha@intel.com>,
Linux Input <linux-input@vger.kernel.org>,
Qi Zheng <qi.zheng@intel.com>, Aubrey Li <aubrey.li@intel.com>
Subject: Re: [PATCH] input:gpio-key: set IRQF_NO_SUSPEND for wake capable key
Date: Fri, 2 Oct 2015 10:41:46 -0700 [thread overview]
Message-ID: <20151002174146.GB8437@dtor-ws> (raw)
In-Reply-To: <CACRpkdYJEG1n4phfC=St0nic1_Z+qdoGKzhyS5yhDM9O9ci25w@mail.gmail.com>
On Fri, Oct 02, 2015 at 03:26:27AM -0700, Linus Walleij wrote:
> On Thu, Sep 17, 2015 at 9:06 AM, Qipeng Zha <qipeng.zha@intel.com> wrote:
>
> > When wakeup attribute is set, GPIO key is supposed to wake up
> > the system from system sleep state, So set IRQF_NO_SUSPEND
> > flag to keep IRQ enabled during suspend.
> >
> > Signed-off-by: Qi Zheng <qi.zheng@intel.com>
> > Signed-off-by: Aubrey Li <aubrey.li@intel.com>
> > Signed-off-by: Qipeng Zha <qipeng.zha@intel.com>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Should this not be tagged for stable?
I do not believe we need this at all. Otherwise every single driver for
devices that might be wakeup sources needs this flag set. Which would
basically means it is a noop and we should not suspend IRQ threads by
default.
The dirver correctly calls enable_irq_wake() and platform should do
whatever it needs to make sure wakeup interrupt will be serviced.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2015-10-02 17:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 16:06 [PATCH] input:gpio-key: set IRQF_NO_SUSPEND for wake capable key Qipeng Zha
2015-10-02 10:26 ` Linus Walleij
2015-10-02 17:41 ` Dmitry Torokhov [this message]
2015-10-09 2:14 ` Zheng, Qi
2015-10-09 2:47 ` Li, Aubrey
2015-10-09 5:36 ` Zheng, Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151002174146.GB8437@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=aubrey.li@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=qi.zheng@intel.com \
--cc=qipeng.zha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox