From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Masaki Ota <masaki.ota@jp.alps.com>
Cc: Masaki Ota <012nexus@gmail.com>,
"jikos@kernel.org" <jikos@kernel.org>,
"benjamin.tissorires@redhat.com" <benjamin.tissorires@redhat.com>,
"peter.hutterer@who-t.net" <peter.hutterer@who-t.net>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
Naoki Saito <naoki.saito@jp.alps.com>
Subject: Re: [PATCH] Alps I2C HID Touchpad-Stick support
Date: Mon, 20 Jun 2016 23:36:55 -0700 [thread overview]
Message-ID: <20160621063655.GA26764@dtor-ws> (raw)
In-Reply-To: <OSXPR01MB0408A3C101E1D36D1F4FEC76C72B0@OSXPR01MB0408.jpnprd01.prod.outlook.com>
Hi Masaki,
On Tue, Jun 21, 2016 at 04:43:05AM +0000, Masaki Ota wrote:
> Hi, Dmitry,
>
> > +struct u1_dev *priv;
> I do not understand why you need this global. You can allocate arbitrary memory in probe() and you actually already do that, why do you need second copy?
>
> Yes, actually I don't want to use global, but I want to use it in alps_raw_event() for StickPointer.
> Do you have any idea?
What is wrong with using input2 pointer in hdata (provided you set it up
properly when probing the device)?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2016-06-21 6:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 9:45 [PATCH] Alps I2C HID Touchpad-Stick support Masaki Ota
2016-06-17 21:24 ` Jiri Kosina
2016-06-17 21:54 ` Jiri Kosina
2016-06-21 3:39 ` Dmitry Torokhov
2016-06-21 4:43 ` Masaki Ota
2016-06-21 6:36 ` Dmitry Torokhov [this message]
2016-06-21 5:29 ` Masaki Ota
2016-06-21 7:35 ` Jiri Kosina
-- strict thread matches above, loose matches on Subject: below --
2016-06-16 8:26 Masaki Ota
2016-06-16 9:14 ` Jiri Kosina
2016-06-16 1:43 Masaki Ota
2016-06-16 1:51 ` Masaki Ota
2016-06-16 8:00 ` Jiri Kosina
2016-05-26 4:40 Masaki Ota
2016-05-26 11:12 ` Jiri Kosina
2016-05-26 18:54 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160621063655.GA26764@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=012nexus@gmail.com \
--cc=benjamin.tissorires@redhat.com \
--cc=hdegoede@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=masaki.ota@jp.alps.com \
--cc=naoki.saito@jp.alps.com \
--cc=peter.hutterer@who-t.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox