From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jingkui Wang <jkwang@google.com>
Cc: linux-input@vger.kernel.org, Dan Murphy <dmurphy@ti.com>
Subject: Re: [PATCH] Input: Driver drv260x.c - fix bug of adding wrong device parent
Date: Mon, 12 Dec 2016 14:05:00 -0800 [thread overview]
Message-ID: <20161212220500.GA27357@dtor-ws> (raw)
In-Reply-To: <1481578627-56391-1-git-send-email-jkwang@google.com>
On Mon, Dec 12, 2016 at 01:37:07PM -0800, Jingkui Wang wrote:
> Fix the bug of adding wrong parent to the input_dev created by the
> driver. The bug will be triggered if rmmod is called for this driver
> module.
>
> Signed-off-by: Jingkui Wang <jkwang@google.com>
Applied and marked for stable, thank you.
> ---
> drivers/input/misc/drv260x.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/misc/drv260x.c b/drivers/input/misc/drv260x.c
> index 4f448ba..885c140 100644
> --- a/drivers/input/misc/drv260x.c
> +++ b/drivers/input/misc/drv260x.c
> @@ -565,7 +565,6 @@ static int drv260x_probe(struct i2c_client *client,
> }
>
> haptics->input_dev->name = "drv260x:haptics";
> - haptics->input_dev->dev.parent = client->dev.parent;
> haptics->input_dev->close = drv260x_close;
> input_set_drvdata(haptics->input_dev, haptics);
> input_set_capability(haptics->input_dev, EV_FF, FF_RUMBLE);
> --
> 2.6.6
>
--
Dmitry
prev parent reply other threads:[~2016-12-12 22:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 21:37 [PATCH] Input: Driver drv260x.c - fix bug of adding wrong device parent Jingkui Wang
2016-12-12 22:05 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161212220500.GA27357@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=dmurphy@ti.com \
--cc=jkwang@google.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox