* [PATCH] Input: Driver drv260x.c - fix bug of adding wrong device parent
@ 2016-12-12 21:37 Jingkui Wang
2016-12-12 22:05 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Jingkui Wang @ 2016-12-12 21:37 UTC (permalink / raw)
To: linux-input; +Cc: dmitry.torokhov, Dan Murphy, Jingkui Wang
Fix the bug of adding wrong parent to the input_dev created by the
driver. The bug will be triggered if rmmod is called for this driver
module.
Signed-off-by: Jingkui Wang <jkwang@google.com>
---
drivers/input/misc/drv260x.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/misc/drv260x.c b/drivers/input/misc/drv260x.c
index 4f448ba..885c140 100644
--- a/drivers/input/misc/drv260x.c
+++ b/drivers/input/misc/drv260x.c
@@ -565,7 +565,6 @@ static int drv260x_probe(struct i2c_client *client,
}
haptics->input_dev->name = "drv260x:haptics";
- haptics->input_dev->dev.parent = client->dev.parent;
haptics->input_dev->close = drv260x_close;
input_set_drvdata(haptics->input_dev, haptics);
input_set_capability(haptics->input_dev, EV_FF, FF_RUMBLE);
--
2.6.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: Driver drv260x.c - fix bug of adding wrong device parent
2016-12-12 21:37 [PATCH] Input: Driver drv260x.c - fix bug of adding wrong device parent Jingkui Wang
@ 2016-12-12 22:05 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2016-12-12 22:05 UTC (permalink / raw)
To: Jingkui Wang; +Cc: linux-input, Dan Murphy
On Mon, Dec 12, 2016 at 01:37:07PM -0800, Jingkui Wang wrote:
> Fix the bug of adding wrong parent to the input_dev created by the
> driver. The bug will be triggered if rmmod is called for this driver
> module.
>
> Signed-off-by: Jingkui Wang <jkwang@google.com>
Applied and marked for stable, thank you.
> ---
> drivers/input/misc/drv260x.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/misc/drv260x.c b/drivers/input/misc/drv260x.c
> index 4f448ba..885c140 100644
> --- a/drivers/input/misc/drv260x.c
> +++ b/drivers/input/misc/drv260x.c
> @@ -565,7 +565,6 @@ static int drv260x_probe(struct i2c_client *client,
> }
>
> haptics->input_dev->name = "drv260x:haptics";
> - haptics->input_dev->dev.parent = client->dev.parent;
> haptics->input_dev->close = drv260x_close;
> input_set_drvdata(haptics->input_dev, haptics);
> input_set_capability(haptics->input_dev, EV_FF, FF_RUMBLE);
> --
> 2.6.6
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-12 22:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-12 21:37 [PATCH] Input: Driver drv260x.c - fix bug of adding wrong device parent Jingkui Wang
2016-12-12 22:05 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox