From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Michael Nazzareno Trimarchi <michael@amarulasolutions.com>
Cc: Vignesh R <vigneshr@ti.com>,
linux-input@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] input: touchscreen: ti_am335x_tsc: Fix incorrect step config for 5 wire touchscreen
Date: Wed, 18 Oct 2017 17:27:05 -0700 [thread overview]
Message-ID: <20171019002705.wrfz2ffioxjp2xu5@dtor-ws> (raw)
In-Reply-To: <CAOf5uwmrx_AepsovxBmA5ko76tODLSc3ZLmSOj2d8jxEo-f0cg@mail.gmail.com>
On Wed, Oct 18, 2017 at 07:18:11AM +0200, Michael Nazzareno Trimarchi wrote:
> Hi
>
> On Tue, Sep 19, 2017 at 8:29 AM, Vignesh R <vigneshr@ti.com> wrote:
> > From: Jeff Lance <j-lance1@ti.com>
> >
> > Step config setting for 5 wire touchscreen is incorrect for Y coordinates.
> > It was broken while we moved to DT. If you look close at the offending
> > commit bb76dc09ddfc ("input: ti_am33x_tsc: Order of TSC wires, made
> > configurable"), the change was:
> >
> > - STEPCONFIG_XNP | STEPCONFIG_YPN;
> > + ts_dev->bit_xn | ts_dev->bit_yp;
> >
> > while bit_xn = STEPCONFIG_XNN and bit_yp = STEPCONFIG_YNN. Not quite the
> > same.
> >
> > Fixes: bb76dc09ddfc ("input: ti_am33x_tsc: Order of TSC wires, made configurable")
> > Signed-off-by: Jeff Lance <j-lance1@ti.com>
> > [vigneshr@ti.com: Rebase to v4.14-rc1]
> > Signed-off-by: Vignesh R <vigneshr@ti.com>
> > ---
> >
> > Tested on AM335x EVM with 5 wire tsc module. Also sanity tested
> > on a 4 wire tsc as well.
> >
> > drivers/input/touchscreen/ti_am335x_tsc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c
> > index 7953381d939a..f1043ae71dcc 100644
> > --- a/drivers/input/touchscreen/ti_am335x_tsc.c
> > +++ b/drivers/input/touchscreen/ti_am335x_tsc.c
> > @@ -161,7 +161,7 @@ static void titsc_step_config(struct titsc *ts_dev)
> > break;
> > case 5:
> > config |= ts_dev->bit_xp | STEPCONFIG_INP_AN4 |
> > - ts_dev->bit_xn | ts_dev->bit_yp;
> > + STEPCONFIG_XNP | STEPCONFIG_YPN;
> > break;
> > case 8:
> > config |= ts_dev->bit_yp | STEPCONFIG_INP(ts_dev->inp_xp);
> > --
>
> Looks sane to me.
Applied, thank you.
>
> Michael
>
> > 2.14.1
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Dmitry
prev parent reply other threads:[~2017-10-19 0:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 6:29 [PATCH] input: touchscreen: ti_am335x_tsc: Fix incorrect step config for 5 wire touchscreen Vignesh R
2017-10-18 3:58 ` Vignesh R
2017-10-18 5:18 ` Michael Nazzareno Trimarchi
2017-10-19 0:27 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019002705.wrfz2ffioxjp2xu5@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=michael@amarulasolutions.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox