* [PATCH][next] HID: quirks: make array hid_quirks static
@ 2017-12-04 11:19 Colin King
2017-12-04 12:26 ` Benjamin Tissoires
2017-12-07 10:01 ` Jiri Kosina
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2017-12-04 11:19 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires, linux-input
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Array hid_quirks is local to the source and does not need to be in
global scope, so make it static.
Cleans up sparse warning:
drivers/hid/hid-quirks.c:29:28: warning: symbol 'hid_quirks' was not
declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/hid/hid-quirks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c
index 1cf1e9a0d699..627efb74d1e4 100644
--- a/drivers/hid/hid-quirks.c
+++ b/drivers/hid/hid-quirks.c
@@ -26,7 +26,7 @@
* Alphabetically sorted by vendor then product.
*/
-const struct hid_device_id hid_quirks[] = {
+static const struct hid_device_id hid_quirks[] = {
{ HID_USB_DEVICE(USB_VENDOR_ID_AASHIMA, USB_DEVICE_ID_AASHIMA_GAMEPAD), HID_QUIRK_BADPAD },
{ HID_USB_DEVICE(USB_VENDOR_ID_AASHIMA, USB_DEVICE_ID_AASHIMA_PREDATOR), HID_QUIRK_BADPAD },
{ HID_USB_DEVICE(USB_VENDOR_ID_AFATECH, USB_DEVICE_ID_AFATECH_AF9016), HID_QUIRK_FULLSPEED_INTERVAL },
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH][next] HID: quirks: make array hid_quirks static
2017-12-04 11:19 [PATCH][next] HID: quirks: make array hid_quirks static Colin King
@ 2017-12-04 12:26 ` Benjamin Tissoires
2017-12-07 10:01 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Benjamin Tissoires @ 2017-12-04 12:26 UTC (permalink / raw)
To: Colin King; +Cc: Jiri Kosina, linux-input, kernel-janitors, linux-kernel
On Mon, Dec 4, 2017 at 12:19 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Array hid_quirks is local to the source and does not need to be in
> global scope, so make it static.
>
> Cleans up sparse warning:
> drivers/hid/hid-quirks.c:29:28: warning: symbol 'hid_quirks' was not
> declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
Sounds good.
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
> drivers/hid/hid-quirks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c
> index 1cf1e9a0d699..627efb74d1e4 100644
> --- a/drivers/hid/hid-quirks.c
> +++ b/drivers/hid/hid-quirks.c
> @@ -26,7 +26,7 @@
> * Alphabetically sorted by vendor then product.
> */
>
> -const struct hid_device_id hid_quirks[] = {
> +static const struct hid_device_id hid_quirks[] = {
> { HID_USB_DEVICE(USB_VENDOR_ID_AASHIMA, USB_DEVICE_ID_AASHIMA_GAMEPAD), HID_QUIRK_BADPAD },
> { HID_USB_DEVICE(USB_VENDOR_ID_AASHIMA, USB_DEVICE_ID_AASHIMA_PREDATOR), HID_QUIRK_BADPAD },
> { HID_USB_DEVICE(USB_VENDOR_ID_AFATECH, USB_DEVICE_ID_AFATECH_AF9016), HID_QUIRK_FULLSPEED_INTERVAL },
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][next] HID: quirks: make array hid_quirks static
2017-12-04 11:19 [PATCH][next] HID: quirks: make array hid_quirks static Colin King
2017-12-04 12:26 ` Benjamin Tissoires
@ 2017-12-07 10:01 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2017-12-07 10:01 UTC (permalink / raw)
To: Colin King; +Cc: Benjamin Tissoires, linux-input, kernel-janitors, linux-kernel
On Mon, 4 Dec 2017, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Array hid_quirks is local to the source and does not need to be in
> global scope, so make it static.
>
> Cleans up sparse warning:
> drivers/hid/hid-quirks.c:29:28: warning: symbol 'hid_quirks' was not
> declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to for-4.16/hid-quirks-cleanup/_base. Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-07 10:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-04 11:19 [PATCH][next] HID: quirks: make array hid_quirks static Colin King
2017-12-04 12:26 ` Benjamin Tissoires
2017-12-07 10:01 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox