From: Andi Shyti <andi.shyti-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
To: Simon Shields <simon-WP75azK+jQYgsBAKwltoeQ@public.gmane.org>
Cc: Dmitry Torokhov
<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] touchscreen: mms114: add support for mms152
Date: Tue, 19 Dec 2017 18:10:09 +0900 [thread overview]
Message-ID: <20171219091009.GD25647@gangnam.samsung> (raw)
In-Reply-To: <20171219080409.GA27703-WP75azK+jQYgsBAKwltoeQ@public.gmane.org>
Hi Simon,
> > > #ifdef CONFIG_OF
> > > static const struct of_device_id mms114_dt_match[] = {
> > > - { .compatible = "melfas,mms114" },
> > > + {
> > > + .compatible = "melfas,mms114",
> > > + .data = (void *)TYPE_MMS114,
> > > + }, {
> > > + .compatible = "melfas,mms152",
> > > + .data = (void *)TYPE_MMS152,
> >
> > You are not documenting the new "melfas,mms152" compatible in
> > Documentation/devicetree/bindings/input/touchscreen/mms114.txt
>
> Yes I am - "melfas,mms152" is added to the documentation
> as part of this patch. Is there something wrong with what I've done
> there?
Oh yes, sorry! I missed it while snipping the code :)
Please ignore this comment, then.
Andi
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-12-19 9:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171218124955epcas3p3d776375b0dadbc3e0291da6ffb0eb6b6@epcas3p3.samsung.com>
2017-12-18 12:49 ` [PATCH] touchscreen: mms114: add support for mms152 Simon Shields
2017-12-19 6:22 ` Andi Shyti
[not found] ` <20171219062252.GC25647-8vUhnHFVuGn35fTxX1Dczw@public.gmane.org>
2017-12-19 8:04 ` Simon Shields
[not found] ` <20171219080409.GA27703-WP75azK+jQYgsBAKwltoeQ@public.gmane.org>
2017-12-19 9:10 ` Andi Shyti [this message]
2017-12-20 15:38 ` [PATCH v2] Input: mms114 - " Simon Shields
2017-12-20 18:34 ` Dmitry Torokhov
[not found] ` <20171218124933.1803-1-simon-WP75azK+jQYgsBAKwltoeQ@public.gmane.org>
2017-12-20 18:21 ` [PATCH] touchscreen: mms114: " Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219091009.GD25647@gangnam.samsung \
--to=andi.shyti-sze3o3uu22jbdgjk7y7tuq@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=simon-WP75azK+jQYgsBAKwltoeQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox