From: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"benjamin.tissoires@redhat.com" <benjamin.tissoires@redhat.com>,
"jikos@kernel.org" <jikos@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Filipe Laíns" <lains@archlinux.org>,
"mnrzk@protonmail.com" <mnrzk@protonmail.com>
Subject: Re: [PATCH v5 2/2] HID: logitech: Support WirelessDeviceStatus connect events
Date: Mon, 14 Oct 2019 11:46:57 +0800 [thread overview]
Message-ID: <201910141117.twKn4wE1%lkp@intel.com> (raw)
In-Reply-To: <23olKBO7VYh8VS2ZXNY_4uBAy5jnxyXdBqzXiBZdvPxVp845bPLo6Xe_vwYMuSlozOUg2LYs5ANpE4wy6UBtF9p5YnoLz1Udq6HxW89R3tE=@protonmail.com>
[-- Attachment #1: Type: text/plain, Size: 8070 bytes --]
Hi Mazin,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[cannot apply to v5.4-rc2 next-20191010]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Mazin-Rezk/HID-logitech-Add-MX-Master-over-Bluetooth/20191014-071534
config: mips-allmodconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/ioport.h:15:0,
from include/linux/device.h:15,
from drivers/hid/hid-logitech-hidpp.c:13:
drivers/hid/hid-logitech-hidpp.c: In function 'hidpp_send_rap_command_sync':
include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow]
#define BIT(nr) (UL(1) << (nr))
^
drivers/hid/hid-logitech-hidpp.c:74:43: note: in expansion of macro 'BIT'
#define HIDPP_QUIRK_MISSING_SHORT_REPORTS BIT(32)
^~~
drivers/hid/hid-logitech-hidpp.c:351:26: note: in expansion of macro 'HIDPP_QUIRK_MISSING_SHORT_REPORTS'
if (hidpp_dev->quirks & HIDPP_QUIRK_MISSING_SHORT_REPORTS &&
^
drivers/hid/hid-logitech-hidpp.c: In function 'hidpp_report_is_connect_event':
include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow]
#define BIT(nr) (UL(1) << (nr))
^
drivers/hid/hid-logitech-hidpp.c:75:44: note: in expansion of macro 'BIT'
#define HIDPP_QUIRK_WIRELESS_DEVICE_STATUS BIT(33)
^~~
>> drivers/hid/hid-logitech-hidpp.c:412:27: note: in expansion of macro 'HIDPP_QUIRK_WIRELESS_DEVICE_STATUS'
return ((hidpp->quirks & HIDPP_QUIRK_WIRELESS_DEVICE_STATUS) &&
^
include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow]
#define BIT(nr) (UL(1) << (nr))
^
drivers/hid/hid-logitech-hidpp.c:74:43: note: in expansion of macro 'BIT'
#define HIDPP_QUIRK_MISSING_SHORT_REPORTS BIT(32)
^~~
drivers/hid/hid-logitech-hidpp.c:415:20: note: in expansion of macro 'HIDPP_QUIRK_MISSING_SHORT_REPORTS'
(hidpp->quirks & HIDPP_QUIRK_MISSING_SHORT_REPORTS)) &&
^
drivers/hid/hid-logitech-hidpp.c: In function 'hidpp_validate_device':
include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow]
#define BIT(nr) (UL(1) << (nr))
^
drivers/hid/hid-logitech-hidpp.c:74:43: note: in expansion of macro 'BIT'
#define HIDPP_QUIRK_MISSING_SHORT_REPORTS BIT(32)
^~~
drivers/hid/hid-logitech-hidpp.c:3522:22: note: in expansion of macro 'HIDPP_QUIRK_MISSING_SHORT_REPORTS'
if (hidpp->quirks & HIDPP_QUIRK_MISSING_SHORT_REPORTS)
^
drivers/hid/hid-logitech-hidpp.c: In function 'hidpp_probe':
include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow]
#define BIT(nr) (UL(1) << (nr))
^
drivers/hid/hid-logitech-hidpp.c:75:44: note: in expansion of macro 'BIT'
#define HIDPP_QUIRK_WIRELESS_DEVICE_STATUS BIT(33)
^~~
drivers/hid/hid-logitech-hidpp.c:3653:36: note: in expansion of macro 'HIDPP_QUIRK_WIRELESS_DEVICE_STATUS'
if (connected && (hidpp->quirks & HIDPP_QUIRK_WIRELESS_DEVICE_STATUS)) {
^
drivers/hid/hid-logitech-hidpp.c: At top level:
include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow]
#define BIT(nr) (UL(1) << (nr))
^
drivers/hid/hid-logitech-hidpp.c:74:43: note: in expansion of macro 'BIT'
#define HIDPP_QUIRK_MISSING_SHORT_REPORTS BIT(32)
^~~
drivers/hid/hid-logitech-hidpp.c:86:41: note: in expansion of macro 'HIDPP_QUIRK_MISSING_SHORT_REPORTS'
#define HIDPP_QUIRK_CLASS_BLUETOOTH_LE (HIDPP_QUIRK_MISSING_SHORT_REPORTS | \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-logitech-hidpp.c:3826:5: note: in expansion of macro 'HIDPP_QUIRK_CLASS_BLUETOOTH_LE'
HIDPP_QUIRK_CLASS_BLUETOOTH_LE },
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow]
#define BIT(nr) (UL(1) << (nr))
^
drivers/hid/hid-logitech-hidpp.c:75:44: note: in expansion of macro 'BIT'
#define HIDPP_QUIRK_WIRELESS_DEVICE_STATUS BIT(33)
^~~
drivers/hid/hid-logitech-hidpp.c:87:7: note: in expansion of macro 'HIDPP_QUIRK_WIRELESS_DEVICE_STATUS'
HIDPP_QUIRK_WIRELESS_DEVICE_STATUS)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-logitech-hidpp.c:3826:5: note: in expansion of macro 'HIDPP_QUIRK_CLASS_BLUETOOTH_LE'
HIDPP_QUIRK_CLASS_BLUETOOTH_LE },
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow]
#define BIT(nr) (UL(1) << (nr))
^
drivers/hid/hid-logitech-hidpp.c:74:43: note: in expansion of macro 'BIT'
#define HIDPP_QUIRK_MISSING_SHORT_REPORTS BIT(32)
^~~
drivers/hid/hid-logitech-hidpp.c:86:41: note: in expansion of macro 'HIDPP_QUIRK_MISSING_SHORT_REPORTS'
#define HIDPP_QUIRK_CLASS_BLUETOOTH_LE (HIDPP_QUIRK_MISSING_SHORT_REPORTS | \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-logitech-hidpp.c:3829:5: note: in expansion of macro 'HIDPP_QUIRK_CLASS_BLUETOOTH_LE'
HIDPP_QUIRK_CLASS_BLUETOOTH_LE },
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow]
#define BIT(nr) (UL(1) << (nr))
^
drivers/hid/hid-logitech-hidpp.c:75:44: note: in expansion of macro 'BIT'
#define HIDPP_QUIRK_WIRELESS_DEVICE_STATUS BIT(33)
^~~
drivers/hid/hid-logitech-hidpp.c:87:7: note: in expansion of macro 'HIDPP_QUIRK_WIRELESS_DEVICE_STATUS'
HIDPP_QUIRK_WIRELESS_DEVICE_STATUS)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-logitech-hidpp.c:3829:5: note: in expansion of macro 'HIDPP_QUIRK_CLASS_BLUETOOTH_LE'
HIDPP_QUIRK_CLASS_BLUETOOTH_LE },
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/HIDPP_QUIRK_WIRELESS_DEVICE_STATUS +412 drivers/hid/hid-logitech-hidpp.c
408
409 static inline bool hidpp_report_is_connect_event(struct hidpp_device *hidpp,
410 struct hidpp_report *report)
411 {
> 412 return ((hidpp->quirks & HIDPP_QUIRK_WIRELESS_DEVICE_STATUS) &&
413 (report->fap.feature_index == hidpp->wireless_feature_index)) ||
414 (((report->report_id == REPORT_ID_HIDPP_SHORT) ||
415 (hidpp->quirks & HIDPP_QUIRK_MISSING_SHORT_REPORTS)) &&
416 (report->rap.sub_id == 0x41));
417 }
418
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 62065 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: Mazin Rezk <mnrzk@protonmail.com>
Cc: kbuild-all@lists.01.org,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"benjamin.tissoires@redhat.com" <benjamin.tissoires@redhat.com>,
"jikos@kernel.org" <jikos@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Filipe Laíns" <lains@archlinux.org>,
"mnrzk@protonmail.com" <mnrzk@protonmail.com>
Subject: Re: [PATCH v5 2/2] HID: logitech: Support WirelessDeviceStatus connect events
Date: Mon, 14 Oct 2019 11:46:57 +0800 [thread overview]
Message-ID: <201910141117.twKn4wE1%lkp@intel.com> (raw)
Message-ID: <20191014034657.El31B8wLcXTBXlZRxIywtpG8uJDcN-WIgIo-qk_qGRc@z> (raw)
In-Reply-To: <23olKBO7VYh8VS2ZXNY_4uBAy5jnxyXdBqzXiBZdvPxVp845bPLo6Xe_vwYMuSlozOUg2LYs5ANpE4wy6UBtF9p5YnoLz1Udq6HxW89R3tE=@protonmail.com>
[-- Attachment #1: Type: text/plain, Size: 8070 bytes --]
Hi Mazin,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[cannot apply to v5.4-rc2 next-20191010]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Mazin-Rezk/HID-logitech-Add-MX-Master-over-Bluetooth/20191014-071534
config: mips-allmodconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/ioport.h:15:0,
from include/linux/device.h:15,
from drivers/hid/hid-logitech-hidpp.c:13:
drivers/hid/hid-logitech-hidpp.c: In function 'hidpp_send_rap_command_sync':
include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow]
#define BIT(nr) (UL(1) << (nr))
^
drivers/hid/hid-logitech-hidpp.c:74:43: note: in expansion of macro 'BIT'
#define HIDPP_QUIRK_MISSING_SHORT_REPORTS BIT(32)
^~~
drivers/hid/hid-logitech-hidpp.c:351:26: note: in expansion of macro 'HIDPP_QUIRK_MISSING_SHORT_REPORTS'
if (hidpp_dev->quirks & HIDPP_QUIRK_MISSING_SHORT_REPORTS &&
^
drivers/hid/hid-logitech-hidpp.c: In function 'hidpp_report_is_connect_event':
include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow]
#define BIT(nr) (UL(1) << (nr))
^
drivers/hid/hid-logitech-hidpp.c:75:44: note: in expansion of macro 'BIT'
#define HIDPP_QUIRK_WIRELESS_DEVICE_STATUS BIT(33)
^~~
>> drivers/hid/hid-logitech-hidpp.c:412:27: note: in expansion of macro 'HIDPP_QUIRK_WIRELESS_DEVICE_STATUS'
return ((hidpp->quirks & HIDPP_QUIRK_WIRELESS_DEVICE_STATUS) &&
^
include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow]
#define BIT(nr) (UL(1) << (nr))
^
drivers/hid/hid-logitech-hidpp.c:74:43: note: in expansion of macro 'BIT'
#define HIDPP_QUIRK_MISSING_SHORT_REPORTS BIT(32)
^~~
drivers/hid/hid-logitech-hidpp.c:415:20: note: in expansion of macro 'HIDPP_QUIRK_MISSING_SHORT_REPORTS'
(hidpp->quirks & HIDPP_QUIRK_MISSING_SHORT_REPORTS)) &&
^
drivers/hid/hid-logitech-hidpp.c: In function 'hidpp_validate_device':
include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow]
#define BIT(nr) (UL(1) << (nr))
^
drivers/hid/hid-logitech-hidpp.c:74:43: note: in expansion of macro 'BIT'
#define HIDPP_QUIRK_MISSING_SHORT_REPORTS BIT(32)
^~~
drivers/hid/hid-logitech-hidpp.c:3522:22: note: in expansion of macro 'HIDPP_QUIRK_MISSING_SHORT_REPORTS'
if (hidpp->quirks & HIDPP_QUIRK_MISSING_SHORT_REPORTS)
^
drivers/hid/hid-logitech-hidpp.c: In function 'hidpp_probe':
include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow]
#define BIT(nr) (UL(1) << (nr))
^
drivers/hid/hid-logitech-hidpp.c:75:44: note: in expansion of macro 'BIT'
#define HIDPP_QUIRK_WIRELESS_DEVICE_STATUS BIT(33)
^~~
drivers/hid/hid-logitech-hidpp.c:3653:36: note: in expansion of macro 'HIDPP_QUIRK_WIRELESS_DEVICE_STATUS'
if (connected && (hidpp->quirks & HIDPP_QUIRK_WIRELESS_DEVICE_STATUS)) {
^
drivers/hid/hid-logitech-hidpp.c: At top level:
include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow]
#define BIT(nr) (UL(1) << (nr))
^
drivers/hid/hid-logitech-hidpp.c:74:43: note: in expansion of macro 'BIT'
#define HIDPP_QUIRK_MISSING_SHORT_REPORTS BIT(32)
^~~
drivers/hid/hid-logitech-hidpp.c:86:41: note: in expansion of macro 'HIDPP_QUIRK_MISSING_SHORT_REPORTS'
#define HIDPP_QUIRK_CLASS_BLUETOOTH_LE (HIDPP_QUIRK_MISSING_SHORT_REPORTS | \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-logitech-hidpp.c:3826:5: note: in expansion of macro 'HIDPP_QUIRK_CLASS_BLUETOOTH_LE'
HIDPP_QUIRK_CLASS_BLUETOOTH_LE },
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow]
#define BIT(nr) (UL(1) << (nr))
^
drivers/hid/hid-logitech-hidpp.c:75:44: note: in expansion of macro 'BIT'
#define HIDPP_QUIRK_WIRELESS_DEVICE_STATUS BIT(33)
^~~
drivers/hid/hid-logitech-hidpp.c:87:7: note: in expansion of macro 'HIDPP_QUIRK_WIRELESS_DEVICE_STATUS'
HIDPP_QUIRK_WIRELESS_DEVICE_STATUS)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-logitech-hidpp.c:3826:5: note: in expansion of macro 'HIDPP_QUIRK_CLASS_BLUETOOTH_LE'
HIDPP_QUIRK_CLASS_BLUETOOTH_LE },
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow]
#define BIT(nr) (UL(1) << (nr))
^
drivers/hid/hid-logitech-hidpp.c:74:43: note: in expansion of macro 'BIT'
#define HIDPP_QUIRK_MISSING_SHORT_REPORTS BIT(32)
^~~
drivers/hid/hid-logitech-hidpp.c:86:41: note: in expansion of macro 'HIDPP_QUIRK_MISSING_SHORT_REPORTS'
#define HIDPP_QUIRK_CLASS_BLUETOOTH_LE (HIDPP_QUIRK_MISSING_SHORT_REPORTS | \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-logitech-hidpp.c:3829:5: note: in expansion of macro 'HIDPP_QUIRK_CLASS_BLUETOOTH_LE'
HIDPP_QUIRK_CLASS_BLUETOOTH_LE },
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow]
#define BIT(nr) (UL(1) << (nr))
^
drivers/hid/hid-logitech-hidpp.c:75:44: note: in expansion of macro 'BIT'
#define HIDPP_QUIRK_WIRELESS_DEVICE_STATUS BIT(33)
^~~
drivers/hid/hid-logitech-hidpp.c:87:7: note: in expansion of macro 'HIDPP_QUIRK_WIRELESS_DEVICE_STATUS'
HIDPP_QUIRK_WIRELESS_DEVICE_STATUS)
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-logitech-hidpp.c:3829:5: note: in expansion of macro 'HIDPP_QUIRK_CLASS_BLUETOOTH_LE'
HIDPP_QUIRK_CLASS_BLUETOOTH_LE },
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/HIDPP_QUIRK_WIRELESS_DEVICE_STATUS +412 drivers/hid/hid-logitech-hidpp.c
408
409 static inline bool hidpp_report_is_connect_event(struct hidpp_device *hidpp,
410 struct hidpp_report *report)
411 {
> 412 return ((hidpp->quirks & HIDPP_QUIRK_WIRELESS_DEVICE_STATUS) &&
413 (report->fap.feature_index == hidpp->wireless_feature_index)) ||
414 (((report->report_id == REPORT_ID_HIDPP_SHORT) ||
415 (hidpp->quirks & HIDPP_QUIRK_MISSING_SHORT_REPORTS)) &&
416 (report->rap.sub_id == 0x41));
417 }
418
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 62065 bytes --]
next prev parent reply other threads:[~2019-10-14 3:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 17:47 [PATCH v5 2/2] HID: logitech: Support WirelessDeviceStatus connect events Mazin Rezk
2019-10-11 17:47 ` Mazin Rezk
2019-10-14 3:46 ` kbuild test robot [this message]
2019-10-14 3:46 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201910141117.twKn4wE1%lkp@intel.com \
--to=lkp@intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=lains@archlinux.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mnrzk@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox