Linux Input/HID development
 help / color / mirror / Atom feed
* [PATCH] HID: google: add moonball USB id
@ 2020-03-16  7:24 Chen-Tsung Hsieh
  2020-03-16  7:50 ` Nicolas Boichat
  2020-03-16 13:53 ` Jiri Kosina
  0 siblings, 2 replies; 3+ messages in thread
From: Chen-Tsung Hsieh @ 2020-03-16  7:24 UTC (permalink / raw)
  To: jikos; +Cc: benjamin.tissoires, linux-input, linux-kernel, drinkcat

Add 1 additional hammer-like device.

Signed-off-by: Chen-Tsung Hsieh <chentsung@chromium.org>
---
 drivers/hid/hid-google-hammer.c | 2 ++
 drivers/hid/hid-ids.h           | 1 +
 2 files changed, 3 insertions(+)

diff --git a/drivers/hid/hid-google-hammer.c b/drivers/hid/hid-google-hammer.c
index 2aa4ed157aec..85a054f1ce38 100644
--- a/drivers/hid/hid-google-hammer.c
+++ b/drivers/hid/hid-google-hammer.c
@@ -532,6 +532,8 @@ static const struct hid_device_id hammer_devices[] = {
 		     USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_MAGNEMITE) },
 	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
 		     USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_MASTERBALL) },
+	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
+		     USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_MOONBALL) },
 	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
 		     USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_STAFF) },
 	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 3a400ce603c4..33fddab41722 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -478,6 +478,7 @@
 #define USB_DEVICE_ID_GOOGLE_WHISKERS	0x5030
 #define USB_DEVICE_ID_GOOGLE_MASTERBALL	0x503c
 #define USB_DEVICE_ID_GOOGLE_MAGNEMITE	0x503d
+#define USB_DEVICE_ID_GOOGLE_MOONBALL	0x5044
 
 #define USB_VENDOR_ID_GOTOP		0x08f2
 #define USB_DEVICE_ID_SUPER_Q2		0x007f
-- 
2.25.1.481.gfbce0eb801-goog


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] HID: google: add moonball USB id
  2020-03-16  7:24 [PATCH] HID: google: add moonball USB id Chen-Tsung Hsieh
@ 2020-03-16  7:50 ` Nicolas Boichat
  2020-03-16 13:53 ` Jiri Kosina
  1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Boichat @ 2020-03-16  7:50 UTC (permalink / raw)
  To: Chen-Tsung Hsieh
  Cc: Jiri Kosina, Benjamin Tissoires, open list:HID CORE LAYER, lkml

Looks better with the mailing lists cc-ed, thanks!

On Mon, Mar 16, 2020 at 3:24 PM Chen-Tsung Hsieh <chentsung@chromium.org> wrote:
>
> Add 1 additional hammer-like device.
>
> Signed-off-by: Chen-Tsung Hsieh <chentsung@chromium.org>

Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>

> ---
>  drivers/hid/hid-google-hammer.c | 2 ++
>  drivers/hid/hid-ids.h           | 1 +
>  2 files changed, 3 insertions(+)
>
> diff --git a/drivers/hid/hid-google-hammer.c b/drivers/hid/hid-google-hammer.c
> index 2aa4ed157aec..85a054f1ce38 100644
> --- a/drivers/hid/hid-google-hammer.c
> +++ b/drivers/hid/hid-google-hammer.c
> @@ -532,6 +532,8 @@ static const struct hid_device_id hammer_devices[] = {
>                      USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_MAGNEMITE) },
>         { HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
>                      USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_MASTERBALL) },
> +       { HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
> +                    USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_MOONBALL) },
>         { HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
>                      USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_STAFF) },
>         { HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 3a400ce603c4..33fddab41722 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -478,6 +478,7 @@
>  #define USB_DEVICE_ID_GOOGLE_WHISKERS  0x5030
>  #define USB_DEVICE_ID_GOOGLE_MASTERBALL        0x503c
>  #define USB_DEVICE_ID_GOOGLE_MAGNEMITE 0x503d
> +#define USB_DEVICE_ID_GOOGLE_MOONBALL  0x5044
>
>  #define USB_VENDOR_ID_GOTOP            0x08f2
>  #define USB_DEVICE_ID_SUPER_Q2         0x007f
> --
> 2.25.1.481.gfbce0eb801-goog
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] HID: google: add moonball USB id
  2020-03-16  7:24 [PATCH] HID: google: add moonball USB id Chen-Tsung Hsieh
  2020-03-16  7:50 ` Nicolas Boichat
@ 2020-03-16 13:53 ` Jiri Kosina
  1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2020-03-16 13:53 UTC (permalink / raw)
  To: Chen-Tsung Hsieh; +Cc: benjamin.tissoires, linux-input, linux-kernel, drinkcat

On Mon, 16 Mar 2020, Chen-Tsung Hsieh wrote:

> Add 1 additional hammer-like device.
> 
> Signed-off-by: Chen-Tsung Hsieh <chentsung@chromium.org>

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-03-16 13:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-16  7:24 [PATCH] HID: google: add moonball USB id Chen-Tsung Hsieh
2020-03-16  7:50 ` Nicolas Boichat
2020-03-16 13:53 ` Jiri Kosina

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox