[hid:for-6.10/winwing 1/1] drivers/hid/hid-winwing.c:123:22: warning: variable 'minor' set but not used

[hid:for-6.10/winwing 1/1] drivers/hid/hid-winwing.c:123:22: warning: variable 'minor' set but not used

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-6.10/winwing
head:   266c990debad2f9589c7a412e897a8e312b09766
commit: 266c990debad2f9589c7a412e897a8e312b09766 [1/1] HID: Add WinWing Orion2 throttle support
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20240404/202404041038.aQ0aRTSK-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240404/202404041038.aQ0aRTSK-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404041038.aQ0aRTSK-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/hid/hid-winwing.c: In function 'winwing_probe':
>> drivers/hid/hid-winwing.c:123:22: warning: variable 'minor' set but not used [-Wunused-but-set-variable]
     123 |         unsigned int minor;
         |                      ^~~~~


vim +/minor +123 drivers/hid/hid-winwing.c

   119	
   120	static int winwing_probe(struct hid_device *hdev,
   121			const struct hid_device_id *id)
   122	{
 > 123		unsigned int minor;
   124		int ret;
   125	
   126		ret = hid_parse(hdev);
   127		if (ret) {
   128			hid_err(hdev, "parse failed\n");
   129			return ret;
   130		}
   131	
   132		ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT);
   133		if (ret) {
   134			hid_err(hdev, "hw start failed\n");
   135			return ret;
   136		}
   137	
   138		minor = ((struct hidraw *) hdev->hidraw)->minor;
   139	
   140		return 0;
   141	}
   142	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [hid:for-6.10/winwing 1/1] drivers/hid/hid-winwing.c:123:22: warning: variable 'minor' set but not used

[Jiri Kosina]

On Thu, 4 Apr 2024, kernel test robot wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-6.10/winwing
> head:   266c990debad2f9589c7a412e897a8e312b09766
> commit: 266c990debad2f9589c7a412e897a8e312b09766 [1/1] HID: Add WinWing Orion2 throttle support
> config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20240404/202404041038.aQ0aRTSK-lkp@intel.com/config)
> compiler: alpha-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240404/202404041038.aQ0aRTSK-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202404041038.aQ0aRTSK-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>    drivers/hid/hid-winwing.c: In function 'winwing_probe':
> >> drivers/hid/hid-winwing.c:123:22: warning: variable 'minor' set but not used [-Wunused-but-set-variable]
>      123 |         unsigned int minor;
>          |                      ^~~~~
> 

Ivan, will you please submit a fix for this?

Thanks,

-- 
Jiri Kosina
SUSE Labs