* [PATCH] HID: i2c-hid: Remove unused label in i2c_hid_set_power
@ 2024-05-07 6:36 Kenny Levinsen
2024-05-07 8:43 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Kenny Levinsen @ 2024-05-07 6:36 UTC (permalink / raw)
To: Jiri Kosina, Benjamin Tissoires
Cc: Stephen Rothwell, linux-input, linux-kernel, Kenny Levinsen
This label was left behind when the wake-up logic was moved from
i2c_hid_set_power to i2c_hid_probe_address. Clean it up as it causes
warnings-as-errors builds to fail.
Fixes: bb1033c8a3ea ("HID: i2c-hid: Use address probe to wake on resume")
Signed-off-by: Kenny Levinsen <kl@kl.wtf>
---
drivers/hid/i2c-hid/i2c-hid-core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
index 3e3885ae6ce2..632eaf9e11a6 100644
--- a/drivers/hid/i2c-hid/i2c-hid-core.c
+++ b/drivers/hid/i2c-hid/i2c-hid-core.c
@@ -407,8 +407,6 @@ static int i2c_hid_set_power(struct i2c_hid *ihid, int power_state)
dev_err(&ihid->client->dev,
"failed to change power setting.\n");
-set_pwr_exit:
-
/*
* The HID over I2C specification states that if a DEVICE needs time
* after the PWR_ON request, it should utilise CLOCK stretching.
--
2.45.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] HID: i2c-hid: Remove unused label in i2c_hid_set_power
2024-05-07 6:36 [PATCH] HID: i2c-hid: Remove unused label in i2c_hid_set_power Kenny Levinsen
@ 2024-05-07 8:43 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2024-05-07 8:43 UTC (permalink / raw)
To: Kenny Levinsen
Cc: Benjamin Tissoires, Stephen Rothwell, linux-input, linux-kernel
On Tue, 7 May 2024, Kenny Levinsen wrote:
> This label was left behind when the wake-up logic was moved from
> i2c_hid_set_power to i2c_hid_probe_address. Clean it up as it causes
> warnings-as-errors builds to fail.
>
> Fixes: bb1033c8a3ea ("HID: i2c-hid: Use address probe to wake on resume")
> Signed-off-by: Kenny Levinsen <kl@kl.wtf>
I have added
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
and applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-07 8:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-07 6:36 [PATCH] HID: i2c-hid: Remove unused label in i2c_hid_set_power Kenny Levinsen
2024-05-07 8:43 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox