* [PATCH v2] iio: hid-sensor-prox: Fix invalid read_raw for attention
@ 2024-11-22 17:36 Ricardo Ribalda
2024-11-22 17:55 ` srinivas pandruvada
0 siblings, 1 reply; 3+ messages in thread
From: Ricardo Ribalda @ 2024-11-22 17:36 UTC (permalink / raw)
To: Jiri Kosina, Jonathan Cameron, Srinivas Pandruvada,
Lars-Peter Clausen
Cc: Jonathan Cameron, linux-input, linux-iio, linux-kernel,
Ricardo Ribalda
The attention channel is a IIO_CHAN_INFO_PROCESSED, not a
IIO_CHAN_INFO_RAW.
Modify prox_read_raw() to support it.
Fixes: 596ef5cf654b ("iio: hid-sensor-prox: Add support for more channels")
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
Changes in v2:
- Do not change the condition for applying the multiplier.
- Link to v1: https://lore.kernel.org/r/20241121-fix-processed-v1-1-4fae6770db30@chromium.org
---
drivers/iio/light/hid-sensor-prox.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/light/hid-sensor-prox.c b/drivers/iio/light/hid-sensor-prox.c
index e8e7b2999b4c..0daa8d365a6c 100644
--- a/drivers/iio/light/hid-sensor-prox.c
+++ b/drivers/iio/light/hid-sensor-prox.c
@@ -94,6 +94,7 @@ static int prox_read_raw(struct iio_dev *indio_dev,
*val2 = 0;
switch (mask) {
case IIO_CHAN_INFO_RAW:
+ case IIO_CHAN_INFO_PROCESSED:
if (chan->scan_index >= prox_state->num_channels)
return -EINVAL;
address = prox_state->channel2usage[chan->scan_index];
---
base-commit: decc701f41d07481893fdea942c0ac6b226e84cd
change-id: 20241121-fix-processed-ed1a95641e64
Best regards,
--
Ricardo Ribalda <ribalda@chromium.org>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] iio: hid-sensor-prox: Fix invalid read_raw for attention
2024-11-22 17:36 [PATCH v2] iio: hid-sensor-prox: Fix invalid read_raw for attention Ricardo Ribalda
@ 2024-11-22 17:55 ` srinivas pandruvada
2024-12-15 12:57 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: srinivas pandruvada @ 2024-11-22 17:55 UTC (permalink / raw)
To: Ricardo Ribalda, Jiri Kosina, Jonathan Cameron,
Lars-Peter Clausen
Cc: Jonathan Cameron, linux-input, linux-iio, linux-kernel
On Fri, 2024-11-22 at 17:36 +0000, Ricardo Ribalda wrote:
> The attention channel is a IIO_CHAN_INFO_PROCESSED, not a
> IIO_CHAN_INFO_RAW.
>
> Modify prox_read_raw() to support it.
>
> Fixes: 596ef5cf654b ("iio: hid-sensor-prox: Add support for more
> channels")
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> Changes in v2:
> - Do not change the condition for applying the multiplier.
> - Link to v1:
> https://lore.kernel.org/r/20241121-fix-processed-v1-1-4fae6770db30@chromium.org
> ---
> drivers/iio/light/hid-sensor-prox.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/light/hid-sensor-prox.c
> b/drivers/iio/light/hid-sensor-prox.c
> index e8e7b2999b4c..0daa8d365a6c 100644
> --- a/drivers/iio/light/hid-sensor-prox.c
> +++ b/drivers/iio/light/hid-sensor-prox.c
> @@ -94,6 +94,7 @@ static int prox_read_raw(struct iio_dev *indio_dev,
> *val2 = 0;
> switch (mask) {
> case IIO_CHAN_INFO_RAW:
> + case IIO_CHAN_INFO_PROCESSED:
> if (chan->scan_index >= prox_state->num_channels)
> return -EINVAL;
> address = prox_state->channel2usage[chan-
> >scan_index];
>
> ---
> base-commit: decc701f41d07481893fdea942c0ac6b226e84cd
> change-id: 20241121-fix-processed-ed1a95641e64
>
> Best regards,
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] iio: hid-sensor-prox: Fix invalid read_raw for attention
2024-11-22 17:55 ` srinivas pandruvada
@ 2024-12-15 12:57 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2024-12-15 12:57 UTC (permalink / raw)
To: srinivas pandruvada
Cc: Ricardo Ribalda, Jiri Kosina, Lars-Peter Clausen,
Jonathan Cameron, linux-input, linux-iio, linux-kernel
On Fri, 22 Nov 2024 09:55:04 -0800
srinivas pandruvada <srinivas.pandruvada@linux.intel.com> wrote:
> On Fri, 2024-11-22 at 17:36 +0000, Ricardo Ribalda wrote:
> > The attention channel is a IIO_CHAN_INFO_PROCESSED, not a
> > IIO_CHAN_INFO_RAW.
> >
> > Modify prox_read_raw() to support it.
> >
> > Fixes: 596ef5cf654b ("iio: hid-sensor-prox: Add support for more
> > channels")
> > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
>
> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Applied to the fixes-togreg branch of iio.git.
Thanks,
Jonathan
>
> > ---
> > Changes in v2:
> > - Do not change the condition for applying the multiplier.
> > - Link to v1:
> > https://lore.kernel.org/r/20241121-fix-processed-v1-1-4fae6770db30@chromium.org
> > ---
> > drivers/iio/light/hid-sensor-prox.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/iio/light/hid-sensor-prox.c
> > b/drivers/iio/light/hid-sensor-prox.c
> > index e8e7b2999b4c..0daa8d365a6c 100644
> > --- a/drivers/iio/light/hid-sensor-prox.c
> > +++ b/drivers/iio/light/hid-sensor-prox.c
> > @@ -94,6 +94,7 @@ static int prox_read_raw(struct iio_dev *indio_dev,
> > *val2 = 0;
> > switch (mask) {
> > case IIO_CHAN_INFO_RAW:
> > + case IIO_CHAN_INFO_PROCESSED:
> > if (chan->scan_index >= prox_state->num_channels)
> > return -EINVAL;
> > address = prox_state->channel2usage[chan-
> > >scan_index];
> >
> > ---
> > base-commit: decc701f41d07481893fdea942c0ac6b226e84cd
> > change-id: 20241121-fix-processed-ed1a95641e64
> >
> > Best regards,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-15 12:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-22 17:36 [PATCH v2] iio: hid-sensor-prox: Fix invalid read_raw for attention Ricardo Ribalda
2024-11-22 17:55 ` srinivas pandruvada
2024-12-15 12:57 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox