From: Kaustabh Chakraborty <kauschluss@disroot.org>
To: Sangwon Jee <jeesw@melfas.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Henrik Rydberg <rydberg@bitmath.org>
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Kaustabh Chakraborty <kauschluss@disroot.org>
Subject: [PATCH RFC v2 4/5] Input: melfas-mip4 - initialize touch events only if the device is a touchscreen
Date: Fri, 13 Jun 2025 01:11:36 +0530 [thread overview]
Message-ID: <20250613-mip4-touchkey-v2-4-9bbbe14c016d@disroot.org> (raw)
In-Reply-To: <20250613-mip4-touchkey-v2-0-9bbbe14c016d@disroot.org>
Certain MIP4 devices report zero values when enquired for its touchscreen
dimensions (MIP4_R1_INFO_RESOLUTION_X and MIP4_R1_INFO_RESOLUTION_Y),
which is indicative of the fact that those devices are not touchscreens.
While registering for touch events for the device, always check - and
proceed - only if the device reports a non-zero resolution.
Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
drivers/input/touchscreen/melfas_mip4.c | 50 ++++++++++++++++++---------------
1 file changed, 27 insertions(+), 23 deletions(-)
diff --git a/drivers/input/touchscreen/melfas_mip4.c b/drivers/input/touchscreen/melfas_mip4.c
index 061ac353bc7a2e28f17581411af81f35c89733a1..57b657694a420220be135c2f78d3ddad3ef6f520 100644
--- a/drivers/input/touchscreen/melfas_mip4.c
+++ b/drivers/input/touchscreen/melfas_mip4.c
@@ -1146,14 +1146,16 @@ static int mip4_flash_fw(struct mip4_ts *ts,
mip4_query_device(ts);
/* Refresh device parameters */
- input_set_abs_params(ts->input, ABS_MT_POSITION_X, 0, ts->max_x, 0, 0);
- input_set_abs_params(ts->input, ABS_MT_POSITION_Y, 0, ts->max_y, 0, 0);
- input_set_abs_params(ts->input, ABS_X, 0, ts->max_x, 0, 0);
- input_set_abs_params(ts->input, ABS_Y, 0, ts->max_y, 0, 0);
- input_abs_set_res(ts->input, ABS_MT_POSITION_X, ts->ppm_x);
- input_abs_set_res(ts->input, ABS_MT_POSITION_Y, ts->ppm_y);
- input_abs_set_res(ts->input, ABS_X, ts->ppm_x);
- input_abs_set_res(ts->input, ABS_Y, ts->ppm_y);
+ if (ts->max_x && ts->max_y) {
+ input_set_abs_params(ts->input, ABS_MT_POSITION_X, 0, ts->max_x, 0, 0);
+ input_set_abs_params(ts->input, ABS_MT_POSITION_Y, 0, ts->max_y, 0, 0);
+ input_set_abs_params(ts->input, ABS_X, 0, ts->max_x, 0, 0);
+ input_set_abs_params(ts->input, ABS_Y, 0, ts->max_y, 0, 0);
+ input_abs_set_res(ts->input, ABS_MT_POSITION_X, ts->ppm_x);
+ input_abs_set_res(ts->input, ABS_MT_POSITION_Y, ts->ppm_y);
+ input_abs_set_res(ts->input, ABS_X, ts->ppm_x);
+ input_abs_set_res(ts->input, ABS_Y, ts->ppm_y);
+ }
for (i = 0; i < ts->key_num; i++) {
if (ts->key_code[i])
@@ -1498,21 +1500,23 @@ static int mip4_probe(struct i2c_client *client)
input->keycodesize = sizeof(*ts->key_code);
input->keycodemax = ts->key_num;
- input_set_abs_params(input, ABS_MT_TOOL_TYPE, 0, MT_TOOL_PALM, 0, 0);
- input_set_abs_params(input, ABS_MT_POSITION_X, 0, ts->max_x, 0, 0);
- input_set_abs_params(input, ABS_MT_POSITION_Y, 0, ts->max_y, 0, 0);
- input_set_abs_params(input, ABS_MT_PRESSURE,
- MIP4_PRESSURE_MIN, MIP4_PRESSURE_MAX, 0, 0);
- input_set_abs_params(input, ABS_MT_TOUCH_MAJOR,
- MIP4_TOUCH_MAJOR_MIN, MIP4_TOUCH_MAJOR_MAX, 0, 0);
- input_set_abs_params(input, ABS_MT_TOUCH_MINOR,
- MIP4_TOUCH_MINOR_MIN, MIP4_TOUCH_MINOR_MAX, 0, 0);
- input_abs_set_res(ts->input, ABS_MT_POSITION_X, ts->ppm_x);
- input_abs_set_res(ts->input, ABS_MT_POSITION_Y, ts->ppm_y);
-
- error = input_mt_init_slots(input, MIP4_MAX_FINGERS, INPUT_MT_DIRECT);
- if (error)
- return error;
+ if (ts->max_x && ts->max_y) {
+ input_set_abs_params(input, ABS_MT_TOOL_TYPE, 0, MT_TOOL_PALM, 0, 0);
+ input_set_abs_params(input, ABS_MT_POSITION_X, 0, ts->max_x, 0, 0);
+ input_set_abs_params(input, ABS_MT_POSITION_Y, 0, ts->max_y, 0, 0);
+ input_set_abs_params(input, ABS_MT_PRESSURE,
+ MIP4_PRESSURE_MIN, MIP4_PRESSURE_MAX, 0, 0);
+ input_set_abs_params(input, ABS_MT_TOUCH_MAJOR,
+ MIP4_TOUCH_MAJOR_MIN, MIP4_TOUCH_MAJOR_MAX, 0, 0);
+ input_set_abs_params(input, ABS_MT_TOUCH_MINOR,
+ MIP4_TOUCH_MINOR_MIN, MIP4_TOUCH_MINOR_MAX, 0, 0);
+ input_abs_set_res(ts->input, ABS_MT_POSITION_X, ts->ppm_x);
+ input_abs_set_res(ts->input, ABS_MT_POSITION_Y, ts->ppm_y);
+
+ error = input_mt_init_slots(input, MIP4_MAX_FINGERS, INPUT_MT_DIRECT);
+ if (error)
+ return error;
+ }
for (i = 0; i < ts->key_num; i++) {
if (ts->key_code[i])
--
2.49.0
next prev parent reply other threads:[~2025-06-12 19:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 19:41 [PATCH RFC v2 0/5] Support for MELFAS MIP4 touchkey devices Kaustabh Chakraborty
2025-06-12 19:41 ` [PATCH RFC v2 1/5] dt-bindings: input: melfas-mip4: convert to dtschema Kaustabh Chakraborty
2025-06-13 7:09 ` Krzysztof Kozlowski
2025-06-12 19:41 ` [PATCH RFC v2 2/5] dt-bindings: input: melfas-mip4: document linux,keycodes property Kaustabh Chakraborty
2025-06-12 20:58 ` Rob Herring (Arm)
2025-06-12 19:41 ` [PATCH RFC v2 3/5] Input: melfas-mip4 - add support for touchkey input events Kaustabh Chakraborty
2025-06-29 5:12 ` Dmitry Torokhov
2025-06-30 18:44 ` Kaustabh Chakraborty
2025-06-12 19:41 ` Kaustabh Chakraborty [this message]
2025-06-12 19:41 ` [PATCH RFC v2 5/5] Input: melfas-mip4 - add support for event formats 4 and 9 Kaustabh Chakraborty
2025-06-13 8:44 ` [PATCH RFC v2 0/5] Support for MELFAS MIP4 touchkey devices Kaustabh Chakraborty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250613-mip4-touchkey-v2-4-9bbbe14c016d@disroot.org \
--to=kauschluss@disroot.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jeesw@melfas.com \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox