From: Kaustabh Chakraborty <kauschluss@disroot.org>
To: Sangwon Jee <jeesw@melfas.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Henrik Rydberg <rydberg@bitmath.org>
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Kaustabh Chakraborty <kauschluss@disroot.org>
Subject: [PATCH RFC v2 5/5] Input: melfas-mip4 - add support for event formats 4 and 9
Date: Fri, 13 Jun 2025 01:11:37 +0530 [thread overview]
Message-ID: <20250613-mip4-touchkey-v2-5-9bbbe14c016d@disroot.org> (raw)
In-Reply-To: <20250613-mip4-touchkey-v2-0-9bbbe14c016d@disroot.org>
Valid event formats in this driver is limited to 0, 1, and 3. These are
event formats for MIP4 touchscreen devices. Add support for event
formats 4 and 9, which belong to touchkey devices.
While at it, simplify the logic in function mip4_query_device where
valid event formats are checked. Use a human-readable switch-case block
instead of an if statement with obscure conditions.
Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
drivers/input/touchscreen/melfas_mip4.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/melfas_mip4.c b/drivers/input/touchscreen/melfas_mip4.c
index 57b657694a420220be135c2f78d3ddad3ef6f520..95a78c86873355d0a8e0207b1eb4a8408f55cee4 100644
--- a/drivers/input/touchscreen/melfas_mip4.c
+++ b/drivers/input/touchscreen/melfas_mip4.c
@@ -360,9 +360,19 @@ static int mip4_query_device(struct mip4_ts *ts)
dev_dbg(&ts->client->dev, "event_format: %d, event_size: %d\n",
ts->event_format, ts->event_size);
- if (ts->event_format == 2 || ts->event_format > 3)
+ switch (ts->event_format) {
+ /* Touchscreens */
+ case 0:
+ case 1:
+ case 3:
+ /* Touchkeys */
+ case 4:
+ case 9:
+ break;
+ default:
dev_warn(&ts->client->dev,
"Unknown event format %d\n", ts->event_format);
+ }
}
return 0;
@@ -440,6 +450,8 @@ static void mip4_report_keys(struct mip4_ts *ts, u8 *packet)
switch (ts->event_format) {
case 0:
case 1:
+ case 4:
+ case 9:
key = packet[0] & 0x0F;
down = packet[0] & 0x80;
break;
@@ -552,6 +564,8 @@ static int mip4_handle_packet(struct mip4_ts *ts, u8 *packet)
switch (ts->event_format) {
case 0:
case 1:
+ case 4:
+ case 9:
type = (packet[0] & 0x40) >> 6;
break;
--
2.49.0
next prev parent reply other threads:[~2025-06-12 19:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 19:41 [PATCH RFC v2 0/5] Support for MELFAS MIP4 touchkey devices Kaustabh Chakraborty
2025-06-12 19:41 ` [PATCH RFC v2 1/5] dt-bindings: input: melfas-mip4: convert to dtschema Kaustabh Chakraborty
2025-06-13 7:09 ` Krzysztof Kozlowski
2025-06-12 19:41 ` [PATCH RFC v2 2/5] dt-bindings: input: melfas-mip4: document linux,keycodes property Kaustabh Chakraborty
2025-06-12 20:58 ` Rob Herring (Arm)
2025-06-12 19:41 ` [PATCH RFC v2 3/5] Input: melfas-mip4 - add support for touchkey input events Kaustabh Chakraborty
2025-06-29 5:12 ` Dmitry Torokhov
2025-06-30 18:44 ` Kaustabh Chakraborty
2025-06-12 19:41 ` [PATCH RFC v2 4/5] Input: melfas-mip4 - initialize touch events only if the device is a touchscreen Kaustabh Chakraborty
2025-06-12 19:41 ` Kaustabh Chakraborty [this message]
2025-06-13 8:44 ` [PATCH RFC v2 0/5] Support for MELFAS MIP4 touchkey devices Kaustabh Chakraborty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250613-mip4-touchkey-v2-5-9bbbe14c016d@disroot.org \
--to=kauschluss@disroot.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jeesw@melfas.com \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox