[PATCH v1 0/1] input: touchscreen: atmel_mxt_ts: add support for generic touchscreen configurations

[PATCH v1 0/1] input: touchscreen: atmel_mxt_ts: add support for generic touchscreen configurations

[Svyatoslav Ryhel]

This provides support for generic touchscreen configuration options like
swapped-x-y, min-x, min-y, size-x, size-y, etc.

Svyatoslav Ryhel (1):
  input: touchscreen: atmel_mxt_ts: add support for generic touchscreen
    configurations

 drivers/input/touchscreen/atmel_mxt_ts.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

-- 
2.48.1

[PATCH v1 1/1] input: touchscreen: atmel_mxt_ts: add support for generic touchscreen configurations

[Svyatoslav Ryhel]

This provides support for generic touchscreen configuration options like
swapped-x-y, min-x, min-y, size-x, size-y, etc.

Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
 drivers/input/touchscreen/atmel_mxt_ts.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
index 322d5a3d40a0..fc624101147e 100644
--- a/drivers/input/touchscreen/atmel_mxt_ts.c
+++ b/drivers/input/touchscreen/atmel_mxt_ts.c
@@ -19,6 +19,7 @@
 #include <linux/firmware.h>
 #include <linux/i2c.h>
 #include <linux/input/mt.h>
+#include <linux/input/touchscreen.h>
 #include <linux/interrupt.h>
 #include <linux/irq.h>
 #include <linux/of.h>
@@ -355,6 +356,8 @@ struct mxt_data {
 	enum mxt_suspend_mode suspend_mode;
 
 	u32 wakeup_method;
+
+	struct touchscreen_properties prop;
 };
 
 struct mxt_vb2_buffer {
@@ -888,8 +891,7 @@ static void mxt_proc_t9_message(struct mxt_data *data, u8 *message)
 
 		/* Touch active */
 		input_mt_report_slot_state(input_dev, MT_TOOL_FINGER, 1);
-		input_report_abs(input_dev, ABS_MT_POSITION_X, x);
-		input_report_abs(input_dev, ABS_MT_POSITION_Y, y);
+		touchscreen_report_pos(input_dev, &data->prop, x, y, true);
 		input_report_abs(input_dev, ABS_MT_PRESSURE, amplitude);
 		input_report_abs(input_dev, ABS_MT_TOUCH_MAJOR, area);
 	} else {
@@ -1010,8 +1012,7 @@ static void mxt_proc_t100_message(struct mxt_data *data, u8 *message)
 			id, type, x, y, major, pressure, orientation);
 
 		input_mt_report_slot_state(input_dev, tool, 1);
-		input_report_abs(input_dev, ABS_MT_POSITION_X, x);
-		input_report_abs(input_dev, ABS_MT_POSITION_Y, y);
+		touchscreen_report_pos(input_dev, &data->prop, x, y, true);
 		input_report_abs(input_dev, ABS_MT_TOUCH_MAJOR, major);
 		input_report_abs(input_dev, ABS_MT_PRESSURE, pressure);
 		input_report_abs(input_dev, ABS_MT_DISTANCE, distance);
@@ -2212,6 +2213,8 @@ static int mxt_initialize_input_device(struct mxt_data *data)
 				     0, 255, 0, 0);
 	}
 
+	touchscreen_parse_properties(input_dev, true, &data->prop);
+
 	/* For T15 and T97 Key Array */
 	if (data->T15_reportid_min || data->T97_reportid_min) {
 		for (i = 0; i < data->t15_num_keys; i++)
-- 
2.48.1

Re: [PATCH v1 1/1] input: touchscreen: atmel_mxt_ts: add support for generic touchscreen configurations

[Dmitry Torokhov]

Hi Svyatoslav,

On Wed, Sep 03, 2025 at 07:23:27PM +0300, Svyatoslav Ryhel wrote:
> This provides support for generic touchscreen configuration options like
> swapped-x-y, min-x, min-y, size-x, size-y, etc.

This requires corresponding change to the binding document.

Thanks.

-- 
Dmitry

Re: [PATCH v1 1/1] input: touchscreen: atmel_mxt_ts: add support for generic touchscreen configurations

[Svyatoslav Ryhel]

чт, 4 вер. 2025 р. о 15:22 Dmitry Torokhov <dmitry.torokhov@gmail.com> пише:
>
> Hi Svyatoslav,
>
> On Wed, Sep 03, 2025 at 07:23:27PM +0300, Svyatoslav Ryhel wrote:
> > This provides support for generic touchscreen configuration options like
> > swapped-x-y, min-x, min-y, size-x, size-y, etc.
>
> This requires corresponding change to the binding document.
>

I assumed it was already included, but it seems not to be. I will add
appropriate change to schema in v2. Do I need to add any adjustments
to the code?

> Thanks.
>
> --
> Dmitry

Re: [PATCH v1 1/1] input: touchscreen: atmel_mxt_ts: add support for generic touchscreen configurations

[Dmitry Torokhov]

On Thu, Sep 04, 2025 at 03:50:53PM +0300, Svyatoslav Ryhel wrote:
> чт, 4 вер. 2025 р. о 15:22 Dmitry Torokhov <dmitry.torokhov@gmail.com> пише:
> >
> > Hi Svyatoslav,
> >
> > On Wed, Sep 03, 2025 at 07:23:27PM +0300, Svyatoslav Ryhel wrote:
> > > This provides support for generic touchscreen configuration options like
> > > swapped-x-y, min-x, min-y, size-x, size-y, etc.
> >
> > This requires corresponding change to the binding document.
> >
> 
> I assumed it was already included, but it seems not to be. I will add
> appropriate change to schema in v2. Do I need to add any adjustments
> to the code?

No, the code looks good.

Thanks.

-- 
Dmitry