[PATCH 1/1] dt-bindings: touchscreen: move ar1021.txt to maxim,max11801.yaml

[PATCH 1/1] dt-bindings: touchscreen: move ar1021.txt to maxim,max11801.yaml

[Frank Li]

ar1021 have only reg and interrupts property beside touch common
properties. So move context of ar1021.txt into maxim,max11801.yaml.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 .../bindings/input/touchscreen/ar1021.txt         | 15 ---------------
 .../input/touchscreen/maxim,max11801.yaml         |  4 +++-
 2 files changed, 3 insertions(+), 16 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/ar1021.txt

diff --git a/Documentation/devicetree/bindings/input/touchscreen/ar1021.txt b/Documentation/devicetree/bindings/input/touchscreen/ar1021.txt
deleted file mode 100644
index 82019bd6094ee..0000000000000
--- a/Documentation/devicetree/bindings/input/touchscreen/ar1021.txt
+++ /dev/null
@@ -1,15 +0,0 @@
-* Microchip AR1020 and AR1021 touchscreen interface (I2C)
-
-Required properties:
-- compatible		: "microchip,ar1021-i2c"
-- reg			: I2C slave address
-- interrupts		: touch controller interrupt
-
-Example:
-
-	touchscreen@4d {
-		compatible = "microchip,ar1021-i2c";
-		reg = <0x4d>;
-		interrupt-parent = <&gpio3>;
-		interrupts = <11 IRQ_TYPE_LEVEL_HIGH>;
-	};
diff --git a/Documentation/devicetree/bindings/input/touchscreen/maxim,max11801.yaml b/Documentation/devicetree/bindings/input/touchscreen/maxim,max11801.yaml
index 4f528d2201992..288c7e6e1b3b7 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/maxim,max11801.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/maxim,max11801.yaml
@@ -11,7 +11,9 @@ maintainers:
 
 properties:
   compatible:
-    const: maxim,max11801
+    enum:
+      - maxim,max11801
+      - microchip,ar1021-i2c
 
   reg:
     maxItems: 1
-- 
2.34.1

Re: [PATCH 1/1] dt-bindings: touchscreen: move ar1021.txt to maxim,max11801.yaml

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1954 bytes --]

On Thu, Sep 25, 2025 at 02:56:47PM -0400, Frank Li wrote:
> ar1021 have only reg and interrupts property beside touch common
> properties. So move context of ar1021.txt into maxim,max11801.yaml.

Are these devices even remotely related, other than both being touch
devices?

> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  .../bindings/input/touchscreen/ar1021.txt         | 15 ---------------
>  .../input/touchscreen/maxim,max11801.yaml         |  4 +++-
>  2 files changed, 3 insertions(+), 16 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/ar1021.txt
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/ar1021.txt b/Documentation/devicetree/bindings/input/touchscreen/ar1021.txt
> deleted file mode 100644
> index 82019bd6094ee..0000000000000
> --- a/Documentation/devicetree/bindings/input/touchscreen/ar1021.txt
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -* Microchip AR1020 and AR1021 touchscreen interface (I2C)
> -
> -Required properties:
> -- compatible		: "microchip,ar1021-i2c"
> -- reg			: I2C slave address
> -- interrupts		: touch controller interrupt
> -
> -Example:
> -
> -	touchscreen@4d {
> -		compatible = "microchip,ar1021-i2c";
> -		reg = <0x4d>;
> -		interrupt-parent = <&gpio3>;
> -		interrupts = <11 IRQ_TYPE_LEVEL_HIGH>;
> -	};
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/maxim,max11801.yaml b/Documentation/devicetree/bindings/input/touchscreen/maxim,max11801.yaml
> index 4f528d2201992..288c7e6e1b3b7 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/maxim,max11801.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/maxim,max11801.yaml
> @@ -11,7 +11,9 @@ maintainers:
>  
>  properties:
>    compatible:
> -    const: maxim,max11801
> +    enum:
> +      - maxim,max11801
> +      - microchip,ar1021-i2c
>  
>    reg:
>      maxItems: 1
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH 1/1] dt-bindings: touchscreen: move ar1021.txt to maxim,max11801.yaml

[Frank Li]

On Thu, Sep 25, 2025 at 08:20:02PM +0100, Conor Dooley wrote:
> On Thu, Sep 25, 2025 at 02:56:47PM -0400, Frank Li wrote:
> > ar1021 have only reg and interrupts property beside touch common
> > properties. So move context of ar1021.txt into maxim,max11801.yaml.
>
> Are these devices even remotely related, other than both being touch
> devices?

No, just properties is the same. There are many binding files, which bundle
similar properties's yaml to one file.

we may create trivial-touch.yaml, which similar with trivial-rtc.yaml.

Frank

>
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  .../bindings/input/touchscreen/ar1021.txt         | 15 ---------------
> >  .../input/touchscreen/maxim,max11801.yaml         |  4 +++-
> >  2 files changed, 3 insertions(+), 16 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/input/touchscreen/ar1021.txt
> >
> > diff --git a/Documentation/devicetree/bindings/input/touchscreen/ar1021.txt b/Documentation/devicetree/bindings/input/touchscreen/ar1021.txt
> > deleted file mode 100644
> > index 82019bd6094ee..0000000000000
> > --- a/Documentation/devicetree/bindings/input/touchscreen/ar1021.txt
> > +++ /dev/null
> > @@ -1,15 +0,0 @@
> > -* Microchip AR1020 and AR1021 touchscreen interface (I2C)
> > -
> > -Required properties:
> > -- compatible		: "microchip,ar1021-i2c"
> > -- reg			: I2C slave address
> > -- interrupts		: touch controller interrupt
> > -
> > -Example:
> > -
> > -	touchscreen@4d {
> > -		compatible = "microchip,ar1021-i2c";
> > -		reg = <0x4d>;
> > -		interrupt-parent = <&gpio3>;
> > -		interrupts = <11 IRQ_TYPE_LEVEL_HIGH>;
> > -	};
> > diff --git a/Documentation/devicetree/bindings/input/touchscreen/maxim,max11801.yaml b/Documentation/devicetree/bindings/input/touchscreen/maxim,max11801.yaml
> > index 4f528d2201992..288c7e6e1b3b7 100644
> > --- a/Documentation/devicetree/bindings/input/touchscreen/maxim,max11801.yaml
> > +++ b/Documentation/devicetree/bindings/input/touchscreen/maxim,max11801.yaml
> > @@ -11,7 +11,9 @@ maintainers:
> >
> >  properties:
> >    compatible:
> > -    const: maxim,max11801
> > +    enum:
> > +      - maxim,max11801
> > +      - microchip,ar1021-i2c
> >
> >    reg:
> >      maxItems: 1
> > --
> > 2.34.1
> >

Re: [PATCH 1/1] dt-bindings: touchscreen: move ar1021.txt to maxim,max11801.yaml

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 972 bytes --]

On Thu, Sep 25, 2025 at 03:28:56PM -0400, Frank Li wrote:
> On Thu, Sep 25, 2025 at 08:20:02PM +0100, Conor Dooley wrote:
> > On Thu, Sep 25, 2025 at 02:56:47PM -0400, Frank Li wrote:
> > > ar1021 have only reg and interrupts property beside touch common
> > > properties. So move context of ar1021.txt into maxim,max11801.yaml.
> >
> > Are these devices even remotely related, other than both being touch
> > devices?
> 
> No, just properties is the same. There are many binding files, which bundle
> similar properties's yaml to one file.
> 
> we may create trivial-touch.yaml, which similar with trivial-rtc.yaml.

I think putting trivial devices that are completely unrelated into one
file is confusing. It makes it seem like these devices are similar in
programming model etc.
Merging them into a explicitly designated trivial-touch binding would be
an improvement, if there are lots of very similar devices that could
also be merged in together.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]