* [PATCH 1/3] Input: omap4-keypad - Remove redundant pm_runtime_mark_last_busy() calls
@ 2025-10-27 11:58 Sakari Ailus
2025-10-27 11:58 ` [PATCH 2/3] Input: cs40l50 " Sakari Ailus
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Sakari Ailus @ 2025-10-27 11:58 UTC (permalink / raw)
To: linux-input
Cc: Dmitry Torokhov, James Ogletree, Fred Treven, Ben Bright,
Josh Poimboeuf, Ingo Molnar, patches
pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
pm_runtime_mark_last_busy().
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/input/keyboard/omap4-keypad.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/input/keyboard/omap4-keypad.c b/drivers/input/keyboard/omap4-keypad.c
index bffe89c0717a..e783244d0c91 100644
--- a/drivers/input/keyboard/omap4-keypad.c
+++ b/drivers/input/keyboard/omap4-keypad.c
@@ -193,7 +193,6 @@ static irqreturn_t omap4_keypad_irq_thread_fn(int irq, void *dev_id)
kbd_write_irqreg(keypad_data, OMAP4_KBD_IRQSTATUS,
kbd_read_irqreg(keypad_data, OMAP4_KBD_IRQSTATUS));
- pm_runtime_mark_last_busy(dev);
pm_runtime_put_autosuspend(dev);
return IRQ_HANDLED;
@@ -231,7 +230,6 @@ static int omap4_keypad_open(struct input_dev *input)
enable_irq(keypad_data->irq);
out:
- pm_runtime_mark_last_busy(dev);
pm_runtime_put_autosuspend(dev);
return error;
@@ -265,7 +263,6 @@ static void omap4_keypad_close(struct input_dev *input)
enable_irq(keypad_data->irq);
clk_disable_unprepare(keypad_data->fck);
- pm_runtime_mark_last_busy(dev);
pm_runtime_put_autosuspend(dev);
}
@@ -404,7 +401,6 @@ static int omap4_keypad_probe(struct platform_device *pdev)
omap4_keypad_stop(keypad_data);
}
- pm_runtime_mark_last_busy(dev);
pm_runtime_put_autosuspend(dev);
if (error)
return error;
--
2.47.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/3] Input: cs40l50 - Remove redundant pm_runtime_mark_last_busy() calls
2025-10-27 11:58 [PATCH 1/3] Input: omap4-keypad - Remove redundant pm_runtime_mark_last_busy() calls Sakari Ailus
@ 2025-10-27 11:58 ` Sakari Ailus
2025-10-27 11:58 ` [PATCH 3/3] Input: cyapa " Sakari Ailus
2025-12-13 9:34 ` [PATCH 1/3] Input: omap4-keypad " Dmitry Torokhov
2 siblings, 0 replies; 4+ messages in thread
From: Sakari Ailus @ 2025-10-27 11:58 UTC (permalink / raw)
To: linux-input
Cc: Dmitry Torokhov, James Ogletree, Fred Treven, Ben Bright,
Josh Poimboeuf, Ingo Molnar, patches
pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
pm_runtime_mark_last_busy().
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/input/misc/cs40l50-vibra.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/input/misc/cs40l50-vibra.c b/drivers/input/misc/cs40l50-vibra.c
index 7aa7d577e01b..90410025bbae 100644
--- a/drivers/input/misc/cs40l50-vibra.c
+++ b/drivers/input/misc/cs40l50-vibra.c
@@ -308,7 +308,6 @@ static void cs40l50_add_worker(struct work_struct *work)
list_add(&effect->list, &vib->effect_head);
}
err_pm:
- pm_runtime_mark_last_busy(vib->dev);
pm_runtime_put_autosuspend(vib->dev);
err_exit:
work_data->error = error;
@@ -368,7 +367,6 @@ static void cs40l50_start_worker(struct work_struct *work)
dev_err(vib->dev, "Effect to play not found\n");
}
- pm_runtime_mark_last_busy(vib->dev);
pm_runtime_put_autosuspend(vib->dev);
err_free:
kfree(work_data);
@@ -384,7 +382,6 @@ static void cs40l50_stop_worker(struct work_struct *work)
vib->dsp.write(vib->dev, vib->regmap, vib->dsp.stop_cmd);
- pm_runtime_mark_last_busy(vib->dev);
pm_runtime_put_autosuspend(vib->dev);
kfree(work_data);
@@ -456,7 +453,6 @@ static void cs40l50_erase_worker(struct work_struct *work)
list_del(&erase_effect->list);
kfree(erase_effect);
err_pm:
- pm_runtime_mark_last_busy(vib->dev);
pm_runtime_put_autosuspend(vib->dev);
err_exit:
work_data->error = error;
--
2.47.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/3] Input: cyapa - Remove redundant pm_runtime_mark_last_busy() calls
2025-10-27 11:58 [PATCH 1/3] Input: omap4-keypad - Remove redundant pm_runtime_mark_last_busy() calls Sakari Ailus
2025-10-27 11:58 ` [PATCH 2/3] Input: cs40l50 " Sakari Ailus
@ 2025-10-27 11:58 ` Sakari Ailus
2025-12-13 9:34 ` [PATCH 1/3] Input: omap4-keypad " Dmitry Torokhov
2 siblings, 0 replies; 4+ messages in thread
From: Sakari Ailus @ 2025-10-27 11:58 UTC (permalink / raw)
To: linux-input
Cc: Dmitry Torokhov, James Ogletree, Fred Treven, Ben Bright,
Josh Poimboeuf, Ingo Molnar, patches
pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
pm_runtime_mark_last_busy().
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/input/mouse/cyapa.c | 3 ---
drivers/input/mouse/cyapa_gen5.c | 1 -
2 files changed, 4 deletions(-)
diff --git a/drivers/input/mouse/cyapa.c b/drivers/input/mouse/cyapa.c
index 00c87c0532a6..6e0d956617a1 100644
--- a/drivers/input/mouse/cyapa.c
+++ b/drivers/input/mouse/cyapa.c
@@ -403,7 +403,6 @@ static int cyapa_open(struct input_dev *input)
}
pm_runtime_get_sync(dev);
- pm_runtime_mark_last_busy(dev);
pm_runtime_put_sync_autosuspend(dev);
out:
mutex_unlock(&cyapa->state_sync_lock);
@@ -666,7 +665,6 @@ static int cyapa_reinitialize(struct cyapa *cyapa)
pm_runtime_enable(dev);
pm_runtime_get_sync(dev);
- pm_runtime_mark_last_busy(dev);
pm_runtime_put_sync_autosuspend(dev);
}
@@ -710,7 +708,6 @@ static irqreturn_t cyapa_irq(int irq, void *dev_id)
* process.
*/
pm_runtime_get_sync(dev);
- pm_runtime_mark_last_busy(dev);
pm_runtime_put_sync_autosuspend(dev);
}
diff --git a/drivers/input/mouse/cyapa_gen5.c b/drivers/input/mouse/cyapa_gen5.c
index 3b4439f10635..59f6e97d5482 100644
--- a/drivers/input/mouse/cyapa_gen5.c
+++ b/drivers/input/mouse/cyapa_gen5.c
@@ -2833,7 +2833,6 @@ static int cyapa_pip_event_process(struct cyapa *cyapa,
* process.
*/
pm_runtime_get_sync(dev);
- pm_runtime_mark_last_busy(dev);
pm_runtime_put_sync_autosuspend(dev);
return 0;
} else if (report_id != PIP_TOUCH_REPORT_ID &&
--
2.47.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] Input: omap4-keypad - Remove redundant pm_runtime_mark_last_busy() calls
2025-10-27 11:58 [PATCH 1/3] Input: omap4-keypad - Remove redundant pm_runtime_mark_last_busy() calls Sakari Ailus
2025-10-27 11:58 ` [PATCH 2/3] Input: cs40l50 " Sakari Ailus
2025-10-27 11:58 ` [PATCH 3/3] Input: cyapa " Sakari Ailus
@ 2025-12-13 9:34 ` Dmitry Torokhov
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2025-12-13 9:34 UTC (permalink / raw)
To: Sakari Ailus
Cc: linux-input, James Ogletree, Fred Treven, Ben Bright,
Josh Poimboeuf, Ingo Molnar, patches
On Mon, Oct 27, 2025 at 01:58:21PM +0200, Sakari Ailus wrote:
> pm_runtime_put_autosuspend(), pm_runtime_put_sync_autosuspend(),
> pm_runtime_autosuspend() and pm_request_autosuspend() now include a call
> to pm_runtime_mark_last_busy(). Remove the now-reduntant explicit call to
> pm_runtime_mark_last_busy().
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Applied the lot, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-12-13 9:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-27 11:58 [PATCH 1/3] Input: omap4-keypad - Remove redundant pm_runtime_mark_last_busy() calls Sakari Ailus
2025-10-27 11:58 ` [PATCH 2/3] Input: cs40l50 " Sakari Ailus
2025-10-27 11:58 ` [PATCH 3/3] Input: cyapa " Sakari Ailus
2025-12-13 9:34 ` [PATCH 1/3] Input: omap4-keypad " Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox