[PATCH] HID: Intel-thc-hid: Intel-thc: Fix wrong register reading

[PATCH] HID: Intel-thc-hid: Intel-thc: Fix wrong register reading

[Even Xu]

Correct the read register for the setting of max input size and
interrupt delay.

Fixes: 22da60f0304b ("HID: Intel-thc-hid: Intel-thc: Introduce interrupt delay control")
Fixes: 45e92a093099 ("HID: Intel-thc-hid: Intel-thc: Introduce max input size control")
Signed-off-by: Even Xu <even.xu@intel.com>
---
 drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c b/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c
index 636a68306501..7e220a4c5ded 100644
--- a/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c
+++ b/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dev.c
@@ -1593,7 +1593,7 @@ int thc_i2c_set_rx_max_size(struct thc_device *dev, u32 max_rx_size)
 	if (!max_rx_size)
 		return -EOPNOTSUPP;
 
-	ret = regmap_read(dev->thc_regmap, THC_M_PRT_SW_SEQ_STS_OFFSET, &val);
+	ret = regmap_read(dev->thc_regmap, THC_M_PRT_SPI_ICRRD_OPCODE_OFFSET, &val);
 	if (ret)
 		return ret;
 
@@ -1662,7 +1662,7 @@ int thc_i2c_set_rx_int_delay(struct thc_device *dev, u32 delay_us)
 	if (!delay_us)
 		return -EOPNOTSUPP;
 
-	ret = regmap_read(dev->thc_regmap, THC_M_PRT_SW_SEQ_STS_OFFSET, &val);
+	ret = regmap_read(dev->thc_regmap, THC_M_PRT_SPI_ICRRD_OPCODE_OFFSET, &val);
 	if (ret)
 		return ret;
 
-- 
2.40.1

Re: [PATCH] HID: Intel-thc-hid: Intel-thc: Fix wrong register reading

[Benjamin Tissoires]

On Fri, 19 Dec 2025 09:14:38 +0800, Even Xu wrote:
> Correct the read register for the setting of max input size and
> interrupt delay.
> 
> 

Applied to hid/hid.git (for-6.19/upstream-fixes), thanks!

[1/1] HID: Intel-thc-hid: Intel-thc: Fix wrong register reading
      https://git.kernel.org/hid/hid/c/f39006965dd3

Cheers,
-- 
Benjamin Tissoires <bentiss@kernel.org>

RE: [PATCH] HID: Intel-thc-hid: Intel-thc: Fix wrong register reading

[Xu, Even]

Thanks Benjamin!

Best Regards,
Even Xu

> -----Original Message-----
> From: Benjamin Tissoires <bentiss@kernel.org>
> Sent: Friday, December 19, 2025 9:06 PM
> To: jikos@kernel.org; Xu, Even <even.xu@intel.com>
> Cc: srinivas.pandruvada@linux.intel.com; linux-input@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH] HID: Intel-thc-hid: Intel-thc: Fix wrong register reading
> 
> On Fri, 19 Dec 2025 09:14:38 +0800, Even Xu wrote:
> > Correct the read register for the setting of max input size and
> > interrupt delay.
> >
> >
> 
> Applied to hid/hid.git (for-6.19/upstream-fixes), thanks!
> 
> [1/1] HID: Intel-thc-hid: Intel-thc: Fix wrong register reading
>       https://git.kernel.org/hid/hid/c/f39006965dd3
> 
> Cheers,
> --
> Benjamin Tissoires <bentiss@kernel.org>