* [PATCH v2 0/3] Support FT3518 touchscreen in xiaomi-laurel
@ 2026-01-14 9:31 Yedaya Katsman via B4 Relay
2026-01-14 9:31 ` [PATCH v2 1/3] dt-bindings: input: touchscreen: edt-ft5x06: Add FocalTech FT3518 Yedaya Katsman via B4 Relay
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Yedaya Katsman via B4 Relay @ 2026-01-14 9:31 UTC (permalink / raw)
To: SzczurekYT, Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio
Cc: linux-input, devicetree, linux-kernel, linux-arm-msm,
Yedaya Katsman, Kamil Gołda
Adds support for the touchscreen in the Xiaomi Mi A3 (xiaomi-laurel)
smartphone, FocalTech FT3518
Original tree was here:
Link: https://gitlab.postmarketos.org/SzczurekYT/linux/-/commits/laurel
Signed-off-by: Yedaya Katsman <yedaya.ka@gmail.com>
---
Changes in v2:
- Fixed name and email in signoffs
- Link to v1: https://lore.kernel.org/r/20260113-touchscreen-patches-v1-0-a10957f32dd8@gmail.com
---
Yedaya Katsman (3):
dt-bindings: input: touchscreen: edt-ft5x06: Add FocalTech FT3518
drivers: input: touchscreen: edt-ft5x06: Add FocalTech FT3518
arm64: dts: qcom: sm6125-xiaomi-laurel-sprout: Add Focaltech FT3518 touchscreen
.../bindings/input/touchscreen/edt-ft5x06.yaml | 1 +
.../boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts | 34 ++++++++++++++++++++++
drivers/input/touchscreen/edt-ft5x06.c | 6 ++++
3 files changed, 41 insertions(+)
---
base-commit: b71e635feefc852405b14620a7fc58c4c80c0f73
change-id: 20260113-touchscreen-patches-beb2526bd5fb
Best regards,
--
Yedaya Katsman <yedaya.ka@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH v2 1/3] dt-bindings: input: touchscreen: edt-ft5x06: Add FocalTech FT3518 2026-01-14 9:31 [PATCH v2 0/3] Support FT3518 touchscreen in xiaomi-laurel Yedaya Katsman via B4 Relay @ 2026-01-14 9:31 ` Yedaya Katsman via B4 Relay 2026-01-15 9:31 ` Krzysztof Kozlowski 2026-01-14 9:31 ` [PATCH v2 2/3] drivers: " Yedaya Katsman via B4 Relay 2026-01-14 9:31 ` [PATCH v2 3/3] arm64: dts: qcom: sm6125-xiaomi-laurel-sprout: Add Focaltech FT3518 touchscreen Yedaya Katsman via B4 Relay 2 siblings, 1 reply; 8+ messages in thread From: Yedaya Katsman via B4 Relay @ 2026-01-14 9:31 UTC (permalink / raw) To: SzczurekYT, Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio Cc: linux-input, devicetree, linux-kernel, linux-arm-msm, Yedaya Katsman, Kamil Gołda From: Yedaya Katsman <yedaya.ka@gmail.com> Document FocalTech FT3518 support by adding the compatible. Co-developed-by: Kamil Gołda <kamil.golda@protonmail.com> Signed-off-by: Kamil Gołda <kamil.golda@protonmail.com> Signed-off-by: Yedaya Katsman <yedaya.ka@gmail.com> --- Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml index 7d3edb58f72d84ed19fb87fdd136c97f855aba00..6f90522de8c0afbe2d9d1e04578316350f66ec58 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml @@ -39,6 +39,7 @@ properties: - edt,edt-ft5406 - edt,edt-ft5506 - evervision,ev-ft5726 + - focaltech,ft3518 - focaltech,ft5426 - focaltech,ft5452 - focaltech,ft6236 -- 2.52.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: input: touchscreen: edt-ft5x06: Add FocalTech FT3518 2026-01-14 9:31 ` [PATCH v2 1/3] dt-bindings: input: touchscreen: edt-ft5x06: Add FocalTech FT3518 Yedaya Katsman via B4 Relay @ 2026-01-15 9:31 ` Krzysztof Kozlowski 0 siblings, 0 replies; 8+ messages in thread From: Krzysztof Kozlowski @ 2026-01-15 9:31 UTC (permalink / raw) To: Yedaya Katsman Cc: SzczurekYT, Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio, linux-input, devicetree, linux-kernel, linux-arm-msm, Kamil Gołda On Wed, Jan 14, 2026 at 11:31:06AM +0200, Yedaya Katsman wrote: > Document FocalTech FT3518 support by adding the compatible. > > Co-developed-by: Kamil Gołda <kamil.golda@protonmail.com> > Signed-off-by: Kamil Gołda <kamil.golda@protonmail.com> > Signed-off-by: Yedaya Katsman <yedaya.ka@gmail.com> > --- > Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 1 + > 1 file changed, 1 insertion(+) Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 2/3] drivers: input: touchscreen: edt-ft5x06: Add FocalTech FT3518 2026-01-14 9:31 [PATCH v2 0/3] Support FT3518 touchscreen in xiaomi-laurel Yedaya Katsman via B4 Relay 2026-01-14 9:31 ` [PATCH v2 1/3] dt-bindings: input: touchscreen: edt-ft5x06: Add FocalTech FT3518 Yedaya Katsman via B4 Relay @ 2026-01-14 9:31 ` Yedaya Katsman via B4 Relay 2026-01-14 13:02 ` Dmitry Baryshkov 2026-01-14 9:31 ` [PATCH v2 3/3] arm64: dts: qcom: sm6125-xiaomi-laurel-sprout: Add Focaltech FT3518 touchscreen Yedaya Katsman via B4 Relay 2 siblings, 1 reply; 8+ messages in thread From: Yedaya Katsman via B4 Relay @ 2026-01-14 9:31 UTC (permalink / raw) To: SzczurekYT, Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio Cc: linux-input, devicetree, linux-kernel, linux-arm-msm, Yedaya Katsman, Kamil Gołda From: Yedaya Katsman <yedaya.ka@gmail.com> The driver also works with FT3518, which supports up to 10 touch points. Add compatible data for it. Co-developed-by: Kamil Gołda <kamil.golda@protonmail.com> Signed-off-by: Kamil Gołda <kamil.golda@protonmail.com> Signed-off-by: Yedaya Katsman <yedaya.ka@gmail.com> --- drivers/input/touchscreen/edt-ft5x06.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c index bf498bd4dea9651ac939fe137b1c0f05e8557962..d0ab644be0069b5ab29ed037fa090a4279870193 100644 --- a/drivers/input/touchscreen/edt-ft5x06.c +++ b/drivers/input/touchscreen/edt-ft5x06.c @@ -1475,6 +1475,10 @@ static const struct edt_i2c_chip_data edt_ft5x06_data = { .max_support_points = 5, }; +static const struct edt_i2c_chip_data edt_ft3518_data = { + .max_support_points = 10, +}; + static const struct edt_i2c_chip_data edt_ft5452_data = { .max_support_points = 5, }; @@ -1503,6 +1507,7 @@ static const struct i2c_device_id edt_ft5x06_ts_id[] = { { .name = "edt-ft5x06", .driver_data = (long)&edt_ft5x06_data }, { .name = "edt-ft5506", .driver_data = (long)&edt_ft5506_data }, { .name = "ev-ft5726", .driver_data = (long)&edt_ft5506_data }, + { .name = "ft3518", .driver_data = (long)&edt_ft3518_data }, { .name = "ft5452", .driver_data = (long)&edt_ft5452_data }, /* Note no edt- prefix for compatibility with the ft6236.c driver */ { .name = "ft6236", .driver_data = (long)&edt_ft6236_data }, @@ -1519,6 +1524,7 @@ static const struct of_device_id edt_ft5x06_of_match[] = { { .compatible = "edt,edt-ft5406", .data = &edt_ft5x06_data }, { .compatible = "edt,edt-ft5506", .data = &edt_ft5506_data }, { .compatible = "evervision,ev-ft5726", .data = &edt_ft5506_data }, + { .compatible = "focaltech,ft3518", .data = &edt_ft3518_data }, { .compatible = "focaltech,ft5426", .data = &edt_ft5506_data }, { .compatible = "focaltech,ft5452", .data = &edt_ft5452_data }, /* Note focaltech vendor prefix for compatibility with ft6236.c */ -- 2.52.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/3] drivers: input: touchscreen: edt-ft5x06: Add FocalTech FT3518 2026-01-14 9:31 ` [PATCH v2 2/3] drivers: " Yedaya Katsman via B4 Relay @ 2026-01-14 13:02 ` Dmitry Baryshkov 0 siblings, 0 replies; 8+ messages in thread From: Dmitry Baryshkov @ 2026-01-14 13:02 UTC (permalink / raw) To: yedaya.ka Cc: SzczurekYT, Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio, linux-input, devicetree, linux-kernel, linux-arm-msm, Kamil Gołda On Wed, Jan 14, 2026 at 11:31:07AM +0200, Yedaya Katsman via B4 Relay wrote: > From: Yedaya Katsman <yedaya.ka@gmail.com> > > The driver also works with FT3518, which supports up to 10 touch points. > Add compatible data for it. > > Co-developed-by: Kamil Gołda <kamil.golda@protonmail.com> > Signed-off-by: Kamil Gołda <kamil.golda@protonmail.com> > Signed-off-by: Yedaya Katsman <yedaya.ka@gmail.com> > --- > drivers/input/touchscreen/edt-ft5x06.c | 6 ++++++ > 1 file changed, 6 insertions(+) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 3/3] arm64: dts: qcom: sm6125-xiaomi-laurel-sprout: Add Focaltech FT3518 touchscreen 2026-01-14 9:31 [PATCH v2 0/3] Support FT3518 touchscreen in xiaomi-laurel Yedaya Katsman via B4 Relay 2026-01-14 9:31 ` [PATCH v2 1/3] dt-bindings: input: touchscreen: edt-ft5x06: Add FocalTech FT3518 Yedaya Katsman via B4 Relay 2026-01-14 9:31 ` [PATCH v2 2/3] drivers: " Yedaya Katsman via B4 Relay @ 2026-01-14 9:31 ` Yedaya Katsman via B4 Relay 2026-01-14 9:36 ` Konrad Dybcio 2026-01-14 13:04 ` Dmitry Baryshkov 2 siblings, 2 replies; 8+ messages in thread From: Yedaya Katsman via B4 Relay @ 2026-01-14 9:31 UTC (permalink / raw) To: SzczurekYT, Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio Cc: linux-input, devicetree, linux-kernel, linux-arm-msm, Yedaya Katsman, Kamil Gołda From: Yedaya Katsman <yedaya.ka@gmail.com> Add device tree node for the Focaltech FT3518 touchscreen on Xiaomi Mi A3 (laurel-sprout). Enable qupv3_id_0 and i2c2 bus that the touchscreen is on. Co-developed-by: Kamil Gołda <kamil.golda@protonmail.com> Signed-off-by: Kamil Gołda <kamil.golda@protonmail.com> Signed-off-by: Yedaya Katsman <yedaya.ka@gmail.com> --- .../boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts | 34 ++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts index 994fb0412fcbdf5466f87a325c48b697a37b514b..97feed708d3b6483eab72cfb0ae39be6f5ae3a11 100644 --- a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts +++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts @@ -119,6 +119,18 @@ active-config0 { }; }; }; + + ts_vdd_supply: ts-vdd-supply { + compatible = "regulator-fixed"; + regulator-name = "ts_vdd_supply"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + + gpio = <&tlmm 83 GPIO_ACTIVE_HIGH>; + enable-active-high; + + startup-delay-us = <70000>; + }; }; &hsusb_phy1 { @@ -411,3 +423,25 @@ &usb3 { &usb3_dwc3 { extcon = <&extcon_usb>; }; + +&qupv3_id_0 { + status = "okay"; +}; + +&i2c2 { + status = "okay"; + + touchscreen@38 { + compatible = "focaltech,ft3518"; + reg = <0x38>; + interrupt-parent = <&tlmm>; + interrupts = <88 IRQ_TYPE_EDGE_FALLING>; + + vcc-supply = <&ts_vdd_supply>; + + reset-gpios = <&tlmm 87 GPIO_ACTIVE_LOW>; + + touchscreen-size-x = <720>; + touchscreen-size-y = <1560>; + }; +}; -- 2.52.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 3/3] arm64: dts: qcom: sm6125-xiaomi-laurel-sprout: Add Focaltech FT3518 touchscreen 2026-01-14 9:31 ` [PATCH v2 3/3] arm64: dts: qcom: sm6125-xiaomi-laurel-sprout: Add Focaltech FT3518 touchscreen Yedaya Katsman via B4 Relay @ 2026-01-14 9:36 ` Konrad Dybcio 2026-01-14 13:04 ` Dmitry Baryshkov 1 sibling, 0 replies; 8+ messages in thread From: Konrad Dybcio @ 2026-01-14 9:36 UTC (permalink / raw) To: yedaya.ka, SzczurekYT, Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio Cc: linux-input, devicetree, linux-kernel, linux-arm-msm, Kamil Gołda On 1/14/26 10:31 AM, Yedaya Katsman via B4 Relay wrote: > From: Yedaya Katsman <yedaya.ka@gmail.com> > > Add device tree node for the Focaltech FT3518 touchscreen on > Xiaomi Mi A3 (laurel-sprout). > > Enable qupv3_id_0 and i2c2 bus that the touchscreen is on. > > Co-developed-by: Kamil Gołda <kamil.golda@protonmail.com> > Signed-off-by: Kamil Gołda <kamil.golda@protonmail.com> > Signed-off-by: Yedaya Katsman <yedaya.ka@gmail.com> > --- > .../boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts | 34 ++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts > index 994fb0412fcbdf5466f87a325c48b697a37b514b..97feed708d3b6483eab72cfb0ae39be6f5ae3a11 100644 > --- a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts > +++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts > @@ -119,6 +119,18 @@ active-config0 { > }; > }; > }; > + > + ts_vdd_supply: ts-vdd-supply { > + compatible = "regulator-fixed"; > + regulator-name = "ts_vdd_supply"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + > + gpio = <&tlmm 83 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + > + startup-delay-us = <70000>; > + }; > }; > > &hsusb_phy1 { > @@ -411,3 +423,25 @@ &usb3 { > &usb3_dwc3 { > extcon = <&extcon_usb>; > }; > + > +&qupv3_id_0 { > + status = "okay"; > +}; > + > +&i2c2 { Please sort the label references alphabetically > + status = "okay"; > + > + touchscreen@38 { > + compatible = "focaltech,ft3518"; > + reg = <0x38>; > + interrupt-parent = <&tlmm>; > + interrupts = <88 IRQ_TYPE_EDGE_FALLING>; interrupts-extended = <&tlmm 88 IRQ_TYPE_EDGE_FALLING>; > + > + vcc-supply = <&ts_vdd_supply>; > + > + reset-gpios = <&tlmm 87 GPIO_ACTIVE_LOW>; You reference gpio83 (vdd en), 88 (interrupt) and 87 (reset), please add a configuration for them under the TLMM node to ensure they're always in a predictable state You can probably find it in the downstream kernel, otherwise boot up a downstream build and check /sys/kernel/debug/gpios Konrad ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 3/3] arm64: dts: qcom: sm6125-xiaomi-laurel-sprout: Add Focaltech FT3518 touchscreen 2026-01-14 9:31 ` [PATCH v2 3/3] arm64: dts: qcom: sm6125-xiaomi-laurel-sprout: Add Focaltech FT3518 touchscreen Yedaya Katsman via B4 Relay 2026-01-14 9:36 ` Konrad Dybcio @ 2026-01-14 13:04 ` Dmitry Baryshkov 1 sibling, 0 replies; 8+ messages in thread From: Dmitry Baryshkov @ 2026-01-14 13:04 UTC (permalink / raw) To: yedaya.ka Cc: SzczurekYT, Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio, linux-input, devicetree, linux-kernel, linux-arm-msm, Kamil Gołda On Wed, Jan 14, 2026 at 11:31:08AM +0200, Yedaya Katsman via B4 Relay wrote: > From: Yedaya Katsman <yedaya.ka@gmail.com> > > Add device tree node for the Focaltech FT3518 touchscreen on > Xiaomi Mi A3 (laurel-sprout). > > Enable qupv3_id_0 and i2c2 bus that the touchscreen is on. > > Co-developed-by: Kamil Gołda <kamil.golda@protonmail.com> > Signed-off-by: Kamil Gołda <kamil.golda@protonmail.com> > Signed-off-by: Yedaya Katsman <yedaya.ka@gmail.com> > --- > .../boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts | 34 ++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts > index 994fb0412fcbdf5466f87a325c48b697a37b514b..97feed708d3b6483eab72cfb0ae39be6f5ae3a11 100644 > --- a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts > +++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-laurel-sprout.dts > @@ -119,6 +119,18 @@ active-config0 { > }; > }; > }; > + > + ts_vdd_supply: ts-vdd-supply { ts_vdd_supply: vreg-ts-vdd OR ts_vdd_supply: regulator-ts-vdd (It migth require to be moved up in the file according to the sorting rules). > + compatible = "regulator-fixed"; > + regulator-name = "ts_vdd_supply"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + > + gpio = <&tlmm 83 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + > + startup-delay-us = <70000>; > + }; > }; > -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2026-01-15 9:31 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-01-14 9:31 [PATCH v2 0/3] Support FT3518 touchscreen in xiaomi-laurel Yedaya Katsman via B4 Relay 2026-01-14 9:31 ` [PATCH v2 1/3] dt-bindings: input: touchscreen: edt-ft5x06: Add FocalTech FT3518 Yedaya Katsman via B4 Relay 2026-01-15 9:31 ` Krzysztof Kozlowski 2026-01-14 9:31 ` [PATCH v2 2/3] drivers: " Yedaya Katsman via B4 Relay 2026-01-14 13:02 ` Dmitry Baryshkov 2026-01-14 9:31 ` [PATCH v2 3/3] arm64: dts: qcom: sm6125-xiaomi-laurel-sprout: Add Focaltech FT3518 touchscreen Yedaya Katsman via B4 Relay 2026-01-14 9:36 ` Konrad Dybcio 2026-01-14 13:04 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox