From: sashiko-bot@kernel.org
To: "Ethan Nelson-Moore" <enelsonmoore@gmail.com>
Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH] Input: synaptics-rmi4 - correct CONFIG_RMI4_F34 macro name in comment
Date: Sat, 13 Jun 2026 22:23:21 +0000 [thread overview]
Message-ID: <20260613222321.BB0471F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260613222105.101418-1-enelsonmoore@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message contains a typo and repeats the same macro name twice when describing the change. It states that the comment 'incorrectly refers to CONFIG_RMI4_F34 instead of CONFIG_RMI4_F34', whereas the actual code diff shows the old macro name was 'CONFIG_RMI_F34'.
--
commit 0b9599ce581aac6de8ca3435e1928df9a8121100
Author: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Input: synaptics-rmi4 - correct CONFIG_RMI4_F34 macro name in comment
This commit fixes a typo in a preprocessor endif comment in the
synaptics-rmi4 driver, changing CONFIG_RMI_F34 to CONFIG_RMI4_F34.
> A comment in the synaptics-rmi4 driver incorrectly refers to
> CONFIG_RMI4_F34 instead of CONFIG_RMI4_F34. Correct it.
[Severity: Low]
This isn't a bug, but there is a typo in the commit message description.
It states the comment refers to CONFIG_RMI4_F34 instead of CONFIG_RMI4_F34,
repeating the same macro name twice. The actual code diff shows the old
macro name was CONFIG_RMI_F34.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260613222105.101418-1-enelsonmoore@gmail.com?part=1
prev parent reply other threads:[~2026-06-13 22:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-13 22:21 [PATCH] Input: synaptics-rmi4 - correct CONFIG_RMI4_F34 macro name in comment Ethan Nelson-Moore
2026-06-13 22:23 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260613222321.BB0471F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=enelsonmoore@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox