Linux Input/HID development
 help / color / mirror / Atom feed
* [PATCH] Input: synaptics-rmi4 - correct CONFIG_RMI4_F34 macro name in comment
@ 2026-06-13 22:21 Ethan Nelson-Moore
  2026-06-13 22:23 ` sashiko-bot
  0 siblings, 1 reply; 2+ messages in thread
From: Ethan Nelson-Moore @ 2026-06-13 22:21 UTC (permalink / raw)
  To: Dmitry Torokhov, Marge Yang, André Apitzsch,
	Ethan Nelson-Moore, linux-input

A comment in the synaptics-rmi4 driver incorrectly refers to
CONFIG_RMI4_F34 instead of CONFIG_RMI4_F34. Correct it.

Discovered while searching for CONFIG_* symbols referenced in code but
not defined in any Kconfig file.

Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
---
 drivers/input/rmi4/rmi_driver.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/rmi4/rmi_driver.h b/drivers/input/rmi4/rmi_driver.h
index e84495caab15..7d0ae80dc8ea 100644
--- a/drivers/input/rmi4/rmi_driver.h
+++ b/drivers/input/rmi4/rmi_driver.h
@@ -127,7 +127,7 @@ static inline int rmi_f34_create_sysfs(struct rmi_device *rmi_dev)
 static inline void rmi_f34_remove_sysfs(struct rmi_device *rmi_dev)
 {
 }
-#endif /* CONFIG_RMI_F34 */
+#endif /* CONFIG_RMI4_F34 */
 
 extern struct rmi_function_handler rmi_f01_handler;
 extern struct rmi_function_handler rmi_f03_handler;
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Input: synaptics-rmi4 - correct CONFIG_RMI4_F34 macro name in comment
  2026-06-13 22:21 [PATCH] Input: synaptics-rmi4 - correct CONFIG_RMI4_F34 macro name in comment Ethan Nelson-Moore
@ 2026-06-13 22:23 ` sashiko-bot
  0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-06-13 22:23 UTC (permalink / raw)
  To: Ethan Nelson-Moore; +Cc: linux-input, dmitry.torokhov

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message contains a typo and repeats the same macro name twice when describing the change. It states that the comment 'incorrectly refers to CONFIG_RMI4_F34 instead of CONFIG_RMI4_F34', whereas the actual code diff shows the old macro name was 'CONFIG_RMI_F34'.
--

commit 0b9599ce581aac6de8ca3435e1928df9a8121100
Author: Ethan Nelson-Moore <enelsonmoore@gmail.com>

Input: synaptics-rmi4 - correct CONFIG_RMI4_F34 macro name in comment

This commit fixes a typo in a preprocessor endif comment in the
synaptics-rmi4 driver, changing CONFIG_RMI_F34 to CONFIG_RMI4_F34.

> A comment in the synaptics-rmi4 driver incorrectly refers to
> CONFIG_RMI4_F34 instead of CONFIG_RMI4_F34. Correct it.

[Severity: Low]
This isn't a bug, but there is a typo in the commit message description.
It states the comment refers to CONFIG_RMI4_F34 instead of CONFIG_RMI4_F34,
repeating the same macro name twice. The actual code diff shows the old
macro name was CONFIG_RMI_F34.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260613222105.101418-1-enelsonmoore@gmail.com?part=1

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-06-13 22:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-13 22:21 [PATCH] Input: synaptics-rmi4 - correct CONFIG_RMI4_F34 macro name in comment Ethan Nelson-Moore
2026-06-13 22:23 ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox