Re: [PATCH] HID: cleanup help indentation in kconfig

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Malformed Kconfig help text indentation in `config HID_LENOVO` introduces a syntax error that breaks the kernel configuration process.
--

commit a32d9e3aafce015a8cfc25d49c3d96d9d8d186de
Author: Julian Braha <julianbraha@gmail.com>

HID: cleanup help indentation in kconfig

This commit standardizes the Kconfig help text indentation in the HID
subsystem to 2 spaces.

> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index f9bcaeb66385b..9b04ef19a4d24 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig

[ ... ]

> @@ -608,12 +608,12 @@ config HID_LENOVO
>  	tristate "Lenovo / Thinkpad devices"
>  	depends on LEDS_CLASS
>  	help
> -	Support for IBM/Lenovo devices that are not fully compliant with HID standard.
> +	  Support for IBM/Lenovo devices that are not fully compliant with HID standard.
>  
> -	Say Y if you want support for horizontal scrolling of the IBM/Lenovo
> -	Scrollpoint mice or the non-compliant features of the Lenovo Thinkpad
> -	standalone keyboards, e.g:
> -	- ThinkPad USB Keyboard with TrackPoint (supports extra LEDs and trackpoint
> -	  configuration)
> -	- ThinkPad Compact Bluetooth Keyboard with TrackPoint (supports Fn keys)
> -	- ThinkPad Compact USB Keyboard with TrackPoint (supports Fn keys)
> +	  Say Y if you want support for horizontal scrolling of the IBM/Lenovo
> +	  Scrollpoint mice or the non-compliant features of the Lenovo Thinkpad
> +	  standalone keyboards, e.g:
> +	  - ThinkPad USB Keyboard with TrackPoint (supports extra LEDs and trackpoint
> +	    configuration)
> +      - ThinkPad Compact Bluetooth Keyboard with TrackPoint (supports Fn keys)
> +      - ThinkPad Compact USB Keyboard with TrackPoint (supports Fn keys)

[Severity: Low]
Does this indentation cause a Kconfig syntax error?

These last two lines in the config HID_LENOVO block appear to be indented
with 6 spaces instead of matching the preceding lines. Because 6 spaces is
less than the indentation of the first line of the help text, the Kconfig
lexer will prematurely terminate the help block here.

Will this cause the parser to treat these lines as top-level Kconfig
statements and result in a syntax error when trying to build or configure
the kernel?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260630142043.496559-1-julianbraha@gmail.com?part=1