Re: Re: [PATCH v2] HID: i2c-hid: Fixes "(null)" device name error logs in i2c_hid_parse

Re: Re: [PATCH v2] HID: i2c-hid: Fixes "(null)" device name error logs in i2c_hid_parse

[Ai Chao]

Hello Doug

"Ai" is my surname, and "Chao" is my given name. My name is Ai Chao, which translates to "Super AI".

> > Before: hid (null): reading report descriptor failed
> > After:  i2c_hid i2c-TPD0001:00: reading report descriptor failed
> >
> > Signed-off-by: Ai Chao <aichao@kylinos.cn>
> > ---
> > change for v2
> > - Used Fixes tag.

> Could have fooled me. ;-)

syslog:
kernel: [    3.815131][ 1] [  T319] i2c_designware HYGO0010:00: timeout in disabling adapter
kernel: [   15.790171][ 1] [  T319] i2c_designware HYGO0010:00: timeout waiting for bus ready
kernel: [   15.998769][ 1] [  T319] i2c reading report descriptor failed retry:49
kernel: [   16.038176][ 1] [  T319] i2c_designware HYGO0010:00: timeout waiting for bus ready
kernel: [   16.246771][ 1] [  T319] i2c reading report descriptor failed retry:50
kernel: [   16.246775][ 1] [  T319] hid (null): reading report descriptor failed
kernel: [   16.246778][ 1] [  T319] i2c_hid i2c-TPD0001:00: can't add hid device: -5
kernel: [   16.246954][ 1] [  T319] i2c_hid: probe of i2c-TPD0001:00 failed with error -5


Thanks,
Ai Chao

Re: [PATCH v2] HID: i2c-hid: Fixes "(null)" device name error logs in i2c_hid_parse

[Mario Limonciello]

On 7/9/26 21:39, Ai Chao wrote:
> Hello Doug
> 
> "Ai" is my surname, and "Chao" is my given name. My name is Ai Chao, which translates to "Super AI".
> 
>>> Before: hid (null): reading report descriptor failed
>>> After:  i2c_hid i2c-TPD0001:00: reading report descriptor failed
>>>
>>> Signed-off-by: Ai Chao <aichao@kylinos.cn>
>>> ---
>>> change for v2
>>> - Used Fixes tag.
> 
>> Could have fooled me. ;-)
> 
> syslog:
> kernel: [    3.815131][ 1] [  T319] i2c_designware HYGO0010:00: timeout in disabling adapter
> kernel: [   15.790171][ 1] [  T319] i2c_designware HYGO0010:00: timeout waiting for bus ready
> kernel: [   15.998769][ 1] [  T319] i2c reading report descriptor failed retry:49
> kernel: [   16.038176][ 1] [  T319] i2c_designware HYGO0010:00: timeout waiting for bus ready
> kernel: [   16.246771][ 1] [  T319] i2c reading report descriptor failed retry:50
> kernel: [   16.246775][ 1] [  T319] hid (null): reading report descriptor failed
> kernel: [   16.246778][ 1] [  T319] i2c_hid i2c-TPD0001:00: can't add hid device: -5
> kernel: [   16.246954][ 1] [  T319] i2c_hid: probe of i2c-TPD0001:00 failed with error -5
> 
> 
> Thanks,
> Ai Chao
> 
> 

The point was that there is no "Fixes" tag added above your SoB, but you 
mentioned that there was one in your changelist.  Identify the commit 
that you're fixing (use git blame for example) and then add it to the 
commit text above your SoB in the correct format.

# git log -1 --format='Fixes: %h ("%s")' $commit