From: sashiko-bot@kernel.org
To: "Svyatoslav Ryhel" <clamor95@gmail.com>
Cc: lee@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, linux-input@vger.kernel.org,
dmitry.torokhov@gmail.com, linux-leds@vger.kernel.org
Subject: Re: [PATCH v7 6/6] mfd: motorola-cpcap: add support for Mot CPCAP composition
Date: Tue, 21 Jul 2026 10:20:27 +0000 [thread overview]
Message-ID: <20260721102028.115851F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260721095654.429346-7-clamor95@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message description is not capitalized, violating MFD subsystem guidelines.
--
--- Patch [6]: [PATCH v7 6/6] mfd: motorola-cpcap: add support for Mot CPCAP composition ---
commit 8d174ab85721459a22732636e016f27b79a8d93b
Author: Svyatoslav Ryhel <clamor95@gmail.com>
mfd: motorola-cpcap: add support for Mot CPCAP composition
This commit adds an MFD subdevice composition used in Tegra20 based Mot
boards (Motorola Atrix 4G and Droid X2).
> mfd: motorola-cpcap: add support for Mot CPCAP composition
[Severity: Low]
This isn't a bug, but should the description after the subsystem prefix be
capitalized? The MFD subsystem guidelines mandate capitalizing the description
after the prefix (e.g., "mfd: motorola-cpcap: Add support...").
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260721095654.429346-1-clamor95@gmail.com?part=6
prev parent reply other threads:[~2026-07-21 10:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 9:56 [PATCH v7 0/6] mfd: cpcap: convert documentation to schema and add Mot board support Svyatoslav Ryhel
2026-07-21 9:56 ` [PATCH v7 1/6] dt-bindings: leds: leds-cpcap: convert to DT schema Svyatoslav Ryhel
2026-07-21 10:06 ` sashiko-bot
2026-07-21 12:01 ` Rob Herring (Arm)
2026-07-21 9:56 ` [PATCH v7 2/6] dt-bindings: input: cpcap-pwrbutton: " Svyatoslav Ryhel
2026-07-21 10:08 ` sashiko-bot
2026-07-21 9:56 ` [PATCH v7 3/6] dt-bindings: mfd: motorola-cpcap: " Svyatoslav Ryhel
2026-07-21 10:15 ` sashiko-bot
2026-07-21 9:56 ` [PATCH v7 4/6] dt-bindings: mfd: motorola-cpcap: document Mapphone and Mot CPCAP Svyatoslav Ryhel
2026-07-21 10:16 ` sashiko-bot
2026-07-21 9:56 ` [PATCH v7 5/6] mfd: motorola-cpcap: diverge configuration per-board Svyatoslav Ryhel
2026-07-21 10:23 ` sashiko-bot
2026-07-21 9:56 ` [PATCH v7 6/6] mfd: motorola-cpcap: add support for Mot CPCAP composition Svyatoslav Ryhel
2026-07-21 10:20 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260721102028.115851F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=clamor95@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=lee@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox