From: Chen Changcheng <chenchangcheng@kylinos.cn>
To: bonbons@linux-vserver.org, jikos@kernel.org, bentiss@kernel.org,
srinivas.pandruvada@linux.intel.com, even.xu@intel.com,
xinpeng.sun@intel.com
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
ccc194101@163.com, Chen Changcheng <chenchangcheng@kylinos.cn>
Subject: [PATCH 2/4] HID: sony: Use min() macro to simplify code
Date: Tue, 28 Jul 2026 10:57:48 +0800 [thread overview]
Message-ID: <20260728025750.48249-3-chenchangcheng@kylinos.cn> (raw)
In-Reply-To: <20260728025750.48249-1-chenchangcheng@kylinos.cn>
Replace open-coded min() logic with the standard min() macro
in hid-sony.c for battery capacity index calculation.
Detected by Coccinelle:
./hid-sony.c:970:21-23: WARNING opportunity for min()
Signed-off-by: Chen Changcheng <chenchangcheng@kylinos.cn>
---
drivers/hid/hid-sony.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index e75246d29e16..cbc916989646 100644
--- a/drivers/hid/hid-sony.c
+++ b/drivers/hid/hid-sony.c
@@ -967,7 +967,7 @@ static void sixaxis_parse_report(struct sony_sc *sc, u8 *rd, int size)
battery_capacity = 100;
battery_status = (rd[offset] & 0x01) ? POWER_SUPPLY_STATUS_FULL : POWER_SUPPLY_STATUS_CHARGING;
} else {
- index = rd[offset] <= 5 ? rd[offset] : 5;
+ index = min(rd[offset], 5);
battery_capacity = sixaxis_battery_capacity[index];
battery_status = POWER_SUPPLY_STATUS_DISCHARGING;
}
--
2.25.1
next prev parent reply other threads:[~2026-07-28 2:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 2:57 [PATCH 0/4] HID: Address Coccinelle warnings Chen Changcheng
2026-07-28 2:57 ` [PATCH 1/4] HID: intel-quicki2c: Use min() macro to simplify code Chen Changcheng
2026-07-28 3:05 ` sashiko-bot
2026-07-28 2:57 ` Chen Changcheng [this message]
2026-07-28 2:57 ` [PATCH 3/4] HID: picolcd: " Chen Changcheng
2026-07-28 3:06 ` sashiko-bot
2026-07-28 2:57 ` [PATCH 4/4] HID: intel-ish-hid: Use secs_to_jiffies() instead of msecs_to_jiffies(sec * MSEC_PER_SEC) Chen Changcheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260728025750.48249-3-chenchangcheng@kylinos.cn \
--to=chenchangcheng@kylinos.cn \
--cc=bentiss@kernel.org \
--cc=bonbons@linux-vserver.org \
--cc=ccc194101@163.com \
--cc=even.xu@intel.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=xinpeng.sun@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox