From: Chen Changcheng <chenchangcheng@kylinos.cn>
To: bonbons@linux-vserver.org, jikos@kernel.org, bentiss@kernel.org,
srinivas.pandruvada@linux.intel.com, even.xu@intel.com,
xinpeng.sun@intel.com
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
ccc194101@163.com, Chen Changcheng <chenchangcheng@kylinos.cn>
Subject: [PATCH 4/4] HID: intel-ish-hid: Use secs_to_jiffies() instead of msecs_to_jiffies(sec * MSEC_PER_SEC)
Date: Tue, 28 Jul 2026 10:57:50 +0800 [thread overview]
Message-ID: <20260728025750.48249-5-chenchangcheng@kylinos.cn> (raw)
In-Reply-To: <20260728025750.48249-1-chenchangcheng@kylinos.cn>
Use the standard secs_to_jiffies() helper instead of open-coding
the conversion from seconds via msecs_to_jiffies(). This is more
efficient and improves code readability.
Detected by Coccinelle:
./intel-ish-hid/ishtp/ishtp-dev.h:272:25-28: WARNING opportunity for secs_to_jiffies()
Signed-off-by: Chen Changcheng <chenchangcheng@kylinos.cn>
---
drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h b/drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h
index 4b0596eadf1c..9457c30b1507 100644
--- a/drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h
+++ b/drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h
@@ -269,7 +269,7 @@ struct ishtp_device {
static inline unsigned long ishtp_secs_to_jiffies(unsigned long sec)
{
- return msecs_to_jiffies(sec * MSEC_PER_SEC);
+ return secs_to_jiffies(sec);
}
/*
--
2.25.1
prev parent reply other threads:[~2026-07-28 2:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 2:57 [PATCH 0/4] HID: Address Coccinelle warnings Chen Changcheng
2026-07-28 2:57 ` [PATCH 1/4] HID: intel-quicki2c: Use min() macro to simplify code Chen Changcheng
2026-07-28 3:05 ` sashiko-bot
2026-07-28 2:57 ` [PATCH 2/4] HID: sony: " Chen Changcheng
2026-07-28 2:57 ` [PATCH 3/4] HID: picolcd: " Chen Changcheng
2026-07-28 3:06 ` sashiko-bot
2026-07-28 2:57 ` Chen Changcheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260728025750.48249-5-chenchangcheng@kylinos.cn \
--to=chenchangcheng@kylinos.cn \
--cc=bentiss@kernel.org \
--cc=bonbons@linux-vserver.org \
--cc=ccc194101@163.com \
--cc=even.xu@intel.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=xinpeng.sun@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox