* [PATCH v3] HID: logitech-hidpp: add native touchpad support for K400 Plus
@ 2026-08-24 18:04 Dmitriy Geels
2026-08-24 18:18 ` sashiko-bot
0 siblings, 1 reply; 2+ messages in thread
From: Dmitriy Geels @ 2026-08-24 18:04 UTC (permalink / raw)
To: Filipe Laíns, Bastien Nocera
Cc: Jiri Kosina, Benjamin Tissoires, Henrik Rydberg, linux-input,
Dmitriy Geels
The Logitech K400 Plus (WPID 0x404d) exposes its touchpad through the
HID++ TouchpadRawXY feature, but currently operates as an emulated mouse.
Add support for the native raw touchpad reports by creating a separate
multitouch input device while leaving the keyboard and physical button
reports on the existing HID input device.
The K400 Plus reports an area range of zero. Do not expose
ABS_MT_PRESSURE when the TouchpadRawXY feature reports no contact area,
as a permanently zero pressure value causes userspace to treat contacts
as hovering rather than touching.
This enables native touchpad handling, including multitouch gestures and
two-finger scrolling.
This is an AI-assisted patch.
Signed-off-by: Dmitriy Geels <dmitriy.geels@gmail.com>
---
Addressed Sashiko AI review issues.
Changes in v3: fix variable definition
Changes in v2:
- Publish the touchpad input device only after successful registration.
- Free the input device on initialization and registration failures.
- Propagate errors from input_mt_init_slots().
- Do not expose clickpad buttons on the native touchpad input; the K400
Plus reports its physical buttons through the existing HID input.
Tested with Logitech K400 Plus (WPID 0x404d):
- single-finger pointer motion
- two-finger scrolling
- physical left/right buttons
- keyboard power off/on
- suspend/resume
v2: https://lore.kernel.org/linux-input/20260824173042.13679-1-dmitriy.geels@gmail.com/
v1: https://lore.kernel.org/linux-input/20260824132445.C64EE1F000E9@smtp.kernel.org/
drivers/hid/hid-logitech-hidpp.c | 186 +++++++++++++++++++++++--------
1 file changed, 140 insertions(+), 46 deletions(-)
diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
index 1504de32b1c8..cb113bef5f89 100644
--- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/hid/hid-logitech-hidpp.c
@@ -64,6 +64,7 @@ MODULE_PARM_DESC(disable_tap_to_click,
#define HIDPP_QUIRK_CLASS_K400 BIT(2)
#define HIDPP_QUIRK_CLASS_G920 BIT(3)
#define HIDPP_QUIRK_CLASS_K750 BIT(4)
+#define HIDPP_QUIRK_CLASS_KBD_WTP BIT(5)
/* bits 2..20 are reserved for classes */
/* #define HIDPP_QUIRK_CONNECT_EVENTS BIT(21) disabled */
@@ -2932,11 +2933,13 @@ static int hidpp_ff_init(struct hidpp_device *hidpp,
#define WTP_MANUAL_RESOLUTION 39
struct wtp_data {
+ struct input_dev *input;
u16 x_size, y_size;
u8 finger_count;
u8 mt_feature_index;
u8 button_feature_index;
u8 maxcontacts;
+ u8 area_range;
bool flip_y;
unsigned int resolution;
};
@@ -2948,8 +2951,8 @@ static int wtp_input_mapping(struct hid_device *hdev, struct hid_input *hi,
return -1;
}
-static void wtp_populate_input(struct hidpp_device *hidpp,
- struct input_dev *input_dev)
+static int wtp_populate_input(struct hidpp_device *hidpp,
+ struct input_dev *input_dev)
{
struct wtp_data *wd = hidpp->private_data;
@@ -2963,8 +2966,13 @@ static void wtp_populate_input(struct hidpp_device *hidpp,
input_set_abs_params(input_dev, ABS_MT_POSITION_Y, 0, wd->y_size, 0, 0);
input_abs_set_res(input_dev, ABS_MT_POSITION_Y, wd->resolution);
- /* Max pressure is not given by the devices, pick one */
- input_set_abs_params(input_dev, ABS_MT_PRESSURE, 0, 50, 0, 0);
+ /*
+ * The driver exposes contact area as pressure. Do not advertise a
+ * pressure axis when the device does not report contact area; userspace
+ * may otherwise interpret a permanently-zero pressure value as hover.
+ */
+ if (wd->area_range)
+ input_set_abs_params(input_dev, ABS_MT_PRESSURE, 0, 50, 0, 0);
input_set_capability(input_dev, EV_KEY, BTN_LEFT);
@@ -2973,8 +2981,8 @@ static void wtp_populate_input(struct hidpp_device *hidpp,
else
__set_bit(INPUT_PROP_BUTTONPAD, input_dev->propbit);
- input_mt_init_slots(input_dev, wd->maxcontacts, INPUT_MT_POINTER |
- INPUT_MT_DROP_UNUSED);
+ return input_mt_init_slots(input_dev, wd->maxcontacts, INPUT_MT_POINTER |
+ INPUT_MT_DROP_UNUSED);
}
static void wtp_touch_event(struct hidpp_device *hidpp,
@@ -2987,37 +2995,42 @@ static void wtp_touch_event(struct hidpp_device *hidpp,
/* no actual data */
return;
- slot = input_mt_get_slot_by_key(hidpp->input, touch_report->finger_id);
+ slot = input_mt_get_slot_by_key(wd->input, touch_report->finger_id);
- input_mt_slot(hidpp->input, slot);
- input_mt_report_slot_state(hidpp->input, MT_TOOL_FINGER,
- touch_report->contact_status);
+ input_mt_slot(wd->input, slot);
+ input_mt_report_slot_state(wd->input, MT_TOOL_FINGER,
+ touch_report->contact_status);
if (touch_report->contact_status) {
- input_event(hidpp->input, EV_ABS, ABS_MT_POSITION_X,
- touch_report->x);
- input_event(hidpp->input, EV_ABS, ABS_MT_POSITION_Y,
- wd->flip_y ? wd->y_size - touch_report->y :
- touch_report->y);
- input_event(hidpp->input, EV_ABS, ABS_MT_PRESSURE,
- touch_report->area);
+ input_event(wd->input, EV_ABS, ABS_MT_POSITION_X,
+ touch_report->x);
+ input_event(wd->input, EV_ABS, ABS_MT_POSITION_Y,
+ wd->flip_y ? wd->y_size - touch_report->y :
+ touch_report->y);
+
+ if (wd->area_range)
+ input_event(wd->input, EV_ABS, ABS_MT_PRESSURE,
+ touch_report->area);
}
}
static void wtp_send_raw_xy_event(struct hidpp_device *hidpp,
struct hidpp_touchpad_raw_xy *raw)
{
+ struct wtp_data *wd = hidpp->private_data;
int i;
for (i = 0; i < 2; i++)
wtp_touch_event(hidpp, &(raw->fingers[i]));
if (raw->end_of_frame &&
- !(hidpp->quirks & HIDPP_QUIRK_WTP_PHYSICAL_BUTTONS))
- input_event(hidpp->input, EV_KEY, BTN_LEFT, raw->button);
+ !(hidpp->quirks &
+ (HIDPP_QUIRK_WTP_PHYSICAL_BUTTONS |
+ HIDPP_QUIRK_CLASS_KBD_WTP)))
+ input_event(wd->input, EV_KEY, BTN_LEFT, raw->button);
if (raw->end_of_frame || raw->finger_count <= 2) {
- input_mt_sync_frame(hidpp->input);
- input_sync(hidpp->input);
+ input_mt_sync_frame(wd->input);
+ input_sync(wd->input);
}
}
@@ -3066,8 +3079,13 @@ static int wtp_raw_event(struct hid_device *hdev, u8 *data, int size)
struct wtp_data *wd = hidpp->private_data;
struct hidpp_report *report = (struct hidpp_report *)data;
struct hidpp_touchpad_raw_xy raw;
+ struct input_dev *input;
- if (!wd || !hidpp->input)
+ if (!wd)
+ return 1;
+
+ input = wd->input;
+ if (!input)
return 1;
switch (data[0]) {
@@ -3078,11 +3096,11 @@ static int wtp_raw_event(struct hid_device *hdev, u8 *data, int size)
return 1;
}
if (hidpp->quirks & HIDPP_QUIRK_WTP_PHYSICAL_BUTTONS) {
- input_event(hidpp->input, EV_KEY, BTN_LEFT,
- !!(data[1] & 0x01));
- input_event(hidpp->input, EV_KEY, BTN_RIGHT,
- !!(data[1] & 0x02));
- input_sync(hidpp->input);
+ input_event(input, EV_KEY, BTN_LEFT,
+ !!(data[1] & 0x01));
+ input_event(input, EV_KEY, BTN_RIGHT,
+ !!(data[1] & 0x02));
+ input_sync(input);
return 0;
} else {
if (size < 21)
@@ -3109,6 +3127,9 @@ static int wtp_get_config(struct hidpp_device *hidpp)
struct hidpp_touchpad_raw_info raw_info = {0};
int ret;
+ if (wd->x_size)
+ return 0;
+
ret = hidpp_root_get_feature(hidpp, HIDPP_PAGE_TOUCHPAD_RAW_XY,
&wd->mt_feature_index);
if (ret)
@@ -3123,6 +3144,7 @@ static int wtp_get_config(struct hidpp_device *hidpp)
wd->x_size = raw_info.x_size;
wd->y_size = raw_info.y_size;
wd->maxcontacts = raw_info.maxcontacts;
+ wd->area_range = raw_info.area_range;
wd->flip_y = raw_info.origin == TOUCHPAD_RAW_XY_ORIGIN_LOWER_LEFT;
wd->resolution = raw_info.res;
if (!wd->resolution)
@@ -3146,22 +3168,27 @@ static int wtp_allocate(struct hid_device *hdev, const struct hid_device_id *id)
return 0;
};
+static int wtp_enable_raw_mode(struct hidpp_device *hidpp)
+{
+ struct wtp_data *wd = hidpp->private_data;
+
+ return hidpp_touchpad_set_raw_report_state(hidpp,
+ wd->mt_feature_index,
+ true, true);
+}
+
static int wtp_connect(struct hid_device *hdev)
{
struct hidpp_device *hidpp = hid_get_drvdata(hdev);
- struct wtp_data *wd = hidpp->private_data;
int ret;
- if (!wd->x_size) {
- ret = wtp_get_config(hidpp);
- if (ret) {
- hid_err(hdev, "Can not get wtp config: %d\n", ret);
- return ret;
- }
+ ret = wtp_get_config(hidpp);
+ if (ret) {
+ hid_err(hdev, "cannot get WTP config: %d\n", ret);
+ return ret;
}
- return hidpp_touchpad_set_raw_report_state(hidpp, wd->mt_feature_index,
- true, true);
+ return wtp_enable_raw_mode(hidpp);
}
/* ------------------------------------------------------------------------- */
@@ -4064,14 +4091,22 @@ static int hidpp_input_mapped(struct hid_device *hdev, struct hid_input *hi,
}
-static void hidpp_populate_input(struct hidpp_device *hidpp,
+static int hidpp_populate_input(struct hidpp_device *hidpp,
struct input_dev *input)
{
+ int ret;
+
hidpp->input = input;
- if (hidpp->quirks & HIDPP_QUIRK_CLASS_WTP)
- wtp_populate_input(hidpp, input);
- else if (hidpp->quirks & HIDPP_QUIRK_CLASS_M560)
+ if (hidpp->quirks & HIDPP_QUIRK_CLASS_WTP) {
+ struct wtp_data *wd = hidpp->private_data;
+
+ ret = wtp_populate_input(hidpp, input);
+ if (ret)
+ return ret;
+
+ wd->input = input;
+ } else if (hidpp->quirks & HIDPP_QUIRK_CLASS_M560)
m560_populate_input(hidpp, input);
if (hidpp->quirks & HIDPP_QUIRK_HIDPP_WHEELS)
@@ -4082,6 +4117,8 @@ static void hidpp_populate_input(struct hidpp_device *hidpp,
if (hidpp->quirks & HIDPP_QUIRK_HIDPP_REPROG_CONTROLS_BTNS)
hidpp20_reprog_controls_populate_input(hidpp, input);
+
+ return 0;
}
static int hidpp_input_configured(struct hid_device *hdev, struct hid_input *hidinput)
@@ -4110,9 +4147,7 @@ static int hidpp_input_configured(struct hid_device *hdev, struct hid_input *hid
}
}
- hidpp_populate_input(hidpp, input);
-
- return 0;
+ return hidpp_populate_input(hidpp, input);
}
static int hidpp_raw_hidpp_event(struct hidpp_device *hidpp, u8 *data,
@@ -4274,6 +4309,9 @@ static int hidpp_raw_event(struct hid_device *hdev, struct hid_report *report,
if (hidpp->quirks & HIDPP_QUIRK_CLASS_WTP)
return wtp_raw_event(hdev, data, size);
+ else if ((hidpp->quirks & HIDPP_QUIRK_CLASS_KBD_WTP) &&
+ data[0] == REPORT_ID_HIDPP_LONG)
+ return wtp_raw_event(hdev, data, size);
else if (hidpp->quirks & HIDPP_QUIRK_CLASS_M560)
return m560_raw_event(hdev, data, size);
@@ -4524,7 +4562,54 @@ static void hidpp_connect_event(struct work_struct *work)
return;
}
- if (hidpp->quirks & HIDPP_QUIRK_CLASS_WTP) {
+ if (hidpp->quirks & HIDPP_QUIRK_CLASS_KBD_WTP) {
+ struct wtp_data *wd = hidpp->private_data;
+
+ if (!wd->input) {
+ ret = wtp_get_config(hidpp);
+ if (ret) {
+ hid_err(hdev, "cannot get WTP config: %d\n", ret);
+ return;
+ }
+
+ input = hidpp_allocate_input(hdev);
+ if (!input) {
+ hid_err(hdev, "cannot allocate touchpad input device\n");
+ return;
+ }
+
+ devm_name = devm_kasprintf(&hdev->dev, GFP_KERNEL,
+ "%s Touchpad", hidpp->name);
+ if (!devm_name)
+ return;
+
+ input->name = devm_name;
+
+ ret = wtp_populate_input(hidpp, input);
+ if (ret) {
+ hid_err(hdev,
+ "cannot initialize touchpad input device: %d\n",
+ ret);
+ input_free_device(input);
+ return;
+ }
+
+ ret = input_register_device(input);
+ if (ret) {
+ hid_err(hdev,
+ "cannot register touchpad input device: %d\n",
+ ret);
+ input_free_device(input);
+ return;
+ }
+
+ WRITE_ONCE(wd->input, input);
+ }
+
+ ret = wtp_enable_raw_mode(hidpp);
+ if (ret)
+ return;
+ } else if (hidpp->quirks & HIDPP_QUIRK_CLASS_WTP) {
ret = wtp_connect(hdev);
if (ret)
return;
@@ -4615,7 +4700,12 @@ static void hidpp_connect_event(struct work_struct *work)
return;
}
- hidpp_populate_input(hidpp, input);
+ ret = hidpp_populate_input(hidpp, input);
+ if (ret) {
+ hidpp->input = NULL;
+ input_free_device(input);
+ return;
+ }
ret = input_register_device(input);
if (ret) {
@@ -4755,7 +4845,8 @@ static int hidpp_probe(struct hid_device *hdev, const struct hid_device_id *id)
hidpp_application_equals(hdev, HID_GD_KEYBOARD))
hidpp->quirks |= HIDPP_QUIRK_HIDPP_CONSUMER_VENDOR_KEYS;
- if (hidpp->quirks & HIDPP_QUIRK_CLASS_WTP) {
+ if (hidpp->quirks &
+ (HIDPP_QUIRK_CLASS_WTP | HIDPP_QUIRK_CLASS_KBD_WTP)) {
ret = wtp_allocate(hdev, id);
if (ret)
return ret;
@@ -4885,6 +4976,9 @@ static const struct hid_device_id hidpp_devices[] = {
{ /* Keyboard logitech K400 */
LDJ_DEVICE(0x4024),
.driver_data = HIDPP_QUIRK_CLASS_K400 },
+ { /* Wireless Touch Keyboard Logitech K400 Plus */
+ LDJ_DEVICE(0x404d),
+ .driver_data = HIDPP_QUIRK_CLASS_KBD_WTP },
{ /* Solar Keyboard Logitech K750 */
LDJ_DEVICE(0x4002),
.driver_data = HIDPP_QUIRK_CLASS_K750 },
base-commit: a8fcb3dbf9024da44f1614c42ea16001f4b860b0
--
2.55.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v3] HID: logitech-hidpp: add native touchpad support for K400 Plus
2026-08-24 18:04 [PATCH v3] HID: logitech-hidpp: add native touchpad support for K400 Plus Dmitriy Geels
@ 2026-08-24 18:18 ` sashiko-bot
0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-08-24 18:18 UTC (permalink / raw)
To: Dmitriy Geels; +Cc: linux-input, dmitry.torokhov
Thank you for your contribution! Sashiko AI review found 6 potential issue(s) to consider:
New issues:
- [High] The K400 Plus touchpad is erroneously advertised as a clickpad (buttonpad) without emitting a left button event, breaking userspace interaction.
- [High] Dangling `wd->input` pointer leads to a Use-After-Free if `input_register_device()` fails for `CLASS_WTP` devices.
- [Medium] Missing cleanup of devres-managed memory (`input_dev` and `devm_name`) in the error paths of `hidpp_connect_event()`.
- [Medium] The KBD_WTP touchpad input device gets assigned a generic receiver name instead of the actual human-readable device name.
- [Medium] Data race due to missing `READ_ONCE()` on `wd->input` in event handlers.
Pre-existing issues:
- [High] Dangling `hidpp->input` pointer leads to a Use-After-Free if `input_register_device()` fails inside the HID core.
--
--- Patch [1]: [PATCH v3] HID: logitech-hidpp: add native touchpad support for K400 Plus ---
commit 0b206b299e2d55ee7d52e893ea117f7035ac35a4
Author: Dmitriy Geels <dmitriy.geels@gmail.com>
Subject: HID: logitech-hidpp: add native touchpad support for K400 Plus
The Logitech K400 Plus (WPID 0x404d) exposes its touchpad through the
HID++ TouchpadRawXY feature, but currently operates as an emulated mouse.
Add support for the native raw touchpad reports by creating a separate
multitouch input device.
Link: https://lore.kernel.org/linux-input/20260824173042.13679-1-dmitriy.geels@gmail.com/
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
[ ... ]
> @@ -2963,8 +2966,13 @@ static void wtp_populate_input(struct hidpp_device *hidpp,
> input_set_abs_params(input_dev, ABS_MT_POSITION_Y, 0, wd->y_size, 0, 0);
> input_abs_set_res(input_dev, ABS_MT_POSITION_Y, wd->resolution);
>
> - /* Max pressure is not given by the devices, pick one */
> - input_set_abs_params(input_dev, ABS_MT_PRESSURE, 0, 50, 0, 0);
> + /*
> + * The driver exposes contact area as pressure. Do not advertise a
> + * pressure axis when the device does not report contact area; userspace
> + * may otherwise interpret a permanently-zero pressure value as hover.
> + */
> + if (wd->area_range)
> + input_set_abs_params(input_dev, ABS_MT_PRESSURE, 0, 50, 0, 0);
>
> input_set_capability(input_dev, EV_KEY, BTN_LEFT);
>
> if (hidpp->quirks & HIDPP_QUIRK_WTP_PHYSICAL_BUTTONS)
> input_set_capability(input_dev, EV_KEY, BTN_RIGHT);
> else
> __set_bit(INPUT_PROP_BUTTONPAD, input_dev->propbit);
>
[Severity: High]
The stated intent of this patch is to leave physical button reports on the
existing HID input device. However, since HIDPP_QUIRK_WTP_PHYSICAL_BUTTONS
is not set for the K400 Plus, does this code incorrectly advertise BTN_LEFT
and INPUT_PROP_BUTTONPAD for the new touchpad device?
Userspace libraries like libinput might expect mechanical clicks directly
on the touchpad since it's advertised as a clickpad, but those events
are explicitly suppressed in wtp_send_raw_xy_event() for CLASS_KBD_WTP.
Could this break click-and-drag functionality?
[ ... ]
> @@ -3066,8 +3079,13 @@ static int wtp_raw_event(struct hid_device *hdev, u8 *data, int size)
> struct wtp_data *wd = hidpp->private_data;
> struct hidpp_report *report = (struct hidpp_report *)data;
> struct hidpp_touchpad_raw_xy raw;
> + struct input_dev *input;
>
> - if (!wd || !hidpp->input)
> + if (!wd)
> + return 1;
> +
> + input = wd->input;
> + if (!input)
> return 1;
[Severity: Medium]
The wd->input pointer is published in hidpp_connect_event() using
WRITE_ONCE(wd->input, input).
Should this reader side use READ_ONCE(wd->input) to prevent potential
load tearing or compiler reordering?
[ ... ]
> @@ -4064,14 +4091,22 @@ static int hidpp_input_mapped(struct hid_device *hdev, struct hid_input *hi,
> }
>
>
> -static void hidpp_populate_input(struct hidpp_device *hidpp,
> +static int hidpp_populate_input(struct hidpp_device *hidpp,
> struct input_dev *input)
> {
> + int ret;
> +
> hidpp->input = input;
[Severity: High]
This is a pre-existing issue, but assigning hidpp->input here before the
device is registered can lead to a use-after-free.
If input_register_device() fails later inside the HID core (e.g., in
hidinput_connect()), the core frees the input_dev, but hidpp->input remains
populated with the freed pointer. Can this cause raw event handlers to
dereference the dangling pointer on incoming reports?
[ ... ]
> @@ -4524,7 +4562,54 @@ static void hidpp_connect_event(struct work_struct *work)
> return;
> }
>
> - if (hidpp->quirks & HIDPP_QUIRK_CLASS_WTP) {
> + if (hidpp->quirks & HIDPP_QUIRK_CLASS_KBD_WTP) {
> + struct wtp_data *wd = hidpp->private_data;
> +
> + if (!wd->input) {
> + ret = wtp_get_config(hidpp);
> + if (ret) {
> + hid_err(hdev, "cannot get WTP config: %d\n", ret);
> + return;
> + }
> +
> + input = hidpp_allocate_input(hdev);
> + if (!input) {
> + hid_err(hdev, "cannot allocate touchpad input device\n");
> + return;
> + }
> +
> + devm_name = devm_kasprintf(&hdev->dev, GFP_KERNEL,
> + "%s Touchpad", hidpp->name);
[Severity: Medium]
Does this format the input device name using the generic receiver name
(e.g., "Logitech USB Receiver Touchpad") rather than the actual device name?
The actual device name is fetched using hidpp_get_device_name() and
assigned to hidpp->name further down in hidpp_connect_event(), which
happens after this registration. Could this break userspace configuration
tools or libinput quirks that rely on name matching?
> + if (!devm_name)
> + return;
> +
> + input->name = devm_name;
> +
> + ret = wtp_populate_input(hidpp, input);
> + if (ret) {
> + hid_err(hdev,
> + "cannot initialize touchpad input device: %d\n",
> + ret);
> + input_free_device(input);
> + return;
> + }
[Severity: Medium]
If wtp_populate_input() or input_register_device() fails, we call
input_free_device() but return without cleaning up devm_name.
Since hidpp_connect_event() runs in a workqueue triggered by wireless
connection events, could repeated connection initialization failures leak
the devm_kasprintf() allocations on the parent device's devres list?
[ ... ]
> @@ -4615,7 +4700,12 @@ static void hidpp_connect_event(struct work_struct *work)
> return;
> }
>
> - hidpp_populate_input(hidpp, input);
> + ret = hidpp_populate_input(hidpp, input);
> + if (ret) {
> + hidpp->input = NULL;
> + input_free_device(input);
> + return;
> + }
>
> ret = input_register_device(input);
> if (ret) {
> hidpp->input = NULL;
> input_free_device(input);
> return;
> }
[Severity: High]
If input_register_device() fails here for a CLASS_WTP device, we free the
input device and clear hidpp->input. However, wtp_populate_input() already
saved a copy of this pointer in wd->input.
Does this leave wd->input pointing to freed memory?
If a hardware report arrives shortly after, wtp_raw_event() could bypass
its "!wd->input" check and dereference the pointer, causing a use-after-free.
Should wd->input also be cleared in these error paths?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260824180425.55809-1-dmitriy.geels@gmail.com?part=1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-24 18:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-24 18:04 [PATCH v3] HID: logitech-hidpp: add native touchpad support for K400 Plus Dmitriy Geels
2026-08-24 18:18 ` sashiko-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox