Linux Input/HID development
 help / color / mirror / Atom feed
From: "Rebecca Mara Müller" <rebecca.mara@posteo.de>
To: Paolo Pisati <p.pisati@gmail.com>
Cc: Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <bentiss@kernel.org>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Denis Benato <denis.benato@linux.dev>,
	Luke Jones <luke@ljones.dev>,
	Joshua Leivenzon <hacker1024@users.sourceforge.net>,
	Ivan Levchenko <me@livan.pro>,
	Nathan Chancellor <nathan@kernel.org>
Subject: Re: [PATCH v4 0/7] HID: asus: ASUS Zenbook Duo keyboard support
Date: Wed, 21 Oct 2026 06:02:51 +0000	[thread overview]
Message-ID: <20261021060243.855484-1-rebecca.mara@posteo.de> (raw)
In-Reply-To: <20261020092423.36380-1-p.pisati@gmail.com>

On Tue, Oct 20, 2026 at 11:24:10AM +0200, Paolo Pisati wrote:
> - Drop the delayed handshake re-send: Rebecca measured that the
>   keyboard stays in hotkey mode without it.

Thank you for carrying this, and for the credit.

I tested v4 on the UX8407AA the same way as v3: applied on top of
e16927855d82 (hid.git for-7.4/asus), the resulting hid-asus.c matches
the index line of 7/7, built unmodified as an out-of-tree module
against a 7.0.11-based distribution kernel, with my userspace
workaround stopped.

- Docked (USB, 0b05:1cd7), with the module loaded and then three dock
  cycles: the five keyboard interfaces bind to hid-asus and the
  touchpad stays with hid-multitouch. The descriptor fixup is applied
  to the hotkey interface. The keyboard backlight key and Fn+F
  (balanced <-> performance) work. An evdev reader sees
  KEY_BRIGHTNESSDOWN/UP, KEY_VOLUMEDOWN/UP, KEY_MUTE and KEY_MICMUTE.
- Bluetooth (0b05:1cd8): the keyboard binds to hid-asus and the
  touchpad to hid-multitouch; backlight and Fn+F work. When the
  keyboard switches between USB and Bluetooth, the backlight goes off
  for about a second and comes back at the same level.
- 7/7: the input devices keep their names, "Primax Electronics Ltd.
  ASUS Zenbook Duo Keyboard" over USB and "ASUS Zenbook Duo Keyboard"
  over Bluetooth, the same as with hid-generic.

For the whole series:

Tested-by: Rebecca Mara Müller <rebecca.mara@posteo.de> # UX8407AA

Thanks,
Rebecca

      parent reply	other threads:[~2026-10-21  6:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20  9:24 [PATCH v4 0/7] HID: asus: ASUS Zenbook Duo keyboard support Paolo Pisati
2026-10-20  9:24 ` [PATCH v4 1/7] HID: asus: Fix up Zenbook Duo report descriptors Paolo Pisati
2026-10-20 17:37   ` Denis Benato
2026-10-20  9:24 ` [PATCH v4 2/7] HID: asus: Add missing Zenbook Duo hotkeys Paolo Pisati
2026-10-20  9:24 ` [PATCH v4 3/7] HID: asus: Force hid-input to bind to the Zenbook Duo hotkey interface Paolo Pisati
2026-10-20 17:39   ` Denis Benato
2026-10-20  9:24 ` [PATCH v4 4/7] HID: asus: Cycle the platform profile from the Zenbook Duo profile key Paolo Pisati
2026-10-20 17:40   ` Denis Benato
2026-10-20  9:24 ` [PATCH v4 5/7] HID: asus: Do not send feature reports larger than declared Paolo Pisati
2026-10-20  9:24 ` [PATCH v4 6/7] HID: asus: add prod-id, quirk for Zenbook Duo keyboard Paolo Pisati
2026-10-20  9:24 ` [PATCH v4 7/7] HID: asus: Keep the Zenbook Duo input device names Paolo Pisati
2026-10-20 17:42   ` Denis Benato
2026-10-21  6:02 ` Rebecca Mara Müller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261021060243.855484-1-rebecca.mara@posteo.de \
    --to=rebecca.mara@posteo.de \
    --cc=bentiss@kernel.org \
    --cc=denis.benato@linux.dev \
    --cc=hacker1024@users.sourceforge.net \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke@ljones.dev \
    --cc=me@livan.pro \
    --cc=nathan@kernel.org \
    --cc=p.pisati@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox