Linux Input/HID development
 help / color / mirror / Atom feed
* [PATCH v2 0/5] HID: intel-thc-hid: intel-thc: DMA lifetime fixes
@ 2026-11-18  5:31 Emfox Zhou
  2026-11-18  5:31 ` [PATCH v2 1/5] HID: intel-thc-hid: intel-thc: keep TxDMA write errors Emfox Zhou
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Emfox Zhou @ 2026-11-18  5:31 UTC (permalink / raw)
  To: Even Xu, Xinpeng Sun, Jiri Kosina, Benjamin Tissoires
  Cc: linux-input, linux-kernel

This series fixes the DMA lifetime problems a protocol driver above the
THC core cannot work around, plus two smaller issues next to them.

Patch 1 makes thc_dma_write() report the error it found instead of
overwriting it with the result of the interrupt restore, and stops a
signal from turning a committed transfer into a restartable one. The
completion interrupt has to wake the queue with wake_up(), because the
new wait is uninterruptible.

Patch 2 unwinds a failed allocation through thc_dma_release(), so the
channel whose setup failed is freed too, and frees a scatter-gather list
that was allocated but never mapped.

Patch 3 stops all four engines before thc_dma_unconfigure() clears their
PRD base addresses; only the two receive engines are stopped today.

Patch 4 adds the low frequency SPI gears, down to 2.23 MHz.

Patch 5 gives the engines a drain budget that covers a full frame at that
gear, and leaves the SWDMA path on the old one. thc_dma_unconfigure()
waits for the engines with the same budget before its caller releases
the tables: a start clear is only a request, and an engine still writing
would reach pages that are already back in the allocator.

These apply to v7.4-rc3. They are independent of the PRD table capacity
fix posted separately; the two are both needed for the recovery path to be
complete, but neither depends on the other.

Link to v1: https://lore.kernel.org/r/20261116133132.1282020-1-emfox@debian.org

Changes in v2:
  - Patch 5 waits for the four engines in thc_dma_unconfigure() before
    the tables go away, and is renamed from "budget the receive drain" to
    "budget the engine drain" to cover the transmit side as well. The
    budget it adds is named THC_DMA_DRAIN_US_TIMEOUT for the same reason.
  - Patches 1 to 4 are unchanged in code.

Emfox Zhou (5):
  HID: intel-thc-hid: intel-thc: keep TxDMA write errors
  HID: intel-thc-hid: intel-thc: free the failed channel
  HID: intel-thc-hid: intel-thc: stop all engines first
  HID: intel-thc-hid: intel-thc: add the slow SPI gears
  HID: intel-thc-hid: intel-thc: budget the engine drain

 .../intel-thc-hid/intel-thc/intel-thc-dev.c   |  45 +++++--
 .../intel-thc-hid/intel-thc/intel-thc-dma.c   | 127 ++++++++++++------
 .../intel-thc-hid/intel-thc/intel-thc-dma.h   |   5 +
 3 files changed, 126 insertions(+), 51 deletions(-)


base-commit: aebb7274476403040d582c61478df8f4a7bf9cd3

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-11-18  5:32 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18  5:31 [PATCH v2 0/5] HID: intel-thc-hid: intel-thc: DMA lifetime fixes Emfox Zhou
2026-11-18  5:31 ` [PATCH v2 1/5] HID: intel-thc-hid: intel-thc: keep TxDMA write errors Emfox Zhou
2026-11-18  5:31 ` [PATCH v2 2/5] HID: intel-thc-hid: intel-thc: free the failed channel Emfox Zhou
2026-11-18  5:31 ` [PATCH v2 3/5] HID: intel-thc-hid: intel-thc: stop all engines first Emfox Zhou
2026-11-18  5:31 ` [PATCH v2 4/5] HID: intel-thc-hid: intel-thc: add the slow SPI gears Emfox Zhou
2026-11-18  5:31 ` [PATCH v2 5/5] HID: intel-thc-hid: intel-thc: budget the engine drain Emfox Zhou

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox