Re: [PATCH] HID: logitech-hidpp: Remove duplicate ID for the G703 Hero over USB

[Bastien Nocera <hadess@hadess.net>]

On Mon, 2026-08-03 at 20:25 +0200, Jiri Kosina wrote:
> On Mon, 27 Jul 2026, Bastien Nocera wrote:
> 
> > > The ID appears to be given twice, remove the duplicate
> > > 
> > > Signed-off-by: Stuart Hayhurst <stuart.a.hayhurst@gmail.com>
> > 
> > Indeed, at line 4652:
> >         { /* Logitech G703 Hero Gaming Mouse over USB */
> >           HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) },
> >         { /* Logitech G900 Gaming Mouse over USB */
> >           HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC081) },
> >         { /* Logitech G903 Gaming Mouse over USB */
> >           HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC086) },
> >         { /* Logitech G Pro Gaming Mouse over USB */
> >           HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) },
> >         { /* MX Vertical over USB */
> >           HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08A) },
> >         { /* Logitech G703 Hero Gaming Mouse over USB */
> >           HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) },
> > 
> > Benjamin, Jiri, is there not a way to detect duplicates like this?
> 
> I think the modern way to do this is to ask some LLM to find all of
> them 
> :)

I meant a deterministic way, so I guess that's a no.

Cheers

> 
> > In any case, looks good to me.
> > 
> > Reviewed-by: Bastien Nocera <hadess@hadess.net>
> 
> Thanks a lot, now queued.