From: Bastien Nocera <hadess@hadess.net>
To: Stuart Hayhurst <stuart.a.hayhurst@gmail.com>,
linux-kernel@vger.kernel.org, Jiri Kosina <jikos@kernel.org>
Cc: linux-input@vger.kernel.org,
"Benjamin Tissoires" <bentiss@kernel.org>,
"Filipe Laíns" <lains@riseup.net>
Subject: Re: [PATCH] HID: logitech-hidpp: Remove duplicate ID for the G703 Hero over USB
Date: Mon, 27 Jul 2026 15:07:22 +0200 [thread overview]
Message-ID: <21e8047a869d9d15eaae927fc0282bf0689b69f3.camel@hadess.net> (raw)
In-Reply-To: <20260721173710.500368-2-stuart.a.hayhurst@gmail.com>
On Tue, 2026-07-21 at 18:37 +0100, Stuart Hayhurst wrote:
> The ID appears to be given twice, remove the duplicate
>
> Signed-off-by: Stuart Hayhurst <stuart.a.hayhurst@gmail.com>
Indeed, at line 4652:
{ /* Logitech G703 Hero Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) },
{ /* Logitech G900 Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC081) },
{ /* Logitech G903 Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC086) },
{ /* Logitech G Pro Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) },
{ /* MX Vertical over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08A) },
{ /* Logitech G703 Hero Gaming Mouse over USB */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) },
Benjamin, Jiri, is there not a way to detect duplicates like this?
In any case, looks good to me.
Reviewed-by: Bastien Nocera <hadess@hadess.net>
> ---
> drivers/hid/hid-logitech-hidpp.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-
> logitech-hidpp.c
> index 90b0184df777..b1b1c5cb657c 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -4659,8 +4659,6 @@ static const struct hid_device_id
> hidpp_devices[] = {
> HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) },
> { /* MX Vertical over USB */
> HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08A) },
> - { /* Logitech G703 Hero Gaming Mouse over USB */
> - HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) },
> { /* Logitech G903 Hero Gaming Mouse over USB */
> HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC091) },
> { /* Logitech G915 TKL Keyboard over USB */
next prev parent reply other threads:[~2026-07-27 13:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-21 17:37 [PATCH] HID: logitech-hidpp: Remove duplicate ID for the G703 Hero over USB Stuart Hayhurst
2026-07-27 13:07 ` Bastien Nocera [this message]
2026-08-03 18:25 ` Jiri Kosina
2026-08-03 19:09 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21e8047a869d9d15eaae927fc0282bf0689b69f3.camel@hadess.net \
--to=hadess@hadess.net \
--cc=bentiss@kernel.org \
--cc=jikos@kernel.org \
--cc=lains@riseup.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stuart.a.hayhurst@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox