* [PATCH] HID: logitech-hidpp: Remove duplicate ID for the G703 Hero over USB @ 2026-07-21 17:37 Stuart Hayhurst 2026-07-27 13:07 ` Bastien Nocera 0 siblings, 1 reply; 4+ messages in thread From: Stuart Hayhurst @ 2026-07-21 17:37 UTC (permalink / raw) To: linux-kernel, Jiri Kosina Cc: Stuart Hayhurst, linux-input, Benjamin Tissoires, Bastien Nocera, Filipe Laíns The ID appears to be given twice, remove the duplicate Signed-off-by: Stuart Hayhurst <stuart.a.hayhurst@gmail.com> --- drivers/hid/hid-logitech-hidpp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c index 90b0184df777..b1b1c5cb657c 100644 --- a/drivers/hid/hid-logitech-hidpp.c +++ b/drivers/hid/hid-logitech-hidpp.c @@ -4659,8 +4659,6 @@ static const struct hid_device_id hidpp_devices[] = { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) }, { /* MX Vertical over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08A) }, - { /* Logitech G703 Hero Gaming Mouse over USB */ - HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) }, { /* Logitech G903 Hero Gaming Mouse over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC091) }, { /* Logitech G915 TKL Keyboard over USB */ -- 2.53.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] HID: logitech-hidpp: Remove duplicate ID for the G703 Hero over USB 2026-07-21 17:37 [PATCH] HID: logitech-hidpp: Remove duplicate ID for the G703 Hero over USB Stuart Hayhurst @ 2026-07-27 13:07 ` Bastien Nocera 2026-08-03 18:25 ` Jiri Kosina 0 siblings, 1 reply; 4+ messages in thread From: Bastien Nocera @ 2026-07-27 13:07 UTC (permalink / raw) To: Stuart Hayhurst, linux-kernel, Jiri Kosina Cc: linux-input, Benjamin Tissoires, Filipe Laíns On Tue, 2026-07-21 at 18:37 +0100, Stuart Hayhurst wrote: > The ID appears to be given twice, remove the duplicate > > Signed-off-by: Stuart Hayhurst <stuart.a.hayhurst@gmail.com> Indeed, at line 4652: { /* Logitech G703 Hero Gaming Mouse over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) }, { /* Logitech G900 Gaming Mouse over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC081) }, { /* Logitech G903 Gaming Mouse over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC086) }, { /* Logitech G Pro Gaming Mouse over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) }, { /* MX Vertical over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08A) }, { /* Logitech G703 Hero Gaming Mouse over USB */ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) }, Benjamin, Jiri, is there not a way to detect duplicates like this? In any case, looks good to me. Reviewed-by: Bastien Nocera <hadess@hadess.net> > --- > drivers/hid/hid-logitech-hidpp.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid- > logitech-hidpp.c > index 90b0184df777..b1b1c5cb657c 100644 > --- a/drivers/hid/hid-logitech-hidpp.c > +++ b/drivers/hid/hid-logitech-hidpp.c > @@ -4659,8 +4659,6 @@ static const struct hid_device_id > hidpp_devices[] = { > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) }, > { /* MX Vertical over USB */ > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08A) }, > - { /* Logitech G703 Hero Gaming Mouse over USB */ > - HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) }, > { /* Logitech G903 Hero Gaming Mouse over USB */ > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC091) }, > { /* Logitech G915 TKL Keyboard over USB */ ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] HID: logitech-hidpp: Remove duplicate ID for the G703 Hero over USB 2026-07-27 13:07 ` Bastien Nocera @ 2026-08-03 18:25 ` Jiri Kosina 2026-08-03 19:09 ` Bastien Nocera 0 siblings, 1 reply; 4+ messages in thread From: Jiri Kosina @ 2026-08-03 18:25 UTC (permalink / raw) To: Bastien Nocera Cc: Stuart Hayhurst, linux-kernel, linux-input, Benjamin Tissoires, Filipe Laíns On Mon, 27 Jul 2026, Bastien Nocera wrote: > > The ID appears to be given twice, remove the duplicate > > > > Signed-off-by: Stuart Hayhurst <stuart.a.hayhurst@gmail.com> > > Indeed, at line 4652: > { /* Logitech G703 Hero Gaming Mouse over USB */ > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) }, > { /* Logitech G900 Gaming Mouse over USB */ > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC081) }, > { /* Logitech G903 Gaming Mouse over USB */ > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC086) }, > { /* Logitech G Pro Gaming Mouse over USB */ > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) }, > { /* MX Vertical over USB */ > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08A) }, > { /* Logitech G703 Hero Gaming Mouse over USB */ > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) }, > > Benjamin, Jiri, is there not a way to detect duplicates like this? I think the modern way to do this is to ask some LLM to find all of them :) > In any case, looks good to me. > > Reviewed-by: Bastien Nocera <hadess@hadess.net> Thanks a lot, now queued. -- Jiri Kosina SUSE Labs ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] HID: logitech-hidpp: Remove duplicate ID for the G703 Hero over USB 2026-08-03 18:25 ` Jiri Kosina @ 2026-08-03 19:09 ` Bastien Nocera 0 siblings, 0 replies; 4+ messages in thread From: Bastien Nocera @ 2026-08-03 19:09 UTC (permalink / raw) To: Jiri Kosina Cc: Stuart Hayhurst, linux-kernel, linux-input, Benjamin Tissoires, Filipe Laíns On Mon, 2026-08-03 at 20:25 +0200, Jiri Kosina wrote: > On Mon, 27 Jul 2026, Bastien Nocera wrote: > > > > The ID appears to be given twice, remove the duplicate > > > > > > Signed-off-by: Stuart Hayhurst <stuart.a.hayhurst@gmail.com> > > > > Indeed, at line 4652: > > { /* Logitech G703 Hero Gaming Mouse over USB */ > > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) }, > > { /* Logitech G900 Gaming Mouse over USB */ > > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC081) }, > > { /* Logitech G903 Gaming Mouse over USB */ > > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC086) }, > > { /* Logitech G Pro Gaming Mouse over USB */ > > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC088) }, > > { /* MX Vertical over USB */ > > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08A) }, > > { /* Logitech G703 Hero Gaming Mouse over USB */ > > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC090) }, > > > > Benjamin, Jiri, is there not a way to detect duplicates like this? > > I think the modern way to do this is to ask some LLM to find all of > them > :) I meant a deterministic way, so I guess that's a no. Cheers > > > In any case, looks good to me. > > > > Reviewed-by: Bastien Nocera <hadess@hadess.net> > > Thanks a lot, now queued. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-08-03 19:09 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-07-21 17:37 [PATCH] HID: logitech-hidpp: Remove duplicate ID for the G703 Hero over USB Stuart Hayhurst 2026-07-27 13:07 ` Bastien Nocera 2026-08-03 18:25 ` Jiri Kosina 2026-08-03 19:09 ` Bastien Nocera
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox