Linux Input/HID development
 help / color / mirror / Atom feed
From: pchavent <Paul.Chavent@onera.fr>
To: jkosina@suse.cz, linux-input@vger.kernel.org
Cc: paul.chavent@fnac.net
Subject: [PATCH] HID : core : fix hid delimiter local tag parsing.
Date: Sun, 07 Jul 2013 18:35:39 +0200	[thread overview]
Message-ID: <4754ed7e96bbb6e75d5b61d3997ce8e5@sybille.onecert.fr> (raw)

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

Hi.

When i plug an USB HID device with the DELIMITER tag in its report 
descriptor, the device doesn't load.

The problem comes from the "return 1" in the DELIMITER switch of the 
local tags parsing.

I join a trivial patch that return no error when encounter the 
DELIMITER tag.

Please review it.


Regards.

Paul.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-HID-core-fix-hid-delimiter-local-tag-parsing.patch --]
[-- Type: text/x-c; name=0001-HID-core-fix-hid-delimiter-local-tag-parsing.patch, Size: 674 bytes --]

From d34e7be36d6c392578ac9c81614325f9bff9de93 Mon Sep 17 00:00:00 2001
From: Paul Chavent <paul.chavent@onera.fr>
Date: Sun, 7 Jul 2013 17:43:56 +0200
Subject: [PATCH] HID : core : fix hid delimiter local tag parsing.

---
 drivers/hid/hid-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 36668d1..1e23ae9 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -450,7 +450,7 @@ static int hid_parser_local(struct hid_parser *parser, struct hid_item *item)
 			}
 			parser->local.delimiter_depth--;
 		}
-		return 1;
+		return 0;
 
 	case HID_LOCAL_ITEM_TAG_USAGE:
 
-- 
1.7.12.1


             reply	other threads:[~2013-07-07 16:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-07 16:35 pchavent [this message]
2013-07-12 10:40 ` [PATCH] HID : core : fix hid delimiter local tag parsing Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4754ed7e96bbb6e75d5b61d3997ce8e5@sybille.onecert.fr \
    --to=paul.chavent@onera.fr \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=paul.chavent@fnac.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox