[PATCH] HID : core : fix hid delimiter local tag parsing.

[PATCH] HID : core : fix hid delimiter local tag parsing.

[pchavent]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

Hi.

When i plug an USB HID device with the DELIMITER tag in its report 
descriptor, the device doesn't load.

The problem comes from the "return 1" in the DELIMITER switch of the 
local tags parsing.

I join a trivial patch that return no error when encounter the 
DELIMITER tag.

Please review it.


Regards.

Paul.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-HID-core-fix-hid-delimiter-local-tag-parsing.patch --]
[-- Type: text/x-c; name=0001-HID-core-fix-hid-delimiter-local-tag-parsing.patch, Size: 674 bytes --]

From d34e7be36d6c392578ac9c81614325f9bff9de93 Mon Sep 17 00:00:00 2001
From: Paul Chavent <paul.chavent@onera.fr>
Date: Sun, 7 Jul 2013 17:43:56 +0200
Subject: [PATCH] HID : core : fix hid delimiter local tag parsing.

---
 drivers/hid/hid-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 36668d1..1e23ae9 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -450,7 +450,7 @@ static int hid_parser_local(struct hid_parser *parser, struct hid_item *item)
 			}
 			parser->local.delimiter_depth--;
 		}
-		return 1;
+		return 0;
 
 	case HID_LOCAL_ITEM_TAG_USAGE:
 
-- 
1.7.12.1

Re: [PATCH] HID : core : fix hid delimiter local tag parsing.

[Jiri Kosina]

On Sun, 7 Jul 2013, pchavent wrote:

> When i plug an USB HID device with the DELIMITER tag in its report 
> descriptor, the device doesn't load.
> 
> The problem comes from the "return 1" in the DELIMITER switch of the local
> tags parsing.
> 
> I join a trivial patch that return no error when encounter the DELIMITER tag.
> 
> Please review it.

Interesting; apparently this bug has been there for ages. Please send me 
your Signed-off-by: line as documented in Documentation/SubmittingPatches 
so that I can queue your patch.

Thanks,

-- 
Jiri Kosina
SUSE Labs