Re: [PATCH] hid: wellspring device quirks

[Henrik Rydberg <rydberg@euromail.se>]

Jiri Kosina wrote:
> On Sun, 13 Jul 2008, Henrik Rydberg wrote:
> 
>> This patch adds the HID_QUIRK_IGNORE_MOUSE quirk for the Apple USB
>> multitouch devices based on BCM5974, aka Wellspring. These devices
>> will instead be picked up by the new bcm5974 driver.
> 
> Hi Henrik,
> 
> is the mouse not working at all with standard HID driver?
> 

Yes, it is working out-of-the-box, only poorly.

> I'd prefer to postpone merging this patch until bcm5974 hits mainline if
> the device works in a limited way with standard HID driver, so that we
> don't introduce regression.
> 

Absolutely, this patch should be applied together with the bcm5974 driver,
or not be applied. The driver patch is here:

http://userweb.kernel.org/~akpm/mmotm/broken-out/input-bcm5974-055-smoother-motion-irq-simplification.patch

> If the device doesn't work with HID driver at all though, it is probably
> perfectly fine to merge it right away. Please let me know, I have no
> knowledge about this particular device.

It is fine to leave it, but I would of course prefer to have the driver included together with this patch.

Thanks!
Henrik Rydberg