[PATCH] HID: hid-input: battery quirk for Apple keyboard

[PATCH] HID: hid-input: battery quirk for Apple keyboard

[Ortwin Glück]

Support battery capacity on another Apple wireless
keyboard.

NB: most likely all other APPLE_ALU_WIRELESS_*
keyboards should be added as well.

Signed-off-by: Ortwin Glück <odi@odi.ch>
---
diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 5301006..b2ae097 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -299,6 +299,9 @@ static enum power_supply_property hidinput_battery_props[] = {

  static const struct hid_device_id hid_battery_quirks[] = {
         { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
+                              USB_DEVICE_ID_APPLE_ALU_WIRELESS_2009_ISO),
+         HID_BATTERY_QUIRK_PERCENT | HID_BATTERY_QUIRK_FEATURE },
+       { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
                                USB_DEVICE_ID_APPLE_ALU_WIRELESS_2011_ANSI),
           HID_BATTERY_QUIRK_PERCENT | HID_BATTERY_QUIRK_FEATURE },
         { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,

Re: [PATCH] HID: hid-input: battery quirk for Apple keyboard

[devendra.aaru]

i think you should simply do a  cc: stable@vger.kernel.org just right
above your signedoff-by, which is the way that stable patches gets
into i think.

Re: [PATCH] HID: hid-input: battery quirk for Apple keyboard

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 488 bytes --]

On Sun, 2012-11-25 at 09:13 -0500, devendra.aaru wrote:
> i think you should simply do a  cc: stable@vger.kernel.org just right
> above your signedoff-by, which is the way that stable patches gets
> into i think.

It's OK to cc stable@ when submitting a patch, but that line must be
included in the commit message to ensure it actually gets considered for
stable updates.

Ben.

-- 
Ben Hutchings
Never attribute to conspiracy what can adequately be explained by stupidity.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: [PATCH] HID: hid-input: battery quirk for Apple keyboard

[Jiri Kosina]

On Sun, 25 Nov 2012, Ortwin Glück wrote:

> Support battery capacity on another Apple wireless
> keyboard.

Your patch has been whitespace damaged. I have fixed it by hand and 
applied, but please fix your process for any future patch submissions. 
Thanks.

> NB: most likely all other APPLE_ALU_WIRELESS_* keyboards should be added 
> as well.

I think it's likely true, but I prefer to have it actually tested before 
doing such changes blindly.

Thanks,

-- 
Jiri Kosina
SUSE Labs