From: "Michal Malý" <madcatxster@prifuk.cz>
To: Simon Wood <simon@mungewell.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org
Subject: Re: [PATCH 2/5] Port hid-lg4ff to ff-memless-next
Date: Wed, 05 Feb 2014 10:35:33 +0100 [thread overview]
Message-ID: <7140464.ckcuvrghVW@geidi-prime> (raw)
In-Reply-To: <CADbOyBSXKvRpTB-3NezDhFwggrD7i7qS9e6Aa4JWUe_BynVH3g@mail.gmail.com>
On Wednesday 05 of February 2014 09:41:16 you wrote:
> On Wed, Feb 5, 2014 at 1:08 AM, <simon@mungewell.org> wrote:
> > > Ahh... please disregard this. 2/5 should have the same fix for zero
> > > force
> > > as
> > > we have right now - it should effectively stop the effect when the force
> > > is zero.
> >
> > Hi,
> > We need to think carefully on this as a '+10' combined with '-10' force
> > will result in '0'; however we do not want to deactivate the wheel
> > (no-resistance mode) as this will result in 'ticking' on the wheel as
> > force transitions through 0.... ideally we'd need to know that there are
> > no forces set.
>
> No problem Simon, this is thought about:
> If forces are active, and they cancel out, hid_lg4ff_start_combined is
> called with 0 force (scaled_x = 0x80), instead of hid_lg4ff_stop_combined
> as you assumed.
Okay, so to set things straight: I should modify to patch to send 0x13 when
the effect is fully stopped and use 0x11 0x80 to only zeroize the force when
the overall force is zero? My DFP doesn't differentiate between these states
so I cannot tell what is the right thing to do.
Michal
next prev parent reply other threads:[~2014-02-05 9:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 22:06 [PATCH 0/5] Add ff-memless-next and make hid-lg4ff use it Michal Malý
2014-02-04 22:10 ` [PATCH 1/5] Add ff-memless-next Michal Malý
2014-02-04 22:11 ` [PATCH 2/5] Port hid-lg4ff to ff-memless-next Michal Malý
2014-02-04 22:12 ` [PATCH 3/5] Add support for periodic effects in hid-lg4ff Michal Malý
2014-02-04 22:13 ` [PATCH 4/5] Add support for ramp effect " Michal Malý
2014-02-04 22:14 ` [PATCH 5/5] Remove the note that no driver currently uses ff-memless-next Michal Malý
[not found] ` <CADbOyBS8C+OR5D6EhNCY4O-nMsb5XXdHmkN+8wzj=vT7kXy4pw@mail.gmail.com>
2014-02-04 23:54 ` [PATCH 2/5] Port hid-lg4ff to ff-memless-next Michal Malý
2014-02-05 0:03 ` Michal Malý
2014-02-05 0:08 ` simon
[not found] ` <CADbOyBSXKvRpTB-3NezDhFwggrD7i7qS9e6Aa4JWUe_BynVH3g@mail.gmail.com>
2014-02-05 9:35 ` Michal Malý [this message]
2014-02-20 15:16 ` Jiri Kosina
2014-02-20 15:32 ` Michal Malý
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7140464.ckcuvrghVW@geidi-prime \
--to=madcatxster@prifuk.cz \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=simon@mungewell.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox