[PATCH v2] Input: yealink.rst: Fix typos and word order

[PATCH v2] Input: yealink.rst: Fix typos and word order

[Manuel Ebner]

Improve readability.

Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
CC: Randy Dunlap <rdunlap@infradead.org>
---
[v2]
 add ']' instead of remove '[' as randy suggested
 fix a couple more issues in the file

[v1]
 https://lore.kernel.org/all/20260904121026.759218-3-manuelebnerli@mailbox.org/
---
 Documentation/input/devices/yealink.rst | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/input/devices/yealink.rst b/Documentation/input/devices/yealink.rst
index bb5a1aafe..79ac21690 100644
--- a/Documentation/input/devices/yealink.rst
+++ b/Documentation/input/devices/yealink.rst
@@ -81,7 +81,7 @@ Format description:
 
     Icons or pictograms:
     '.' : For example like AM, PM, SU, a 'dot' .. or other single segment
-	  elements.
+          elements.
 
 
 Driver usage
@@ -120,9 +120,9 @@ Reading /sys/../lineX will return the format string with its current value.
 Writing to /sys/../lineX will set the corresponding LCD line.
 
  - Excess characters are ignored.
- - If less characters are written than allowed, the remaining digits are
+ - If less characters than allowed are written, the remaining digits are
    unchanged.
- - The tab '\t'and '\n' char does not overwrite the original content.
+ - The tab '\t' and newline '\n' char does not overwrite the original content.
  - Writing a space to an icon will always hide its content.
 
   Example::
@@ -205,7 +205,7 @@ Troubleshooting
 :Q: Module yealink compiled and installed without any problem but phone
     is not initialized and does not react to any actions.
 :A: If you see something like:
-    hiddev0: USB HID v1.00 Device [Yealink Network Technology Ltd. VOIP USB Phone
+    hiddev0: USB HID v1.00 Device [Yealink Network Technology Ltd. VOIP USB Phone]
     in dmesg, it means that the hid driver has grabbed the device first. Try to
     load module yealink before any other usb hid driver. Please see the
     instructions provided by your distribution on module configuration.
-- 
2.54.0

Re: [PATCH v2] Input: yealink.rst: Fix typos and word order

[Randy Dunlap]

Hi,

On 9/4/26 11:33 PM, Manuel Ebner wrote:
> Improve readability.
> 
> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
> CC: Randy Dunlap <rdunlap@infradead.org>
> ---
> [v2]
>  add ']' instead of remove '[' as randy suggested
>  fix a couple more issues in the file
> 
> [v1]
>  https://lore.kernel.org/all/20260904121026.759218-3-manuelebnerli@mailbox.org/
> ---
>  Documentation/input/devices/yealink.rst | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/input/devices/yealink.rst b/Documentation/input/devices/yealink.rst
> index bb5a1aafe..79ac21690 100644
> --- a/Documentation/input/devices/yealink.rst
> +++ b/Documentation/input/devices/yealink.rst
> @@ -81,7 +81,7 @@ Format description:
>  
>      Icons or pictograms:
>      '.' : For example like AM, PM, SU, a 'dot' .. or other single segment
> -	  elements.
> +          elements.

Why this whitespace change?
Does it make a difference? does it matter?

>  
>  
>  Driver usage
> @@ -120,9 +120,9 @@ Reading /sys/../lineX will return the format string with its current value.
>  Writing to /sys/../lineX will set the corresponding LCD line.
>  
>   - Excess characters are ignored.
> - - If less characters are written than allowed, the remaining digits are
> + - If less characters than allowed are written, the remaining digits are

s/less/fewer/

>     unchanged.
> - - The tab '\t'and '\n' char does not overwrite the original content.
> + - The tab '\t' and newline '\n' char does not overwrite the original content.

s/char does not/chars do not/ at a minimum.
I would s/char does not/characters do not/ and split that line
into 2 lines if needed.

>   - Writing a space to an icon will always hide its content.
>  
>    Example::
> @@ -205,7 +205,7 @@ Troubleshooting
>  :Q: Module yealink compiled and installed without any problem but phone
>      is not initialized and does not react to any actions.
>  :A: If you see something like:
> -    hiddev0: USB HID v1.00 Device [Yealink Network Technology Ltd. VOIP USB Phone
> +    hiddev0: USB HID v1.00 Device [Yealink Network Technology Ltd. VOIP USB Phone]
>      in dmesg, it means that the hid driver has grabbed the device first. Try to
>      load module yealink before any other usb hid driver. Please see the
>      instructions provided by your distribution on module configuration.

-- 
~Randy