linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: ahmad baghereslami <ahmad.b1995@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Input: synaptics - support the touchpad LED on RMI function $30
Date: Sun, 15 Nov 2026 20:41:48 -0800	[thread overview]
Message-ID: <7f9d0adf1f49c5a2b3919130caf0acb7@gmail.com> (raw)
In-Reply-To: <20261114090808.2572722-1-ahmad.b1995@gmail.com>

Hi Ahmad,

On Sat, Nov 14, 2026 at 12:38:08PM +0330, ahmad baghereslami wrote:
> Some HP laptops have an LED in the top left corner of the Synaptics
> touchpad that HP's Windows driver lights while the touchpad is disabled
> (double tap on that corner). On the HP ZBook 17 G3 (SYN3040, TM2706-002)
> the LED is not driven through the PS/2 deluxe LED command: the Windows
> driver (SynTP.sys 19.0.19.68) switches the touchpad to RMI register
> access over PS/2 with mode byte 0x7f, looks up function $30 (GPIO/LED)
> in the page description table and sets the LED bit in its control
> register:
>
>   register write:  SetScale 2:1, SetRate <reg>, SetRate <value>
>   register read:   SetScale 2:1, SetRate <reg>, GetInfo (first byte)
>
> For touchpads in a new rmi_led_pnp_ids list, look up the F30 LED this
> way when the touchpad is set up and register a
> synaptics::touchpad_disabled LED class device.

Why is this touchpad running in legacy PS/2 mode instead of native RMI4
mode over SMBus (InterTouch / rmi4_smbus)?

Could you please check if booting with psmouse.synaptics_intertouch=1
switches the touchpad (and the pointing stick via F03) to RMI4 over
SMBus on the HP ZBook 17 G3?

If InterTouch works on this machine, we should add "SYN3040" to
smbus_pnp_ids[] in drivers/input/mouse/synaptics.c and implement LED
class support in drivers/input/rmi4/rmi_f30.c (which already parses
f30->has_led and the F30 control register layout), rather than adding
RMI4 PDT scanning and F30 register manipulation over the PS/2 command
backdoor in the legacy PS/2 driver.

Thanks.

-- 
Dmitry

  parent reply	other threads:[~2026-11-16  4:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-30  7:08 [PATCH] Input: synaptics - support the touchpad LED on RMI function $30 ahmad baghereslami
2026-10-30  7:24 ` sashiko-bot
2026-10-31  1:23 ` kernel test robot
2026-10-31  2:29 ` kernel test robot
2026-11-06  9:56 ` [PATCH v2] " ahmad baghereslami
2026-11-06 10:14   ` sashiko-bot
2026-11-14  9:08   ` [PATCH v3] " ahmad baghereslami
2026-11-14  9:24     ` sashiko-bot
2026-11-15 14:20       ` ahmad baghereslami
2026-11-16  4:41     ` Dmitry Torokhov [this message]
2026-11-16  7:19       ` ahmad baghereslami

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f9d0adf1f49c5a2b3919130caf0acb7@gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=ahmad.b1995@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).