Linux Input/HID development
 help / color / mirror / Atom feed
From: Basavaraj Natikar <bnatikar@amd.com>
To: Chen Ni <nichen@iscas.ac.cn>,
	basavaraj.natikar@amd.com, jikos@kernel.org, bentiss@kernel.org,
	Shyam-sundar.S-k@amd.com, mario.limonciello@amd.com
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: amd_sfh: Convert comma to semicolon
Date: Tue, 3 Sep 2024 15:11:15 +0530	[thread overview]
Message-ID: <8b87ecff-4ef9-4749-b85a-43e343d08c9a@amd.com> (raw)
In-Reply-To: <20240903024402.493709-1-nichen@iscas.ac.cn>


On 9/3/2024 8:14 AM, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c
> index 621793d92464..db36d87d5634 100644
> --- a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c
> +++ b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c
> @@ -299,8 +299,8 @@ static void amd_sfh_set_ops(struct amd_mp2_dev *mp2)
>  
>  	sfh_interface_init(mp2);
>  	mp2_ops = mp2->mp2_ops;
> -	mp2_ops->clear_intr = amd_sfh_clear_intr_v2,
> -	mp2_ops->init_intr = amd_sfh_irq_init_v2,
> +	mp2_ops->clear_intr = amd_sfh_clear_intr_v2;
> +	mp2_ops->init_intr = amd_sfh_irq_init_v2;
>  	mp2_ops->suspend = amd_sfh_suspend;
>  	mp2_ops->resume = amd_sfh_resume;
>  	mp2_ops->remove = amd_mp2_pci_remove;

Looks good to me.

Acked-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>

Thanks,
--
Basavaraj



  reply	other threads:[~2024-09-03  9:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-03  2:44 [PATCH] HID: amd_sfh: Convert comma to semicolon Chen Ni
2024-09-03  9:41 ` Basavaraj Natikar [this message]
2024-09-03 11:39 ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b87ecff-4ef9-4749-b85a-43e343d08c9a@amd.com \
    --to=bnatikar@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=basavaraj.natikar@amd.com \
    --cc=bentiss@kernel.org \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=nichen@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox