Re: [PATCH v2 2/2] Input: ili210x - add support for polling mode

[Marek Vasut <marek.vasut@mailbox.org>]

On 1/15/26 4:29 PM, Frank Li wrote:
> On Thu, Jan 15, 2026 at 03:34:59AM +0100, Marek Vasut wrote:
>> There are designs incorporating Ilitek ILI2xxx touch controller that
>> do not connect interrupt pin, for example Waveshare 13.3" DSI display.
>> To support such systems use polling mode for the input device when I2C
>> client does not have interrupt assigned to it.
>>
>> Factor out ili210x_firmware_update_noirq() to allow conditional scoped
>> guard around this code. The scoped guard has to be applied only in case
>> the IRQ line is connected, and not applied otherwise.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
>> ---
>> Cc: Conor Dooley <conor+dt@kernel.org>
>> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>> Cc: Frank Li <Frank.Li@nxp.com>
>> Cc: Job Noorman <job@noorman.info>
>> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
>> Cc: Rob Herring <robh@kernel.org>
>> Cc: devicetree@vger.kernel.org
>> Cc: linux-input@vger.kernel.org
>> Cc: linux-kernel@vger.kernel.org
>> Cc: linux-renesas-soc@vger.kernel.org
>> ---
>> V2: Test client->irq > 0 for IRQ presence
>> ---
>>   drivers/input/touchscreen/ili210x.c | 84 ++++++++++++++++++++---------
>>   1 file changed, 60 insertions(+), 24 deletions(-)
>>
>> diff --git a/drivers/input/touchscreen/ili210x.c b/drivers/input/touchscreen/ili210x.c
>> index fa38d70aded7b..0574f2e86580f 100644
>> --- a/drivers/input/touchscreen/ili210x.c
>> +++ b/drivers/input/touchscreen/ili210x.c
>> @@ -327,9 +327,8 @@ static bool ili210x_report_events(struct ili210x *priv, u8 *touchdata)
>>   	return contact;
>>   }
>>
> 
> ...
>>
>> -	error = devm_request_threaded_irq(dev, client->irq, NULL, ili210x_irq,
>> -					  IRQF_ONESHOT, client->name, priv);
>> -	if (error) {
>> -		dev_err(dev, "Unable to request touchscreen IRQ, err: %d\n",
>> -			error);
>> -		return error;
>> +	input_set_drvdata(input, priv);
>> +
>> +	if (client->irq > 0) {
>> +		error = devm_request_threaded_irq(dev, client->irq, NULL, ili210x_irq,
>> +						  IRQF_ONESHOT, client->name, priv);
>> +		if (error) {
>> +			dev_err(dev, "Unable to request touchscreen IRQ, err: %d\n",
>> +				error);
>> +			return error;
> 
> return dev_err_probe()
Fixed mostly in new patch part of V3 , thanks.