[PATCH] Input: edt-ft5x06 - Support label device property for input name

[PATCH] Input: edt-ft5x06 - Support label device property for input name

[Aaron Kling via B4 Relay]

From: Aaron Kling <webgeek1234@gmail.com>

The AYN Thor uses a ft5426 and a ft5452 for each screen respectively and
these currently get the same input name, making them indistinguishable
from userspace. Support setting a label in kernel dt to make these
report uniquely.

Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
---
 drivers/input/touchscreen/edt-ft5x06.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
index ba8ff65f7ea671..c36497571b1aa1 100644
--- a/drivers/input/touchscreen/edt-ft5x06.c
+++ b/drivers/input/touchscreen/edt-ft5x06.c
@@ -1285,7 +1285,9 @@ static int edt_ft5x06_ts_probe(struct i2c_client *client)
 		"Model \"%s\", Rev. \"%s\", %dx%d sensors\n",
 		tsdata->name, tsdata->fw_version, tsdata->num_x, tsdata->num_y);
 
-	input->name = tsdata->name;
+	if (device_property_read_string(&client->dev, "label", &input->name))
+		input->name = tsdata->name;
+
 	input->id.bustype = BUS_I2C;
 	input->dev.parent = &client->dev;
 

---
base-commit: 3fa7d958829eb9bc3b469ed07f11de3d2804ef71
change-id: 20260409-ft5x06-label-878de0e5f84c

Best regards,
-- 
Aaron Kling <webgeek1234@gmail.com>

Re: [PATCH] Input: edt-ft5x06 - Support label device property for input name

[Dmitry Torokhov]

Hi Aaron,

On Thu, Apr 09, 2026 at 06:16:08PM -0500, Aaron Kling via B4 Relay wrote:
> From: Aaron Kling <webgeek1234@gmail.com>
> 
> The AYN Thor uses a ft5426 and a ft5452 for each screen respectively and
> these currently get the same input name, making them indistinguishable
> from userspace. Support setting a label in kernel dt to make these
> report uniquely.
> 
> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> ---
>  drivers/input/touchscreen/edt-ft5x06.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
> index ba8ff65f7ea671..c36497571b1aa1 100644
> --- a/drivers/input/touchscreen/edt-ft5x06.c
> +++ b/drivers/input/touchscreen/edt-ft5x06.c
> @@ -1285,7 +1285,9 @@ static int edt_ft5x06_ts_probe(struct i2c_client *client)
>  		"Model \"%s\", Rev. \"%s\", %dx%d sensors\n",
>  		tsdata->name, tsdata->fw_version, tsdata->num_x, tsdata->num_y);
>  
> -	input->name = tsdata->name;
> +	if (device_property_read_string(&client->dev, "label", &input->name))
> +		input->name = tsdata->name;
> +

You should be able to differentiate them by their sysfs path.

Thanks.

-- 
Dmitry

Re: [PATCH] Input: edt-ft5x06 - Support label device property for input name

[Aaron Kling]

On Sun, Apr 12, 2026 at 10:58 PM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> Hi Aaron,
>
> On Thu, Apr 09, 2026 at 06:16:08PM -0500, Aaron Kling via B4 Relay wrote:
> > From: Aaron Kling <webgeek1234@gmail.com>
> >
> > The AYN Thor uses a ft5426 and a ft5452 for each screen respectively and
> > these currently get the same input name, making them indistinguishable
> > from userspace. Support setting a label in kernel dt to make these
> > report uniquely.
> >
> > Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> > ---
> >  drivers/input/touchscreen/edt-ft5x06.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
> > index ba8ff65f7ea671..c36497571b1aa1 100644
> > --- a/drivers/input/touchscreen/edt-ft5x06.c
> > +++ b/drivers/input/touchscreen/edt-ft5x06.c
> > @@ -1285,7 +1285,9 @@ static int edt_ft5x06_ts_probe(struct i2c_client *client)
> >               "Model \"%s\", Rev. \"%s\", %dx%d sensors\n",
> >               tsdata->name, tsdata->fw_version, tsdata->num_x, tsdata->num_y);
> >
> > -     input->name = tsdata->name;
> > +     if (device_property_read_string(&client->dev, "label", &input->name))
> > +             input->name = tsdata->name;
> > +
>
> You should be able to differentiate them by their sysfs path.

My target use case is Android, which to my knowledge can only use
vid:pid or device name to differentiate input devices. The sysfs path
does not help this case.

Aaron

Re: [PATCH] Input: edt-ft5x06 - Support label device property for input name

[Dmitry Torokhov]

On Sun, Apr 12, 2026 at 11:02:59PM -0500, Aaron Kling wrote:
> On Sun, Apr 12, 2026 at 10:58 PM Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> >
> > Hi Aaron,
> >
> > On Thu, Apr 09, 2026 at 06:16:08PM -0500, Aaron Kling via B4 Relay wrote:
> > > From: Aaron Kling <webgeek1234@gmail.com>
> > >
> > > The AYN Thor uses a ft5426 and a ft5452 for each screen respectively and
> > > these currently get the same input name, making them indistinguishable
> > > from userspace. Support setting a label in kernel dt to make these
> > > report uniquely.
> > >
> > > Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> > > ---
> > >  drivers/input/touchscreen/edt-ft5x06.c | 4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
> > > index ba8ff65f7ea671..c36497571b1aa1 100644
> > > --- a/drivers/input/touchscreen/edt-ft5x06.c
> > > +++ b/drivers/input/touchscreen/edt-ft5x06.c
> > > @@ -1285,7 +1285,9 @@ static int edt_ft5x06_ts_probe(struct i2c_client *client)
> > >               "Model \"%s\", Rev. \"%s\", %dx%d sensors\n",
> > >               tsdata->name, tsdata->fw_version, tsdata->num_x, tsdata->num_y);
> > >
> > > -     input->name = tsdata->name;
> > > +     if (device_property_read_string(&client->dev, "label", &input->name))
> > > +             input->name = tsdata->name;
> > > +
> >
> > You should be able to differentiate them by their sysfs path.
> 
> My target use case is Android, which to my knowledge can only use
> vid:pid or device name to differentiate input devices. The sysfs path
> does not help this case.

Please work with Android team to add missing functionality.

Thanks.

-- 
Dmitry