From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: David Lechner <dlechner@baylibre.com>
Cc: "Natália Salvino André" <natalia.andre@ime.usp.br>,
andy@kernel.org, bentiss@kernel.org, jic23@kernel.org,
jikos@kernel.org, nuno.sa@analog.com,
srinivas.pandruvada@linux.intel.com,
"Pietro Di Consolo Gregorio" <pietro.gregorio@usp.br>,
linux-iio@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH 1/7] iio: HID: Add helper method hid_sensor_adjust_channel_bit_mask()
Date: Mon, 20 Apr 2026 10:36:41 +0300 [thread overview]
Message-ID: <aeXXiWGJIvdhdBMQ@ashevche-desk.local> (raw)
In-Reply-To: <1c49e011-ae23-4c6f-ad6f-f0b494c2dbbc@baylibre.com>
On Sat, Apr 18, 2026 at 11:32:13AM -0500, David Lechner wrote:
> On 4/17/26 5:58 PM, Natália Salvino André wrote:
> > Add helper method to deduplicate code in HID sensors.
...
> > + /* Real storage bits will change based on the report desc. */
> > + channels[channel].scan_type.realbits = size * 8;
>
> There is a BITS_PER_BYTE macro that would make sense here.
> > + /* Maximum size of a sample to capture is u32 */
> > + channels[channel].scan_type.storagebits = sizeof(u32) * 8;
>
> and here.
FWIW, we have BYTES_TO_BITS().
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-20 7:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 22:58 [PATCH 0/7] iio: HID: Add helper method hid_sensor_adjust_channel_bit_mask() Natália Salvino André
2026-04-17 22:58 ` [PATCH 1/7] " Natália Salvino André
2026-04-18 16:32 ` David Lechner
2026-04-20 7:36 ` Andy Shevchenko [this message]
2026-04-17 22:58 ` [PATCH 2/7] iio: accel: HID: Replace method accel_3d_adjust_channel_bit_mask() Natália Salvino André
2026-04-17 22:58 ` [PATCH 3/7] iio: gyro: HID: Replace method gyro_3d_adjust_channel_bit_mask() Natália Salvino André
2026-04-17 22:58 ` [PATCH 4/7] iio: light: HID: Replace method als_adjust_channel_bit_mask() Natália Salvino André
2026-04-17 22:58 ` [PATCH 5/7] iio: light: HID: Replace method prox_adjust_channel_bit_mask() Natália Salvino André
2026-04-18 16:34 ` David Lechner
2026-04-17 22:58 ` [PATCH 6/7] iio: magnetometer: HID: Replace method magn_3d_adjust_channel_bit_mask() Natália Salvino André
2026-04-17 22:58 ` [PATCH 7/7] iio: pressure: HID: Replace method press_adjust_channel_bit_mask() Natália Salvino André
2026-04-19 13:10 ` [PATCH 0/7] iio: HID: Add helper method hid_sensor_adjust_channel_bit_mask() Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeXXiWGJIvdhdBMQ@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=bentiss@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=natalia.andre@ime.usp.br \
--cc=nuno.sa@analog.com \
--cc=pietro.gregorio@usp.br \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox