From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Zhang Lixu <lixu.zhang@intel.com>
Cc: natalia.andre@ime.usp.br, linux-input@vger.kernel.org,
linux-iio@vger.kernel.org, andy@kernel.org, bentiss@kernel.org,
dlechner@baylibre.com, jic23@kernel.org, jikos@kernel.org,
nuno.sa@analog.com, srinivas.pandruvada@linux.intel.com
Subject: Re: [PATCH v2 1/7] iio: HID: Add helper method hid_sensor_adjust_channel_bit_mask()
Date: Thu, 23 Apr 2026 10:54:30 +0300 [thread overview]
Message-ID: <aenQNrLHqGxbiipb@ashevche-desk.local> (raw)
In-Reply-To: <20260423032038.233475-1-lixu.zhang@intel.com>
On Thu, Apr 23, 2026 at 11:20:38AM +0800, Zhang Lixu wrote:
> On Tue, Apr 21, 2026 at 07:20:33PM -0300, Natália Salvino André wrote:
> > Add helper method to deduplicate code in HID sensors.
...
> > +void hid_sensor_adjust_channel_bit_mask(struct iio_chan_spec *channels,
> > + int channel, int size)
> > +{
> > + channels[channel].scan_type.format = 's';
>
> There is no 'format' field in struct iio_scan_type. This should be:
> channels[channel].scan_type.sign = 's';
Your information is outdated, I believe.
> > + /* Real storage bits will change based on the report desc. */
> > + channels[channel].scan_type.realbits = size * BITS_PER_BYTE;
> > + /* Maximum size of a sample to capture is u32 */
> > + channels[channel].scan_type.storagebits = sizeof(u32) * BITS_PER_BYTE;
> > +}
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-23 7:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 22:20 [PATCH v2 0/7] Add helper method hid_sensor_adjust_channel_bit_mask() Natália Salvino André
2026-04-21 22:20 ` [PATCH v2 1/7] iio: HID: " Natália Salvino André
2026-04-22 9:03 ` Andy Shevchenko
2026-04-23 3:20 ` Zhang Lixu
2026-04-23 7:54 ` Andy Shevchenko [this message]
2026-04-23 8:48 ` Zhang, Lixu
2026-04-21 22:20 ` [PATCH v2 2/7] iio: accel: HID: Replace method accel_3d_adjust_channel_bit_mask() Natália Salvino André
2026-04-22 9:07 ` Andy Shevchenko
2026-04-21 22:20 ` [PATCH v2 3/7] iio: gyro: HID: Replace method gyro_3d_adjust_channel_bit_mask() Natália Salvino André
2026-04-22 9:14 ` Andy Shevchenko
2026-04-21 22:20 ` [PATCH v2 4/7] iio: light: HID: Replace method als_adjust_channel_bit_mask() Natália Salvino André
2026-04-22 9:17 ` Andy Shevchenko
2026-04-21 22:20 ` [PATCH v2 5/7] iio: light: HID: Replace method prox_adjust_channel_bit_mask() Natália Salvino André
2026-04-22 9:16 ` Andy Shevchenko
2026-04-21 22:20 ` [PATCH v2 6/7] iio: magnetometer: HID: Replace method magn_3d_adjust_channel_bit_mask() Natália Salvino André
2026-04-22 9:18 ` Andy Shevchenko
2026-04-21 22:20 ` [PATCH v2 7/7] iio: pressure: HID: Replace method press_adjust_channel_bit_mask() Natália Salvino André
2026-04-22 9:18 ` Andy Shevchenko
2026-04-22 9:21 ` [PATCH v2 0/7] Add helper method hid_sensor_adjust_channel_bit_mask() Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aenQNrLHqGxbiipb@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=bentiss@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=lixu.zhang@intel.com \
--cc=natalia.andre@ime.usp.br \
--cc=nuno.sa@analog.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox