* [PATCH] Input: iqs5xx - Drop unused i2c driver_data
@ 2026-05-15 16:51 Uwe Kleine-König (The Capable Hub)
2026-05-31 5:14 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König (The Capable Hub) @ 2026-05-15 16:51 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Andrew Morton, Randy Dunlap, Andy Shevchenko, linux-input,
linux-kernel
The driver doesn't make use of the value that was explicitly assigned to
the .driver_data members. Drop the assignment. While touching the array,
convert it to use named initialization which is easier to understand.
Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
Hello,
this is related to https://lore.kernel.org/linux-input/20260515164848.497608-2-u.kleine-koenig@baylibre.com/T/#u.
I intended to send it in a series, but failed to do that, so this patch comes
as a separate change.
Best regards
Uwe
drivers/input/touchscreen/iqs5xx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/input/touchscreen/iqs5xx.c b/drivers/input/touchscreen/iqs5xx.c
index 587665e4e6fd..b9bbe8b3eab8 100644
--- a/drivers/input/touchscreen/iqs5xx.c
+++ b/drivers/input/touchscreen/iqs5xx.c
@@ -1049,9 +1049,9 @@ static int iqs5xx_probe(struct i2c_client *client)
}
static const struct i2c_device_id iqs5xx_id[] = {
- { "iqs550", 0 },
- { "iqs572", 1 },
- { "iqs525", 2 },
+ { .name = "iqs550" },
+ { .name = "iqs572" },
+ { .name = "iqs525" },
{ }
};
MODULE_DEVICE_TABLE(i2c, iqs5xx_id);
base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: iqs5xx - Drop unused i2c driver_data
2026-05-15 16:51 [PATCH] Input: iqs5xx - Drop unused i2c driver_data Uwe Kleine-König (The Capable Hub)
@ 2026-05-31 5:14 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2026-05-31 5:14 UTC (permalink / raw)
To: Uwe Kleine-König (The Capable Hub)
Cc: Andrew Morton, Randy Dunlap, Andy Shevchenko, linux-input,
linux-kernel
On Fri, May 15, 2026 at 06:51:34PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> The driver doesn't make use of the value that was explicitly assigned to
> the .driver_data members. Drop the assignment. While touching the array,
> convert it to use named initialization which is easier to understand.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-31 5:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-15 16:51 [PATCH] Input: iqs5xx - Drop unused i2c driver_data Uwe Kleine-König (The Capable Hub)
2026-05-31 5:14 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox