From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-input@vger.kernel.org, open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Input: apbps2: Simplify resource mapping and IRQ retrieval
Date: Sat, 6 Jun 2026 14:01:02 -0700 [thread overview]
Message-ID: <aiSKijPLq7nMVazw@google.com> (raw)
In-Reply-To: <20260603192415.6679-1-rosenp@gmail.com>
On Wed, Jun 03, 2026 at 12:24:15PM -0700, Rosen Penev wrote:
> Simplify resource mapping by using devm_platform_ioremap_resource()
> instead of the longer devm_platform_get_and_ioremap_resource() helper
> as the last argument is NULL.
>
> Additionally, use platform_get_irq() to retrieve the interrupt
> instead of irq_of_parse_and_map() and propagate its error code on
> failure. irq_of_parse_and_map() requires irq_dispose_mapping, which is
> missing.
>
> Assisted-by: Antigravity:Gemini-3.5-Flash
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2026-06-06 21:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 19:24 [PATCH] Input: apbps2: Simplify resource mapping and IRQ retrieval Rosen Penev
2026-06-03 19:33 ` sashiko-bot
2026-06-06 21:01 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiSKijPLq7nMVazw@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox